From patchwork Tue Jan 19 15:42:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jo=C3=A3o_Paulo_Rechi_Vita?= X-Patchwork-Id: 8063421 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 221489F859 for ; Tue, 19 Jan 2016 15:45:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4AF91203A0 for ; Tue, 19 Jan 2016 15:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55A2D2039E for ; Tue, 19 Jan 2016 15:45:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756549AbcASPoP (ORCPT ); Tue, 19 Jan 2016 10:44:15 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:34479 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754673AbcASPoF (ORCPT ); Tue, 19 Jan 2016 10:44:05 -0500 Received: by mail-qk0-f194.google.com with SMTP id u128so2726448qkh.1; Tue, 19 Jan 2016 07:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=AGviMB6nD9J8JJjK2zBHoaBmu0E5kWGgqMqDQprkgFA=; b=Qxa4XguwMOaiOPIn1ZESKTlcsTVQFNg9Xy0WSzArlfm4LNZ4Jd9AhIa9bFDtCxvYPp FluwtENqkHEIwnwyoYID7kpIcjzjhXEUEd2EN0L+365p1PBDhnu+pz/AnGQbfmwbE0m4 kls9tCNd1wYiC68wr2TUxwJ87gjuw0NU+TJSaYoFtPIV6iVe+3a7RlficUK1DrntJthX fzQzwFYLTo55mHRKpNO6TFQi/GP9u4ZSG3dXrbeYion8yvDWnRkAQEqp02w8jhheYRoe 5oFws3KiTWKx/NvoJyRmWUY8fk+IhbfW9iW/OgIMKaNHeJMlBnQwYBt0wvexLI0sDX4P 6hJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=AGviMB6nD9J8JJjK2zBHoaBmu0E5kWGgqMqDQprkgFA=; b=ec3V8qO0Fq4uznc1b8HKcRETpONMOC1Yc9X06yFumr6EfAN/3YWAs1Wqepu4Xp+fIR R4M41YQte0dBKGxfhhtVuilY0x8Fy+IBnaFsplsuTr8zNrgEOZR7qSL4EBvkhFgrfJDQ ZkxxNvsCSSyHugAplDehs8QPMTX6YXvXaCD38rzXJC1+0f4GsYSm2xMbjYJWNtvLIu+8 BJ3peY+DmcMvHd/Cb1m/X0VD9PnScx7uv+IxfO/4V36DTtCvS4iyNjOxK/ZMljdUEyo3 mB5jPnoob0l7ZPa5CVTJZ8bFz7ofH3RXbtSm13yOVYSVZVtnS6JR27oRWi3WmkWuQfxd 61/g== X-Gm-Message-State: ALoCoQlAKMus8WEMf0CFMGJ4DkKVoyLLRkaDBvKVjx3BKY28+kUC4GvDxDXctbtRszkJrU7ASUYNrZ57UTl5sctBDl8u5TrXag== X-Received: by 10.55.207.152 with SMTP id v24mr38798658qkl.100.1453218244230; Tue, 19 Jan 2016 07:44:04 -0800 (PST) Received: from localhost.localdomain (c-98-239-150-235.hsd1.wv.comcast.net. [98.239.150.235]) by smtp.gmail.com with ESMTPSA id z10sm12336759qhz.5.2016.01.19.07.44.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jan 2016 07:44:03 -0800 (PST) From: "=?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?=" X-Google-Original-From: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= To: johannes@sipsolutions.net Cc: marcel@holtmann.org, linux-wireless@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jprvita@endlessm.com, linux@endlessm.com Subject: [PATCH 1/8] rfkill: Documentation and style fixes Date: Tue, 19 Jan 2016 10:42:36 -0500 Message-Id: <1453218163-31998-2-git-send-email-jprvita@endlessm.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1453218163-31998-1-git-send-email-jprvita@endlessm.com> References: <1453218163-31998-1-git-send-email-jprvita@endlessm.com> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes some small typos, punctuation, and copy & paste issues. Also removes an extra blank line. Signed-off-by: João Paulo Rechi Vita --- include/linux/rfkill.h | 7 ++++--- net/rfkill/core.c | 5 ++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h index d901078..3dcbaf6 100644 --- a/include/linux/rfkill.h +++ b/include/linux/rfkill.h @@ -104,16 +104,17 @@ int __must_check rfkill_register(struct rfkill *rfkill); * * Pause polling -- say transmitter is off for other reasons. * NOTE: not necessary for suspend/resume -- in that case the - * core stops polling anyway + * core stops polling anyway. */ void rfkill_pause_polling(struct rfkill *rfkill); /** * rfkill_resume_polling(struct rfkill *rfkill) * - * Pause polling -- say transmitter is off for other reasons. + * Resume polling previously paused with rfkill_pause_polling. * NOTE: not necessary for suspend/resume -- in that case the - * core stops polling anyway + * core restarts polling anyway, even if was explicitly paused + * before suspending. */ void rfkill_resume_polling(struct rfkill *rfkill); diff --git a/net/rfkill/core.c b/net/rfkill/core.c index f53bf3b6..4d6d726 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -303,8 +303,8 @@ static void rfkill_set_block(struct rfkill *rfkill, bool blocked) spin_lock_irqsave(&rfkill->lock, flags); if (err) { /* - * Failed -- reset status to _prev, this may be different - * from what set set _PREV to earlier in this function + * Failed -- reset status to _PREV. This may be different + * from what we have set _PREV to earlier in this function * if rfkill_set_sw_state was invoked. */ if (rfkill->state & RFKILL_BLOCK_SW_PREV) @@ -477,7 +477,6 @@ bool rfkill_get_global_sw_state(const enum rfkill_type type) } #endif - bool rfkill_set_hw_state(struct rfkill *rfkill, bool blocked) { bool ret, change;