From patchwork Wed Jan 20 07:44:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 8069591 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6A1729F440 for ; Wed, 20 Jan 2016 07:45:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9031E203AC for ; Wed, 20 Jan 2016 07:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA363203AA for ; Wed, 20 Jan 2016 07:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933552AbcATHpT (ORCPT ); Wed, 20 Jan 2016 02:45:19 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:32982 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932741AbcATHpR (ORCPT ); Wed, 20 Jan 2016 02:45:17 -0500 Received: by mail-pa0-f68.google.com with SMTP id pv5so41054pac.0 for ; Tue, 19 Jan 2016 23:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Kpjswo8rsafKwp6TnefOpk+d84fI+nCyuiOkxQhu/W0=; b=XFugKVsRBKAD3Axe64vZDcc624fVNRvN3TG9vjMobWJAihBmM+F/FQjFDiIJ1dJW9Z 7kZxmcq5U/UEt4GPMDXulK+uMdjxRs7x+liN+A6EWUqUB/iTmxLnoGhFT+dRXTa3Yj62 WfMd1ILVqaAnMNW8lx1tQ3K13g4a7NF36lt70r7ugNKYZWZ/sNfNTMTSta0Q73G1zt62 57NHpvFM9G8Airuv21cl1wPt/Q7rO49LZ4QqNbLoZgMaI0QSRZpQDogWZpybGHk41jNN Q5hLk3UP0KMtvfMgvTH0+TgLKFfOaKtBCum2bHonuzt+8Kr35DOcbsf4XKv60qPsV8dP 7EkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Kpjswo8rsafKwp6TnefOpk+d84fI+nCyuiOkxQhu/W0=; b=darDtVILUcE7tDttn+GfCAC8l+Rw60CI64D6WIEh+90qUXTMVo1ufUY8+II6KshjcY UC+Nv7XuqfXd/YCNGE4bEurVX0bSI7zZsD67Y4B5X3hh7al4mUSfolgxlm4llY7dzBhX l/r4pq2UmQqn5X8/EjW7joheRIb4OKrNy3Ab/WtRAS3Q2MzlXOykTINt1zau+E5JLapI IR06ipwSXeNReTfGzW8kbg3nBi5iMRcrty6DHygn6QtbeNrqzXdl68wXySmsnxEQ+IS9 WcWatSj99IakWiqX9VsFWw1IdIMkj7Q1NdVcLGgRm5VCA4+Xx0ibd1LGGaTry1RSBtF3 qdig== X-Gm-Message-State: ALoCoQm5oGdYduFLpdBIxKPe2rlyLLE9eioSAA9E1Rc0dw6R3W8vi6tGruirnZkfzoQeJiNRrVJ5kIMqzb4TfvpKKhDPa7F92w== X-Received: by 10.66.163.196 with SMTP id yk4mr51062962pab.115.1453275916898; Tue, 19 Jan 2016 23:45:16 -0800 (PST) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id q27sm46389523pfi.80.2016.01.19.23.45.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jan 2016 23:45:16 -0800 (PST) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH] staging: wilc1000: remove redundant check in wilc_mq_recv Date: Wed, 20 Jan 2016 16:44:57 +0900 Message-Id: <1453275897-13395-1-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.6.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP At the beginning of wilc_mq_recv, it is checked if pHandle->bExiting is false or true. There is no need to check it again at the middle of this function. So just remove it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 098390c..abc780c 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c +++ b/drivers/staging/wilc1000/wilc_msgqueue.c @@ -133,12 +133,6 @@ int wilc_mq_recv(WILC_MsgQueueHandle *pHandle, spin_unlock_irqrestore(&pHandle->strCriticalSection, flags); down(&pHandle->hSem); - - if (pHandle->bExiting) { - PRINT_ER("pHandle fail\n"); - return -EFAULT; - } - spin_lock_irqsave(&pHandle->strCriticalSection, flags); pstrMessage = pHandle->pstrMessageList;