From patchwork Thu Jan 21 11:30:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 8080391 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DD3119F96D for ; Thu, 21 Jan 2016 11:32:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1014C20585 for ; Thu, 21 Jan 2016 11:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A9AB2054D for ; Thu, 21 Jan 2016 11:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965215AbcAULco (ORCPT ); Thu, 21 Jan 2016 06:32:44 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36716 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965191AbcAULcn (ORCPT ); Thu, 21 Jan 2016 06:32:43 -0500 Received: by mail-pf0-f195.google.com with SMTP id n128so1694234pfn.3 for ; Thu, 21 Jan 2016 03:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RcF0wKNFQElcFMbX5r6F1yt5GLVtPhVGkp185zmdsug=; b=nNHPfPuWY211UcSiW/6mxP9uXba0ngubcKgFS+5rzblmKNjI0rt5utSpVXn4mNyVOt ZG2gEMIA3oIO5O6MHZTXaFuJzqFgufI6l43AGgzqhyhPtcYGbLP4Xr3prY4/KQj21j7u GDFPX0o8enJX/N8rf0yowMtxc5yuuH2BBcxgERXHfOYnPGWLCa/XF418jBPWI8Nxtz7/ 4blXIvC/fhDK2wc/KE5f9PZ74iD9j4ldyZxsxRPKyjYdKAcPsgRqajQsfVIi5VNGkPjK imdsQmKjUVyoU5zCrxgwo2zqiIDTHVzioh8l5yVEyIl4/5WD5UjuyVwa69ScVJkJsgpC sTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RcF0wKNFQElcFMbX5r6F1yt5GLVtPhVGkp185zmdsug=; b=W6PHfG/YeBw55qacaWrkkeChK5tlgMsqhaRhafHXNfB1NI5jptUtzLpasZfd5ugDKH IU7UK5xUDCJ0F09pCK8lqReS0X1+kMMibZEmhSFz/uPU/tfw1+oUNHZcurUQKcXwG5IO cW0Bu+d0RCQgcBTmbHCw4JmgcHX1Z98ubOluKycaFq9Y6/f4QOssVqQguGGb8Uo/Vwik v8NMopvBu8QpzyQJjT6ucRt5vYWjOlPhbn7XCb2oXjO7Omx/5P70YuEq2BEqsIKnVn72 GrJoLXUUSa6guvzpVhMqtyJegqHIgoQPDKkThcb9y76QD6bzgsRt5Ce00fi4XBJdTmbi KNLg== X-Gm-Message-State: ALoCoQlHui6Soo2hI9Jkhhdr1wRTqzEOEeqF9i858tlOYSJ9fT07uXeyKKaIgr0fLR86eJw076k/0GWGFGhtqmcMpLxK59AGRQ== X-Received: by 10.98.31.84 with SMTP id f81mr59663262pff.98.1453375963502; Thu, 21 Jan 2016 03:32:43 -0800 (PST) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id 11sm1969754pfq.87.2016.01.21.03.32.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Jan 2016 03:32:42 -0800 (PST) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH V2 19/27] staging: wilc1000: fix return error code Date: Thu, 21 Jan 2016 20:30:49 +0900 Message-Id: <1453375857-20645-20-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453375857-20645-1-git-send-email-chaehyun.lim@gmail.com> References: <1453375857-20645-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Three argument are checked at the beginning of wilc_mq_send whether they are valid arguments or not. It is correct to use return error code as -EINVAL, not -EFAULT. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 764723f..361ca8f 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c +++ b/drivers/staging/wilc1000/wilc_msgqueue.c @@ -61,7 +61,7 @@ int wilc_mq_send(struct message_queue *mq, if ((!mq) || (send_buf_size == 0) || (!send_buf)) { PRINT_ER("mq or send_buf is null\n"); - return -EFAULT; + return -EINVAL; } if (mq->exiting) {