From patchwork Sun Jan 24 12:35:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hubert Tarasiuk X-Patchwork-Id: 8098461 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 98CF09F1CC for ; Sun, 24 Jan 2016 12:35:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B8C95203A0 for ; Sun, 24 Jan 2016 12:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D848820394 for ; Sun, 24 Jan 2016 12:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbcAXMfT (ORCPT ); Sun, 24 Jan 2016 07:35:19 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:32901 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbcAXMfR (ORCPT ); Sun, 24 Jan 2016 07:35:17 -0500 Received: by mail-lb0-f175.google.com with SMTP id x4so62105476lbm.0 for ; Sun, 24 Jan 2016 04:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=9aBMlNQD0FNKLk9emkyJAKsQmJ6sTgToB98nIJ6zRm8=; b=WnXMYGqCQiMm08f4IHkk+SeWWYnzcDcH2H5B7OVsn4GCx82PTabZyh6VVhtRC/e2aZ PsvQwx3pUXoA5iKoMxFeMkSlljKRee+nZFDGikdGx5i6vyFCPXzZ7D36ixbDHOWpfrkq eLiNmaOptSHJpP999jEV+W6Wbz5PmPqDHFSDl8toqGeNFK7zUYt2hm10J4UABX8dYgSn 6YXGbhPZsRgc2imP5HZNaN0UYoS78Kzsuccj9bjKRt9QmVlzE0kmla3r9GFWk4HBStlC L0QYU6oH/htfn0JJoc+c6z0PyU+9KQmM/QYiUpb0PvYtqxNuEn/P17fujnAcFIItOSxZ HnIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9aBMlNQD0FNKLk9emkyJAKsQmJ6sTgToB98nIJ6zRm8=; b=c5mbfeldTnMtdD9ZSXOJGuM48N2PAGrdzFJc4CDdfxA3vn+6lMsB96oP6nhJXp6PSG scJT1VE16z5A0IMqtypqrJph/I2CyhXynGzb4NKF9RN6iGEDDhBogOnNJY0D2ZPw6zxw b1EA7skTFos7oRCsNehRf00xTO2yyM0ts4S/J54KO9nXrRawzNJ5ZlxJgmcG34SH1sh/ xQ26OX8PUxZlC3N6ShN29AFPSdVQQklTR+utrvqXAalGtLpRgPxmbt1LnpEoTssNvQLd KEDImHbRrwqp2KGiIEwtOIkxCNCTnHjfeczxhhaWxjKQl6bRxjhRkBkbYdLlh1oZKg3w M5/A== X-Gm-Message-State: AG10YOQNMeXtUC3oIJOodEEwulGYyOCvJ0auLPK49Xag8Uz49i8xdX8p0VAVtpCfbwFNVg== X-Received: by 10.112.184.133 with SMTP id eu5mr3443997lbc.99.1453638915891; Sun, 24 Jan 2016 04:35:15 -0800 (PST) Received: from ht.wi (89-74-138-4.dynamic.chello.pl. [89.74.138.4]) by smtp.googlemail.com with ESMTPSA id kv3sm2028454lbc.39.2016.01.24.04.35.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 24 Jan 2016 04:35:14 -0800 (PST) From: Hubert Tarasiuk To: linux-wireless@vger.kernel.org Cc: egrumbach@gmail.com, hubert.tarasiuk@gmail.com Subject: [PATCH] iwlwifi: dvm: handle zero brightness for wifi LED Date: Sun, 24 Jan 2016 13:35:06 +0100 Message-Id: <1453638906-19648-1-git-send-email-hubert.tarasiuk@gmail.com> X-Mailer: git-send-email 2.7.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes bug 110551 with regard to sysfs. Misleading behaviour when 'led_mode=3' is passed to iwlwifi is still to be fixed (either by changing the option description or by making the LED permanently dark in such case). Signed-off-by: Hubert Tarasiuk --- drivers/net/wireless/iwlwifi/dvm/led.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlwifi/dvm/led.c b/drivers/net/wireless/iwlwifi/dvm/led.c index ca4d669..218617a 100644 --- a/drivers/net/wireless/iwlwifi/dvm/led.c +++ b/drivers/net/wireless/iwlwifi/dvm/led.c @@ -154,11 +154,14 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev, { struct iwl_priv *priv = container_of(led_cdev, struct iwl_priv, led); unsigned long on = 0; + unsigned long off = 0; if (brightness > 0) on = IWL_LED_SOLID; + else + off = IWL_LED_SOLID; - iwl_led_cmd(priv, on, 0); + iwl_led_cmd(priv, on, off); } static int iwl_led_blink_set(struct led_classdev *led_cdev,