From patchwork Fri Feb 5 01:35:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 8229951 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 74B44BEEE5 for ; Fri, 5 Feb 2016 01:35:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9FDA6202F2 for ; Fri, 5 Feb 2016 01:35:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3070202BE for ; Fri, 5 Feb 2016 01:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbcBEBfr (ORCPT ); Thu, 4 Feb 2016 20:35:47 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36630 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbcBEBfq (ORCPT ); Thu, 4 Feb 2016 20:35:46 -0500 Received: by mail-pf0-f172.google.com with SMTP id n128so59013829pfn.3 for ; Thu, 04 Feb 2016 17:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5d2JuchNBCq9YVAvohVywDehKelZ/7/pY5e2oNIyOKE=; b=JAZZJYccB/G6M0ehEwM+RoNsWsLIoFmyUYBfL+Sx4Xt4Y5yBshBBApMNNO6gGoN33J 9FvtsoR0GEZQuVMAlph5VKPMup2bwhg+znbxjLwi31qAE2AKDleCeDKiTkgdbP2n17A0 VcW34G+x6SrhJDKUec5TfeJe0WiTYNmSvhSlP6vyUno9YAF0AaVHo3CVQ5fErObWPnuB p+/6z3fwyWvyP3hOQDZkXka2mkET/7puIfIHy5QWCA0sZcRvqo/5gNimIe/8EdhZ3/uN at9VbmUZ5VUe2uf/4O0HXoderNvW7C+zX1KSIUMHEf+q8kLP4+2rWCpLvC+HrGJjtYlD mR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5d2JuchNBCq9YVAvohVywDehKelZ/7/pY5e2oNIyOKE=; b=ALyO4Vv1t9GlY5T7ebGFUBGEt1gYjuEF5VezaBgEV+E5h/cvgPgoKfXYYZfoUyaGvl LT2OOTzvExrJ5BRYnVQp+Iilpu93rFDf+I3eZlRpO5HlwhzAfNuA+tmPvV363kvHH4uh BLq2FhUAw5YiSArPDzNJhmWRU6QxXJDgaIZcfiQEjKRanr9Sby+zVGsC+Z7yJe1R0Udf aNektkJx55jZepqP8UobaEz2DpLikX+HSgLSCR4l1x6RAc1etY71c7Y2WQTwnLCgSV42 KYU18AdAwDLwOeXfrSbynoVvM5UBG72dAp23TN0c3SUxIMv3DGvgev1HBxGNqO5ol4bZ JJGQ== X-Gm-Message-State: AG10YOTFTkYlE2TDliXC3zQ/sr64zH7kNcsBU5Rzq5zq/pZ0OXPD0lGedtFxrHXpadn1rQ== X-Received: by 10.98.15.19 with SMTP id x19mr16157317pfi.60.1454636145695; Thu, 04 Feb 2016 17:35:45 -0800 (PST) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id 74sm19960478pfs.33.2016.02.04.17.35.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Feb 2016 17:35:45 -0800 (PST) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH 4/8] staging: wilc1000: fix return error code of wilc_deinit Date: Fri, 5 Feb 2016 10:35:14 +0900 Message-Id: <1454636118-9943-4-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454636118-9943-1-git-send-email-chaehyun.lim@gmail.com> References: <1454636118-9943-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It should be returned error code as -EFAULT instead of 0 when hif_drv is NULL. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 36eeeb4..6c91071 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -3890,7 +3890,7 @@ int wilc_deinit(struct wilc_vif *vif) if (!hif_drv) { PRINT_ER("hif_drv = NULL\n"); - return 0; + return -EFAULT; } down(&hif_sema_deinit);