From patchwork Fri Feb 5 09:56:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 8233171 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A2F589FB33 for ; Fri, 5 Feb 2016 09:57:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BFF3120389 for ; Fri, 5 Feb 2016 09:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D007D202BE for ; Fri, 5 Feb 2016 09:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752614AbcBEJ5J (ORCPT ); Fri, 5 Feb 2016 04:57:09 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35595 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbcBEJ5E (ORCPT ); Fri, 5 Feb 2016 04:57:04 -0500 Received: by mail-pf0-f170.google.com with SMTP id c10so33163pfc.2; Fri, 05 Feb 2016 01:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=dsKckfqGUpDcrP5rhEzLWhGOEvwmQ5E4utpUNPoVAHk=; b=kF+zqlKxYxsKIeFvsCDgGPrevQyIbCblqKi9NuPZAjw9osA3KFs8ZBS8Aj8CYo8WIR I/zMVX5CIkn7PRYWodPSVtuw8Q5jFApPSxXhS7BKfPBMohUVW6qSulqI3O77YsGxC2ZB TyY8HFQuYEHfSa3GP3JcM+YibredD3dRvNQet9jaU2y4alHkDMbAa2O0Ep5tvttkeH33 BSr1br1LJ4NYfS4GUpW9XxLingjQYjWNrVaUuBKc+8bFr1QHlQw0UVv77ZNlN6FJ6Gw3 4fj84MhSjzlH7c4c9hz37H9fqxJX3yCEfJFJj3Bs80CgvhHkCzLlvo4dIwBe61Rp/rdk PVXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dsKckfqGUpDcrP5rhEzLWhGOEvwmQ5E4utpUNPoVAHk=; b=YNXeDhP53AcoRSA0tT0/s43+rtX1/FYObzK+eHj55lC8ocTwp6QYduJKj+jlCzbycA TdVUfYteox1WwqOkLMVZ+JM/XZJ0sRHIN44obTLGxWZN5TPFhDjP7NqiJ7qqJ5q9z4ig BFy24N7UBGnv4gAOQYploH3vsOhy+Fac9tqeUzxvqO6h2T+7ZI7rjurPtIesTP0UGlNF suVjkUvaqyq9Del8FEEJENzbWlFUv5B8Tsj/q/QOFww7nA4kvlEQLZ0SVpVCaxCLb7gp j+eCpR5z5+w1bzL0PR0JkCJQtMOZlBc6gIl3Qfz7nJ/H/gKVa0AIOCSJ/q0o6ww5E7fU AWOQ== X-Gm-Message-State: AG10YOQ5555udRlD2/7/WPsqdKtEmuP9uUoLyhyaO5to+AMFVrNr35crBbLssBRatX/hWQ== X-Received: by 10.98.2.21 with SMTP id 21mr9163402pfc.11.1454666223718; Fri, 05 Feb 2016 01:57:03 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([49.206.197.43]) by smtp.gmail.com with ESMTPSA id l21sm23125743pfi.63.2016.02.05.01.57.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 05 Feb 2016 01:57:03 -0800 (PST) From: Sudip Mukherjee To: Johnny Kim , Austin Shin , Chris Park , Tony Cho , Glen Lee , Leo Kim , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH] staging: wilc1000: fix build failure Date: Fri, 5 Feb 2016 15:26:54 +0530 Message-Id: <1454666214-7825-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP allmodconfig build of alpha, m68k, m32r, tilepro has failed with the error: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c: In function 'wilc_create_wiphy': drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2632:13: error: 'struct wiphy' has no member named 'wowlan' Looking at other drivers wowlan can be only used when CONFIG_PM is defined. Fixes: 73584a40d748 ("staging: wilc1000: add ops resuem/suspend/wakeup in cfg80211") Cc: Glen Lee Signed-off-by: Sudip Mukherjee --- builds of next-20160205. I think I have seen the same report from 0day also when this commit was in staging-testing. drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index 4eede2b..08c28b7 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -2629,7 +2629,9 @@ struct wireless_dev *wilc_create_wiphy(struct net_device *net, struct device *de sema_init(&(priv->SemHandleUpdateStats), 1); priv->wdev = wdev; wdev->wiphy->max_scan_ssids = MAX_NUM_PROBED_SSID; +#ifdef CONFIG_PM wdev->wiphy->wowlan = &wowlan_support; +#endif wdev->wiphy->max_num_pmkids = WILC_MAX_NUM_PMKIDS; PRINT_INFO(CFG80211_DBG, "Max number of PMKIDs = %d\n", wdev->wiphy->max_num_pmkids);