From patchwork Wed Feb 10 16:58:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Protopopov X-Patchwork-Id: 8273341 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 318C3BEEED for ; Wed, 10 Feb 2016 17:00:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EFE352039E for ; Wed, 10 Feb 2016 17:00:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 174BD2034C for ; Wed, 10 Feb 2016 17:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbcBJQ7R (ORCPT ); Wed, 10 Feb 2016 11:59:17 -0500 Received: from mail-qg0-f54.google.com ([209.85.192.54]:33569 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbcBJQ7O (ORCPT ); Wed, 10 Feb 2016 11:59:14 -0500 Received: by mail-qg0-f54.google.com with SMTP id b35so18161548qge.0; Wed, 10 Feb 2016 08:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Qu37R5QXpdMhwEwuoOqftRlzVKF+4s4Mps2UyGxyO68=; b=uG7CtIeMKSTZI5sUd+w0QQOJz2/zo2ScZCr5lra77UwGGUzmy0rtk7wTJ37n49gULg 7qJHS0jiJfDRZ98zcWhtOR0z17GqKyWtaM6G+GGPo97Bm4MaXfvIEFv4hxu90w9eSWAl Rd9SyNN9gLMLn+KDgS+B6cfalGZRqDFPze/wnXCKV8q8ETDPt8QDXhIgRvXDSILMs1hb k5uufRifa6NVkxwQeiKd8vHsG9Ib/HB5iLtMxHPeWNI46Lbz6i8UkFPh4YDA70r7ke5R KJehqYe/1iASLjNK1ZXKgtHyDZ7fOBJ/Je4YLIQR+tkzkcPOtNzq9xrISlpRtEg6IckX erVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Qu37R5QXpdMhwEwuoOqftRlzVKF+4s4Mps2UyGxyO68=; b=csCjMcVAg/WNmke8el71MMDDvHZ+ZDSrr/abm2eAR/gDcY5XKvnOZT7bVubMEi3eh4 wtruNiff0cMRn6w5AqDMpDzzg5n+GclMk04flGXTyza6PMcMbnCgvSK2i3RH4aWEVpib z1ctxC4Ehg3iK4WacSPk9T67ZLKjmObqjM6eeDKChB7Z/WpJMD465ldECp1ua2Ii3RtA gGMazATKSGGyfypDWAvWs39UQbshkE3CxejkqyBAJrlin7eAe4dJIBMeXM8IHaCkEqyj Y3VFlpcHicjO8SdXKVi272LXDX3PRhv6WtFu4S03IXPUo7U13T289fIYR1df4mzuy2Bi KLPA== X-Gm-Message-State: AG10YOQ+penqDXydlYwtClehP5kz481r9u7VFLaP4nGQq8iq04eAH3zJ3OfINfL7RkQ5mA== X-Received: by 10.140.133.133 with SMTP id 127mr12980449qhf.42.1455123554088; Wed, 10 Feb 2016 08:59:14 -0800 (PST) Received: from darkavanger325.localdomain (c-76-124-149-72.hsd1.nj.comcast.net. [76.124.149.72]) by smtp.gmail.com with ESMTPSA id z132sm1650819qka.14.2016.02.10.08.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Feb 2016 08:59:13 -0800 (PST) From: Anton Protopopov To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Anton Protopopov Subject: [PATCH] ath10k: fix erroneous return value Date: Wed, 10 Feb 2016 11:58:55 -0500 Message-Id: <1455123535-26751-1-git-send-email-a.s.protopopov@gmail.com> X-Mailer: git-send-email 2.6.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ath10k_pci_hif_exchange_bmi_msg() function may return the positive value EIO instead of -EIO in case of error. Signed-off-by: Anton Protopopov Reviewed-by: Julian Calaby --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index ee925c6..526acde 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1756,7 +1756,7 @@ static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar, DMA_FROM_DEVICE); ret = dma_mapping_error(ar->dev, resp_paddr); if (ret) { - ret = EIO; + ret = -EIO; goto err_req; }