From patchwork Thu Feb 11 04:46:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 8276601 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 657A3BEEE5 for ; Thu, 11 Feb 2016 04:46:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 590E42026C for ; Thu, 11 Feb 2016 04:46:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FFA3202EB for ; Thu, 11 Feb 2016 04:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbcBKEqg (ORCPT ); Wed, 10 Feb 2016 23:46:36 -0500 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36442 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbcBKEqf (ORCPT ); Wed, 10 Feb 2016 23:46:35 -0500 Received: by mail-pa0-f65.google.com with SMTP id y7so628594paa.3 for ; Wed, 10 Feb 2016 20:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=QWdXlMJuWoc9efDS3kBB8ISBU5mkmE6ZsKLD3Lop65A=; b=sOwH+sgEYBxyZnjdeAaL3Qnzb6xfJUxK5eo4WXWjjqTiP+FyhUN3BCDSRXsJk69e+E BePf9v+xc9CRwCOL6BPje92RDVl0qMRbEniCjVQrBY9bbGnIJa3d8AGvkjUkZADUp9Hx Medk6f+hYmKcTxgLjcUnC1G6UcOTfZWZvp9eSiiZUmbBD93DJ1Q/Hxijiotdsqjra0tX mkA4DCwAWd3wsHmY6NAo7i9Gh3KxDlKJhaOZ23fHjYUTC95hwqJN2+PmxsV58DnG6pmh Im2sI9rqiNohW3HF5jUiULddqVqKVa9LDplCv7les1tQWILkmdLaFXMn6eDeBOjyk5Uf wLzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QWdXlMJuWoc9efDS3kBB8ISBU5mkmE6ZsKLD3Lop65A=; b=eBTPTuv8b6UrS+vFWOE8rEzfi8oGRWOaPOkx+3mEbM63GdvUNBL+WepA+9nmMoGtfM aCBctUlKpuYbRtk8aS6c87Kln4Txp6Fy3rSYRTR9CVUIBqr0H7mypE5pNQaHF35Lwvvq SwitRN1UME103XNPtssVuM8YVCchRy/wQBX5jvJ0gzzaQktnQbj9LwMHuewHgDMVnZ0G dyKIx0MWLStqMt1tlqZ+G5WSHk3lwrpKvQ7X4ZVg7fr4W1ECCkAUiV6wEW2qwP8JW4VU LmAfHZB7WjV9ofRCC/B/jpvEXrHozjYNtEDEsTKNG+sED26SfjxQzC/9MyWJklBBcVV9 8PyQ== X-Gm-Message-State: AG10YOReAcxcmsg4eihS+bGUA6bpKjjr60iM9hcueCU2FGmLGUs/DCptlsK2AJfpnGrnCg== X-Received: by 10.67.2.10 with SMTP id bk10mr62668902pad.26.1455165995409; Wed, 10 Feb 2016 20:46:35 -0800 (PST) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id v75sm8606214pfa.39.2016.02.10.20.46.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Feb 2016 20:46:34 -0800 (PST) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH V2 1/4] staging: wilc1000: fix return type of wilc_send_config_pkt Date: Thu, 11 Feb 2016 13:46:22 +0900 Message-Id: <1455165985-5509-1-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.7.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return value of wilc_wlan_cfg_set or wilc_wlan_cfg_set. It is better to use int type to represent linux standard error code. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- drivers/staging/wilc1000/wilc_wlan.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 98b21d4..2bc2970 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -1349,10 +1349,11 @@ int wilc_wlan_cfg_get_val(u32 wid, u8 *buffer, u32 buffer_size) return ret; } -s32 wilc_send_config_pkt(struct wilc_vif *vif, u8 mode, struct wid *wids, +int wilc_send_config_pkt(struct wilc_vif *vif, u8 mode, struct wid *wids, u32 count, u32 drv) { - s32 counter = 0, ret = 0; + s32 counter = 0; + int ret = 0; if (mode == GET_CFG) { for (counter = 0; counter < count; counter++) { diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wlan.h index d362fa8..06d02ab 100644 --- a/drivers/staging/wilc1000/wilc_wlan.h +++ b/drivers/staging/wilc1000/wilc_wlan.h @@ -301,6 +301,6 @@ void host_sleep_notify(struct wilc *wilc); extern bool wilc_enable_ps; void chip_allow_sleep(struct wilc *wilc); void chip_wakeup(struct wilc *wilc); -s32 wilc_send_config_pkt(struct wilc_vif *vif, u8 mode, struct wid *wids, +int wilc_send_config_pkt(struct wilc_vif *vif, u8 mode, struct wid *wids, u32 count, u32 drv); #endif