From patchwork Fri Feb 12 14:04:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 8291991 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BDBC59F6E4 for ; Fri, 12 Feb 2016 14:05:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E256720397 for ; Fri, 12 Feb 2016 14:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A1322035D for ; Fri, 12 Feb 2016 14:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbcBLOFT (ORCPT ); Fri, 12 Feb 2016 09:05:19 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34173 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbcBLOFN (ORCPT ); Fri, 12 Feb 2016 09:05:13 -0500 Received: by mail-pf0-f195.google.com with SMTP id 71so4033611pfv.1 for ; Fri, 12 Feb 2016 06:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=20gne4+4tEVsyeD+vsTxZcVYtLB2rNavi1fg16Bov3M=; b=RDf0sBBQ+/0xPzHVVCUGzy7+u9Avibm5wYu196Ev1U9jKKkYa6NjU/DMReHjxDKSkr r33kriKMEqoptZClGPGADDz1CfZNT91R3PwVa2NYdMV3fww/8dN6FKQ5DKQSzOZPhzqW IMkyrxQ6dRJhC+jAF+MBvtZWtugZNFca0yVSiKlRV79FMq6ge7+SKWK0F6SuH9r77yMd NcbvwdLe3CNKEaEike89Iug5whuOqKf+hucZn004ABmkzguFPbfVWNrOnOnuuC26j7OR dSmwEcmauoUQBsPQC1PduTyZ/f+rLIo5EXyTpg4ZT7Og6FmqcsBjEGJW3soy8RaIoygD 0wBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=20gne4+4tEVsyeD+vsTxZcVYtLB2rNavi1fg16Bov3M=; b=NRJUlRWLHx0Aus5JqvRNQWEi90akEdYkensKiPvXX1/5xRMor8mMIpZwR8PQjXhGpK exL6iT7XZcRYXNuH7sY/hB24T85ASXHXFcNuhBm/h6lnQdwCiQ9OagsEAs6v8XmJ0zQp H2qMCALabFNJA/5Lu46gUbL0Anind7xbkT+H/tM1rHcc8J91CXzL29a3AqybWCpLcGja a6+8MYMR7IgqXMm8lWFDQvT+RlGSbSyR0Rj7/y6nOOYSp+Ob2w2cXgyZvqGT5ptP69+/ hwtVy/WKvUf1so/4UOF6EOSkDfDp4q1yAiQmCBbGdLTM4yPD9lDwvmrRq7EvFuiD83+/ hjhw== X-Gm-Message-State: AG10YOQG1xYh8R8lxertvUFDPRLtZN6cUa7twOoADbO0vdXeP/RT9t39av6gXI5Y264h2g== X-Received: by 10.98.66.75 with SMTP id p72mr2432364pfa.50.1455285913188; Fri, 12 Feb 2016 06:05:13 -0800 (PST) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id u64sm19814147pfa.86.2016.02.12.06.05.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Feb 2016 06:05:12 -0800 (PST) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH 08/11] staging: wilc1000: change handle_set_channel's return type to void Date: Fri, 12 Feb 2016 23:04:44 +0900 Message-Id: <1455285887-29946-8-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.7.1 In-Reply-To: <1455285887-29946-1-git-send-email-chaehyun.lim@gmail.com> References: <1455285887-29946-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When handle_set_channel is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index e9a6aa7..eecd697 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -299,8 +299,8 @@ static struct wilc_vif *wilc_get_vif_from_idx(struct wilc *wilc, int idx) return wilc->vif[index]; } -static s32 handle_set_channel(struct wilc_vif *vif, - struct channel_attr *hif_set_ch) +static void handle_set_channel(struct wilc_vif *vif, + struct channel_attr *hif_set_ch) { s32 result = 0; struct wid wid; @@ -313,12 +313,8 @@ static s32 handle_set_channel(struct wilc_vif *vif, result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1, wilc_get_vif_idx(vif)); - if (result) { + if (result) PRINT_ER("Failed to set channel\n"); - return -EINVAL; - } - - return result; } static s32 handle_set_wfi_drv_handler(struct wilc_vif *vif,