From patchwork Wed Apr 6 23:10:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 8767101 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 803049F3D1 for ; Wed, 6 Apr 2016 23:11:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AE4C8201BB for ; Wed, 6 Apr 2016 23:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBA60201B9 for ; Wed, 6 Apr 2016 23:11:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553AbcDFXLT (ORCPT ); Wed, 6 Apr 2016 19:11:19 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:34752 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754474AbcDFXLS (ORCPT ); Wed, 6 Apr 2016 19:11:18 -0400 Received: by mail-pa0-f67.google.com with SMTP id hb4so5263796pac.1 for ; Wed, 06 Apr 2016 16:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5MD6V7/dNFdW5iOGXOc2G+gb5ZE1hI5HV8SE++35jyU=; b=To5hnXIX+ssBtQsfCqbiH5pbC0q10Rk4c3x1S7M4iWed0+5SCMtAE5ooThLvbM7Vao UJqlDwYWg2u9fKGP6hF5aNfHAlPxv0RVpPj3X968UNsw7OBRn3OsWR94aU3R6gf58waz HCMxO3QgGV5bo7T10/vWbvNnqYzGDAfEwzP9JHng0nJlSZhunGsICbgpB7F1AN5ohcv2 zObAYOMUgZ6ZQZkQ3btKXEDL0boCsg0kUzNbIvn+LaAcx0QqkGrT+aQWszKuFSSF96Av ZSdYkY5GA27Er0UuCBwngCaLYMvSw79VXLUOKBSQiI53NpN0rM4zv1U8Rk3URmw67/FI I4Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5MD6V7/dNFdW5iOGXOc2G+gb5ZE1hI5HV8SE++35jyU=; b=NQ8uJyZirstm5Id3w5K3xZgzFTYpdzi+ba/MMp2URgUOoGWzxL13FNUysqeSq6CjL6 guq26xaJcY54nzzicQJgl/xxUoOm0JYNt0nFz1DYzkosbIBFPdD4LA1UVGyxyNl8SiX0 EHA0HjaNKDbVui6pXun3sFI/7hu2Fd1ixe5dxSx+DfUm0NrxR5+ZU9CpMwzpxlx/nfoF 2M4Tawx5HLowPAi5ch9mFo3kAZipheVMoDThOTrQ73UqVN4PkQ3N6N6BY64lGjTjzisH mK5w+jjFdq35GkjUpOSpGhBiD6NzK2QSeY772XNRz3RoDOBdGJFEWssp4dYAvYPvhBSz X2xQ== X-Gm-Message-State: AD7BkJK5BO15WndcRKiMUbgwHbucf05a+eWsexI5ByXIhtQaUPLevyoKfBFOWaCdKwmotQ== X-Received: by 10.66.54.78 with SMTP id h14mr74461613pap.95.1459984277932; Wed, 06 Apr 2016 16:11:17 -0700 (PDT) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id g6sm7282818pfg.15.2016.04.06.16.11.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Apr 2016 16:11:17 -0700 (PDT) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH 5/7] staging: wilc1000: change handle_set_operation_mode's return type to void Date: Thu, 7 Apr 2016 08:10:41 +0900 Message-Id: <1459984243-4689-5-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1459984243-4689-1-git-send-email-chaehyun.lim@gmail.com> References: <1459984243-4689-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When handle_set_operation_mode is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 4fd429e..ecf4ddc 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -328,8 +328,8 @@ static void handle_set_wfi_drv_handler(struct wilc_vif *vif, netdev_err(vif->ndev, "Failed to set driver handler\n"); } -static s32 handle_set_operation_mode(struct wilc_vif *vif, - struct op_mode *hif_op_mode) +static void handle_set_operation_mode(struct wilc_vif *vif, + struct op_mode *hif_op_mode) { s32 result = 0; struct wid wid; @@ -345,12 +345,8 @@ static s32 handle_set_operation_mode(struct wilc_vif *vif, if ((hif_op_mode->mode) == IDLE_MODE) complete(&hif_driver_comp); - if (result) { + if (result) netdev_err(vif->ndev, "Failed to set driver handler\n"); - return -EINVAL; - } - - return result; } static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)