From patchwork Tue May 10 06:21:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei-Ning Huang X-Patchwork-Id: 9054541 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9367ABF29F for ; Tue, 10 May 2016 06:21:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B5B7C2012B for ; Tue, 10 May 2016 06:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D80EB20123 for ; Tue, 10 May 2016 06:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751096AbcEJGVi (ORCPT ); Tue, 10 May 2016 02:21:38 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35759 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcEJGVh (ORCPT ); Tue, 10 May 2016 02:21:37 -0400 Received: by mail-pa0-f50.google.com with SMTP id iv1so1919875pac.2 for ; Mon, 09 May 2016 23:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=9eXidDA/nJueCiqEpHgSbiEIQNqzUSIFxGFhb64Ikyk=; b=NGXSl4Vp7RGuy+N72/m6koes3Ma3QYbN8BHl584uvDX8dsqGL5a1jPR1P052FIslOp Yd9nDYwmqndwBEFnuNb2m0v5YQeOt3HTlvqR/6P/2ZytD4EmbdoK5AH6nxJBykVwl2iW mkPzkLqs4XjDL1IjNjLFtysAYYFo4UcEI+318= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9eXidDA/nJueCiqEpHgSbiEIQNqzUSIFxGFhb64Ikyk=; b=R39Fe5yjeLBya8aRnPhlldYowO3hrRUTOkHrllhRlnRYjb7BONFxsizifbPqYMKnTq oIHXr3GZXIJkJAbRwQZ5P1YXIqtSDKWIloszRQebeePO3Skj1oDBDr/bk5lPpZ/JAvzu HnugZ9ol3VRWaGxEJNZAUiP4FL6/QnuC/4mOVQvwQFxe6Y1JaUlaIgw9TbT3eZCRg5Xg PW4QPtwiljffzfO5IpEEYT5nG+Rn+7MUDmXHvPsPUaRdUy2npUNEu8sgo2iipv/4+cYI v1bWAJvOtwpylyBeG3as8LEII11JwDlxCfGDrluR9y+k61gN2Fw8PuxS4ByCBMXTzZBe 0+iQ== X-Gm-Message-State: AOPr4FV2VxMVh5Pue1vl8oKCLgIHIh+PT36HjN7GuHG2uB+qVDEAYe+QCEqeYOOrKfQQ9vB0 X-Received: by 10.66.63.98 with SMTP id f2mr56471655pas.123.1462861296295; Mon, 09 May 2016 23:21:36 -0700 (PDT) Received: from wnhuang0.tpe.corp.google.com ([172.30.210.18]) by smtp.gmail.com with ESMTPSA id f67sm1238165pff.62.2016.05.09.23.21.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 May 2016 23:21:35 -0700 (PDT) From: Wei-Ning Huang To: Linux-Wireless Cc: LKML , Wei-Ning Huang Subject: [PATCH] mwifiex: fixup error messages Date: Tue, 10 May 2016 14:21:23 +0800 Message-Id: <1462861283-11103-1-git-send-email-wnhuang@chromium.org> X-Mailer: git-send-email 2.1.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use dev_err instead of pr_err and add newline character at the end. Signed-off-by: Wei-Ning Huang --- drivers/net/wireless/marvell/mwifiex/sdio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index 099722e..bdc51ff 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -104,7 +104,7 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) if (!dev->of_node || !of_match_node(mwifiex_sdio_of_match_table, dev->of_node)) { - pr_err("sdio platform data not available"); + dev_err(dev, "sdio platform data not available\n"); return -1; } @@ -115,7 +115,8 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) if (cfg && card->plt_of_node) { cfg->irq_wifi = irq_of_parse_and_map(card->plt_of_node, 0); if (!cfg->irq_wifi) { - dev_err(dev, "fail to parse irq_wifi from device tree"); + dev_err(dev, + "fail to parse irq_wifi from device tree\n"); } else { ret = devm_request_irq(dev, cfg->irq_wifi, mwifiex_wake_irq_wifi,