From patchwork Wed May 25 22:44:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 9136341 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F31856075C for ; Wed, 25 May 2016 22:59:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6B6528123 for ; Wed, 25 May 2016 22:59:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB0C7282D8; Wed, 25 May 2016 22:59:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87B7428123 for ; Wed, 25 May 2016 22:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbcEYW6g (ORCPT ); Wed, 25 May 2016 18:58:36 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:33048 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbcEYW6f (ORCPT ); Wed, 25 May 2016 18:58:35 -0400 Received: by mail-vk0-f66.google.com with SMTP id m81so176602vka.0; Wed, 25 May 2016 15:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qHkaYN33NvRV7++pB91UDWLXyVGHkURSGY7f2KfCgRw=; b=0a3lk28k2I/tiv+70AO3WXq0jStZwd6aEzqdFj0pLM9JTvS/AjLZ1H61Zn0u5lCexB CxBoeIhFgQq8jpqy8xPwXy8SdcrlUujclPUz9Xaq56eBQMor9x4WGtEQB3RopOsWH68T t1KoYjOGd51nz6QNQf0Fmh2fr0YYsh3W9eFI5do+Asvh/Wz4xsa6yN9LSm//37mYxJ5H hTzRXUDKn+jxw5+RBpbs5y6aIoItsNsk2dGZUlefkl/XFSnSRMvG7jE4hbBI26vT3XTh eSjvBlA4gTLlo7lxRRmRMl8fsGHqMN52TfQHfgq79JWJ9dSDiYkeiwI8mPtkz1UfSyDU 1Niw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qHkaYN33NvRV7++pB91UDWLXyVGHkURSGY7f2KfCgRw=; b=Pc1K12UJHHrNfnjWmCznWx7X1prCWmYMIsjxvzKuAppX39lYvczREP4hpd6SVg1aPv OCXBHPD/GsrIArNiR3F+tgs6CnGsjQ3o5mcuBhWpzyulNQsUro6yWRfcZCU4BnexEQn/ VTtEMqgZEIBmuuWJHOY7I82Tk9EDWHewUkzO19orpTdYgmmWuqVa+H5LABHQG66sZadG F2T0pOhqNH8nQ29ZcegZ5jhlsgD49/pfB91D4AAaHI+CT5ymDDOnfAJWgAGLgnTXuM+4 wt+dreQEvw3hbfuhS6s9t1RmATnhdAWeCE1RG7Gp01KB4exAPk0/n3wmRXsurNrdxj4H Ifww== X-Gm-Message-State: ALyK8tJWix62+fQQ2Hgex9DQpQZZvNtKSiyNoXrMStL6AHB0fcT7MiwV/nBGq207mg2+DA== X-Received: by 10.25.209.21 with SMTP id i21mr1833185lfg.20.1464216316413; Wed, 25 May 2016 15:45:16 -0700 (PDT) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id d126sm1820849lfd.42.2016.05.25.15.45.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 May 2016 15:45:15 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Kalle Valo Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Brett Rudley , Arend van Spriel , "Franky (Zhenhui) Lin" , Hante Meuleman , Pieter-Paul Giesberts , linux-wireless@vger.kernel.org (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list@broadcom.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails Date: Thu, 26 May 2016 00:44:55 +0200 Message-Id: <1464216299-25232-1-git-send-email-zajec5@gmail.com> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1464123910-8281-1-git-send-email-zajec5@gmail.com> References: <1464123910-8281-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki --- V2: s/in/if/ in commit message V3: Add one more error message as suggested by Arend --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index 1652a48..bc26aec 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, sizeof(if_request)); if (err) - return err; + brcmf_err("p2p_ifadd failed %d\n", err); return err; } @@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name, err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr, iftype); if (err) { + brcmf_err("Failed to request P2P virtual interface %s\n", name); brcmf_cfg80211_arm_vif_event(cfg, NULL); goto fail; }