From patchwork Fri Jun 10 00:46:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruno Herrera X-Patchwork-Id: 9168709 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9E06A6048F for ; Fri, 10 Jun 2016 00:47:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 90C472835E for ; Fri, 10 Jun 2016 00:47:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8583128369; Fri, 10 Jun 2016 00:47:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2289D2835E for ; Fri, 10 Jun 2016 00:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbcFJArJ (ORCPT ); Thu, 9 Jun 2016 20:47:09 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:34342 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbcFJArH (ORCPT ); Thu, 9 Jun 2016 20:47:07 -0400 Received: by mail-qk0-f193.google.com with SMTP id i187so4268624qkd.1; Thu, 09 Jun 2016 17:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=69FOfqrKSfJXVsmpLPRa+VbxKeUp18dMsmGgJ+9m/dM=; b=j4zKZy2ZRDBOezRqT/ANHURVssOKpJe6ZKotG+yZq7n/4E1LtkwBzVvwFxdQApvYac D40RpSqf+jiYuCs558YJnCiVfWzOP85AoXsc/Ec53G5taJzsre39S0z1+YQkV5JG4cT2 H5v5r/9fFFeooYemwDyzuCPaAOqi2NuCS1goKlqurnuQeIPDduZJui9TzHjwKuTUaF2f CS1m5IMp1syHCYurpy3Za8jESHcFkeCK7lTwWTfheCPRufZlaHl6p3we0PudiUr/7O7U zlX+vmaUEKNcPlBjOKm+CLBooFaYoEO8AdAdgTq1cxDqbBa6n4CnO/ZcohmQLiozhT4x o8uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=69FOfqrKSfJXVsmpLPRa+VbxKeUp18dMsmGgJ+9m/dM=; b=jzfqajk2TpbwTJJSNnbz8NvJPA+ZSfyTLe4TLysSYVvVd/2OSSvXHdN4wafFqDJTj4 xqA+rdhaDxdJrorTDNxf2F88Miwm8gQ18AdSIWyjRoJB+eP4hvFHsCSTPpUgerQpyLLb HJ1LZfsermexu0qKdsjAFK4lmjUFdSCalZX45mzAk3w81Uur3Q3mK9NvkaTxynXou1jI xbAcT/lkl5RjqzSYJwW7p2T8aJRi/XxuhVDQb58E1zxHKpuIxlvDTaEZpn3314f78ZCq 7pUYeOF5XfeFZLHJ1z8EFS4sCjqoqaxYnhzSkP3HvND7ZJHPyMdtFzkoEGmu0HzvyBjq cqEA== X-Gm-Message-State: ALyK8tLzVeC2p1hLrGBQd2fIs375MWnlK+O11Kp9JSSjcPvIBDg8PGfLkFG1/gdMZyRMpQ== X-Received: by 10.55.33.153 with SMTP id f25mr12773111qki.156.1465519626535; Thu, 09 Jun 2016 17:47:06 -0700 (PDT) Received: from localhost.localdomain ([191.191.107.245]) by smtp.googlemail.com with ESMTPSA id y205sm1419860qhc.5.2016.06.09.17.47.02 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 09 Jun 2016 17:47:06 -0700 (PDT) From: Bruno Herrera To: kvalo@codeaurora.org Cc: poggi.raph@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq Date: Thu, 9 Jun 2016 21:46:46 -0300 Message-Id: <1465519606-68129-1-git-send-email-bruherrera@gmail.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pdev_data pointer is being freed with kfree but the pointer is not dynamic allocated. Signed-off-by: Bruno Herrera --- drivers/net/wireless/ti/wlcore/sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c index c172da5..5839acb 100644 --- a/drivers/net/wireless/ti/wlcore/sdio.c +++ b/drivers/net/wireless/ti/wlcore/sdio.c @@ -241,7 +241,6 @@ static int wlcore_probe_of(struct device *dev, int *irq, *irq = irq_of_parse_and_map(np, 0); if (!*irq) { dev_err(dev, "No irq in platform data\n"); - kfree(pdev_data); return -EINVAL; }