From patchwork Tue Jul 5 12:20:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 9214153 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5279A60572 for ; Tue, 5 Jul 2016 12:21:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 384D128A20 for ; Tue, 5 Jul 2016 12:21:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2960A28A54; Tue, 5 Jul 2016 12:21:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BFA328A20 for ; Tue, 5 Jul 2016 12:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755027AbcGEMVI (ORCPT ); Tue, 5 Jul 2016 08:21:08 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:52081 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbcGEMVE convert rfc822-to-8bit (ORCPT ); Tue, 5 Jul 2016 08:21:04 -0400 Received: from dc8secmta1.synopsys.com (dc8secmta1.synopsys.com [10.13.218.200]) by smtprelay.synopsys.com (Postfix) with ESMTP id 452FA10C16DD; Tue, 5 Jul 2016 05:20:12 -0700 (PDT) Received: from dc8secmta1.internal.synopsys.com (dc8secmta1.internal.synopsys.com [127.0.0.1]) by dc8secmta1.internal.synopsys.com (Service) with ESMTP id 382F627113; Tue, 5 Jul 2016 05:20:12 -0700 (PDT) Received: from mailhost.synopsys.com (unknown [10.13.184.66]) by dc8secmta1.internal.synopsys.com (Service) with ESMTP id EF0E327102; Tue, 5 Jul 2016 05:20:11 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id D6792232; Tue, 5 Jul 2016 05:20:11 -0700 (PDT) Received: from us01wehtc1.internal.synopsys.com (us01wehtc1.internal.synopsys.com [10.12.239.235]) by mailhost.synopsys.com (Postfix) with ESMTP id 47342224; Tue, 5 Jul 2016 05:20:10 -0700 (PDT) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by us01wehtc1.internal.synopsys.com (10.12.239.235) with Microsoft SMTP Server (TLS) id 14.3.266.1; Tue, 5 Jul 2016 05:20:10 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCB.internal.synopsys.com ([::1]) with mapi id 14.03.0266.001; Tue, 5 Jul 2016 14:20:08 +0200 From: Alexey Brodkin To: "linux-usb@vger.kernel.org" CC: "linux-wireless@vger.kernel.org" , "linux@rempel-privat.de" , "anders.darander@gmail.com" , "stern@rowland.harward.edu" , "ath9k-devel@lists.ath9k.org" , "linux-snps-arc@lists.infradead.org" Subject: ath9k-htc on OHCI -> bogus usb xfer Thread-Topic: ath9k-htc on OHCI -> bogus usb xfer Thread-Index: AQHR1reR6z1OW9veX0WAGwD25ZKg0g== Date: Tue, 5 Jul 2016 12:20:08 +0000 Message-ID: <1467721137.3144.81.camel@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.129] Content-ID: MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, Looks like this is another manifestation of already seen problem with ath9k-htc and OHCI controller. I'm trying to get USB Wi-Fi dongle based on Atheros AR9271 to work with our development board (this is Synopsys AXS103) and seeing a picture very similar to what was discussed here http://thread.gmane.org/gmane.linux.usb.general/110847 Below is what I see on insertion of the dongle. Note I have the most recent ath9k-htc firmware (see "ath9k_htc/htc_9271-1.4.0.fw" in the log below) and Linux kernel is 4.6.3 (latest stable as of today) but the same happens even on 4.4. Interesting enough if I simply remove or disable the warning like that ------------------------>8--------------------------- ------------------------>8--------------------------- everything seem to work quite nice. Any thoughts are much appreciated. That's the log itself: ------------------------>8--------------------------- usb 1-1: new full-speed USB device number 2 using ohci-platform usb 1-1: ath9k_htc: Firmware ath9k_htc/htc_9271-1.4.0.fw requested usb 1-1: ath9k_htc: Transferred FW: ath9k_htc/htc_9271-1.4.0.fw, size: 51008 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 4 at drivers/usb/core/urb.c:450 usb_submit_urb+0x162/0x404 usb 1-1: BOGUS urb xfer, pipe 1 != type 3 Modules linked in: CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 4.6.3 #10 Workqueue: events request_firmware_work_func Stack Trace:   arc_unwind_core.constprop.1+0x94/0x10c ---[ end trace 2249b79eac9991d1 ]--- ------------[ cut here ]------------ WARNING: CPU: 0 PID: 4 at drivers/usb/core/urb.c:450 usb_submit_urb+0x162/0x404 usb 1-1: BOGUS urb xfer, pipe 1 != type 3 Modules linked in: CPU: 0 PID: 4 Comm: kworker/0:0 Tainted: G        W       4.6.3 #10 Workqueue: events request_firmware_work_func Stack Trace:   arc_unwind_core.constprop.1+0x94/0x10c ---[ end trace 2249b79eac9991d2 ]--- ------------[ cut here ]------------ WARNING: CPU: 0 PID: 4 at drivers/usb/core/urb.c:450 usb_submit_urb+0x162/0x404 usb 1-1: BOGUS urb xfer, pipe 1 != type 3 Modules linked in: CPU: 0 PID: 4 Comm: kworker/0:0 Tainted: G        W       4.6.3 #10 Workqueue: events request_firmware_work_func Stack Trace:   arc_unwind_core.constprop.1+0x94/0x10c ---[ end trace 2249b79eac9991d3 ]--- ... ------------------------>8--------------------------- -Alexey-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index 3d27477..a317e1e 100644 --- a/drivers/usb/core/urb.c +++ b/drivers/usb/core/urb.c @@ -443,11 +443,6 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)          * cause problems in HCDs if they get it wrong.          */   -       /* Check that the pipe's type matches the endpoint's type */ -       if (usb_pipetype(urb->pipe) != pipetypes[xfertype]) -               dev_WARN(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n", -                       usb_pipetype(urb->pipe), pipetypes[xfertype]); -         /* Check against a simple/standard policy */         allowed = (URB_NO_TRANSFER_DMA_MAP | URB_NO_INTERRUPT | URB_DIR_MASK |                         URB_FREE_BUFFER);