From patchwork Fri Jul 15 11:49:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashok Raj Nagarajan X-Patchwork-Id: 9231793 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 648066075D for ; Fri, 15 Jul 2016 11:49:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 540B727BF9 for ; Fri, 15 Jul 2016 11:49:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 488882819A; Fri, 15 Jul 2016 11:49:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7DF827BF9 for ; Fri, 15 Jul 2016 11:49:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932732AbcGOLtf (ORCPT ); Fri, 15 Jul 2016 07:49:35 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:18482 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932642AbcGOLte convert rfc822-to-8bit (ORCPT ); Fri, 15 Jul 2016 07:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1468583374; x=1500119374; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jzdLGKogy6TcD9g+n62kG6yqKMMvZpYLr3144NOdoh0=; b=JkjABYKuI/HJ3vd8Utb59nQnxarkCexOoJchRhvPmQe6KQjhRie5gmo0 ylhCgpV/UgZsm78D4ldl8s3XzJWZBBTfcJsw5wlwy7eqzNks2lE7hyq7v xcDHA8cE5TxviLTfsI5PUsMJh9yk1aGcAobygAsuidaIbezDqjIxNNCui s=; X-IronPort-AV: E=Sophos;i="5.28,368,1464678000"; d="scan'208";a="303910965" Received: from unknown (HELO Ironmsg03-L.qualcomm.com) ([10.53.140.110]) by wolverine02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Jul 2016 04:49:17 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8226"; a="1186760551" Received: from nasanexm02b.na.qualcomm.com ([10.85.0.42]) by Ironmsg03-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 15 Jul 2016 04:49:16 -0700 Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by nasanexm02b.na.qualcomm.com (10.85.0.42) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 15 Jul 2016 04:49:15 -0700 Received: from aphydexm01f.ap.qualcomm.com (10.252.127.15) by aphydexm01b.ap.qualcomm.com (10.252.127.11) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 15 Jul 2016 17:19:10 +0530 Received: from aphydexm01f.ap.qualcomm.com ([10.252.127.15]) by aphydexm01f.ap.qualcomm.com ([10.252.127.15]) with mapi id 15.00.1178.000; Fri, 15 Jul 2016 17:19:10 +0530 From: "Nagarajan, Ashok Raj" To: Ben Greear , "nbd@nbd.name" , Kalle Valo CC: linux-wireless , "michal.kazior@tieto.com" , "ath10k@lists.infradead.org" , "A. Benz" Subject: Re: ath10k/QCA9980 - Issues introduced in wireless testing 2016-05 Thread-Topic: ath10k/QCA9980 - Issues introduced in wireless testing 2016-05 Thread-Index: AQHRwiMzjkILWh6W7kipr4yIS/luxJ/iCd2AgAABXgCAAJaDjP//q82AgAABQoCAAAVEAIA3PwKT Date: Fri, 15 Jul 2016 11:49:09 +0000 Message-ID: <1468583339047.52453@qti.qualcomm.com> References: <877fdxfd2l.fsf@kamboji.qca.qualcomm.com> <575AB829.10101@candelatech.com> , <575ABDA2.9020609@candelatech.com> In-Reply-To: <575ABDA2.9020609@candelatech.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > On 06/10/2016 05:57 AM, Felix Fietkau wrote: >>> On 2016-06-10 14:52, Ben Greear wrote: >>> This looks a lot like the problems I was having. >>> >>> Two of these 5 patches recently made it upstream (but may not be in LEDE yet), >>> but the other patches also were related to memory corruption. >>> >>> See my patches posted on 4/1/16: >>> >>> https://patchwork.kernel.org/project/ath10k/list/ >>> >>> I don't know where the 5/5 patch ended up. >> I had already asked affected users to test with those patches (I have a >> commit that adds them in my staging tree), but it did not resolve the issue. > >Ok, must be something else then. > >If you can run on x86 under KASAN it may provide some clues..that is how I eventually >made progress on the issues I was seeing. My rebase onto 3.7 has been slow and painful, >but I should be ready to start testing that sometime soon, maybe I can reproduce something >there. Hi Benz, Could you please check with the following diff if it is solving your issue? >Thanks, >Ben --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 6f19fca..c192a41 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -1528,7 +1528,7 @@ static void ath10k_htt_rx_h_filter(struct ath10k *ar, static int ath10k_htt_rx_handle_amsdu(struct ath10k_htt *htt) { struct ath10k *ar = htt->ar; - static struct ieee80211_rx_status rx_status; + struct ieee80211_rx_status *rx_status = &htt->rx_status; struct sk_buff_head amsdu; int ret; @@ -1553,11 +1553,11 @@ static int ath10k_htt_rx_handle_amsdu(struct ath10k_htt *htt) } ath10k_pktlog_rx(ar, &amsdu); - ath10k_htt_rx_h_ppdu(ar, &amsdu, &rx_status, 0xffff); + ath10k_htt_rx_h_ppdu(ar, &amsdu, rx_status, 0xffff); ath10k_htt_rx_h_unchain(ar, &amsdu, ret > 0); - ath10k_htt_rx_h_filter(ar, &amsdu, &rx_status); - ath10k_htt_rx_h_mpdu(ar, &amsdu, &rx_status); - ath10k_htt_rx_h_deliver(ar, &amsdu, &rx_status); + ath10k_htt_rx_h_filter(ar, &amsdu, rx_status); + ath10k_htt_rx_h_mpdu(ar, &amsdu, rx_status); + ath10k_htt_rx_h_deliver(ar, &amsdu, rx_status); Thanks, Ashok