From patchwork Sat Aug 27 16:14:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 9302457 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EEDBA6077C for ; Sat, 27 Aug 2016 16:15:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2EEE289CA for ; Sat, 27 Aug 2016 16:15:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D619A289D2; Sat, 27 Aug 2016 16:15:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HK_RANDOM_FROM,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1571289CA for ; Sat, 27 Aug 2016 16:15:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570AbcH0QPM (ORCPT ); Sat, 27 Aug 2016 12:15:12 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33651 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753872AbcH0QPK (ORCPT ); Sat, 27 Aug 2016 12:15:10 -0400 Received: by mail-pf0-f174.google.com with SMTP id y134so37965226pfg.0 for ; Sat, 27 Aug 2016 09:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=FJ20+mlfSjRnyrayWK396jKbOInrM241wC18u/71PeM=; b=LO+nzu7/Td/GK9Qd+8eyiWrI47wO2592l/2F1rsYdsRMGLoK0dB0062qnbiQr80CPP rhzvrlmiTDD60qHGdfNcIcG/wyGG3+bes3jBsPJ5kvx3J3CkYGipfNQ7Tsj289jyNO1T h3Wd/wKbBzKePgwwdoeHOaWIeIlZAX+QWbUF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FJ20+mlfSjRnyrayWK396jKbOInrM241wC18u/71PeM=; b=MZ0/bd2sS1D6/5ZTBezotFg/ofNoRYlb7UQzpXxbKUWRD41dyirj8tbLtVIUZWns4i H/HCoXs/QrWzsyShOrApWprYto5PDTjZ0O+4JF+KX47WagGyO6nRu7d4yjspjkg6MB8p 2pKlWplGS+W25bx8++lRKu4/thRVtGVnb5lcJDHabbMeQZhwHhO/Mx7Pv4VcyJhM4Ra5 OJI+tJyYodF992W0q+kH3TnF56YjU2muR2x07bQzM6axc7U2ne7GUZbWq9soKAgIStHk ei/1e8xlr5dTZQFCyy4yFB0ZSi8zbSf5Dp+imdq4hHBshyumrx0KuaEj7PpWA1yWF9SN MzVA== X-Gm-Message-State: AE9vXwM1CiGFMikwVf8GuL2SytSp8cBxdn3SlKR6T7isrWfqP8egkILxbdhGfBu2G4WtjF48 X-Received: by 10.98.66.209 with SMTP id h78mr16588621pfd.11.1472314510147; Sat, 27 Aug 2016 09:15:10 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.142]) by smtp.gmail.com with ESMTPSA id g24sm37195418pfk.56.2016.08.27.09.15.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Aug 2016 09:15:09 -0700 (PDT) From: Baoyou Xie To: Jes.Sorensen@redhat.com, kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] fix:rtl8xxxu_core: mark symbols static where possible Date: Sun, 28 Aug 2016 00:14:36 +0800 Message-Id: <1472314476-23351-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We get 1 warning about global functions without a declaration in the rtl8xxxu rtl8xxxu_core.c when building with W=1: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks it 'static'. Signed-off-by: Baoyou Xie --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 77048db..95b54b8 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -894,7 +894,7 @@ int rtl8xxxu_write_rfreg(struct rtl8xxxu_priv *priv, return retval; } -int +static int rtl8xxxu_gen1_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c, int len) { struct device *dev = &priv->udev->dev;