From patchwork Tue Aug 30 14:11:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: engineering@keppy.com X-Patchwork-Id: 9305473 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 666D060756 for ; Tue, 30 Aug 2016 14:08:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5749C28B2B for ; Tue, 30 Aug 2016 14:08:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4BE1528B3E; Tue, 30 Aug 2016 14:08:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A2DD28B2B for ; Tue, 30 Aug 2016 14:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750881AbcH3OIb (ORCPT ); Tue, 30 Aug 2016 10:08:31 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:35442 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbcH3OIU (ORCPT ); Tue, 30 Aug 2016 10:08:20 -0400 Received: by mail-it0-f68.google.com with SMTP id f128so2123817ith.2 for ; Tue, 30 Aug 2016 07:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=keppy-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=ZuLcIqHv8hcY1hRM7iUsJzmLUnI81Cmh1yEVx18rQPk=; b=tePxztM3+XvkpO87ENDrHhaBj0xywRBNQiWww71YE+PCmMo5eprQVIuGuad1yPj7CK j4VbcUh4SIpThmWdxs0UNWNbkWAIUn9LMRy5ON+/u70kZcgzhIuTTpKWImQvouaHvxeA +63dXwdsHku0kZ6XVscE0V3YJhB92s0jfD8LWtL4wxY2IP1eFCpneGIuY35opPnBplsh WOEaoDhpG2r9wOr+/a426/F+nbNMYb7UJTKP1yiWOMf3sYsn3Cf6MdyvgJDOwBW9no/E 7RbOj5uhIakE9SDjuDN0sFwIl4cGaOws51WOr5eV/bj9xXr129QPpONs86SyW397GZ2m v/OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZuLcIqHv8hcY1hRM7iUsJzmLUnI81Cmh1yEVx18rQPk=; b=LaKC7wK8V86ywI2qnXPeT6qW9YdB934CAVNysLlJnD+BCc0qx5LHhcOjsaYxbEwzXO B8ptDMquARmQhJxko58b6dtax82YEbfIcgLKqWXH0bYY3WYwAZ96/RnTOXAXDH7WHAK/ iIGm8S6ensst6clrhNhB1EqRr9ipB0NVUjHdqgpjGahuHioay4kbTlPCmEcUZCoR45zi 0xUq0Bq6sd3HpVtBAMdihj7vIWfYfIjkwAWe0g9e+5cIz02S/dBjn/cspLYIml1uYe/K f84hBWC2Xt1iVMvTsqJmhHXhQXx2yAFdRtJryQOX4cSw2ta8NUZUXhxXvqe4X3ZcN2iY BL+A== X-Gm-Message-State: AE9vXwNzD5vwFNImfpSOwq3zVlk087VVJU9ZGnCv7Mu8SvFuHJw1DrWaqbYE+zsUFhS4DA== X-Received: by 10.36.17.140 with SMTP id 134mr23162341itf.70.1472566099578; Tue, 30 Aug 2016 07:08:19 -0700 (PDT) Received: from danke-desktop.test.summit.com ([12.219.245.219]) by smtp.gmail.com with ESMTPSA id 74sm10142637itu.18.2016.08.30.07.08.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Aug 2016 07:08:19 -0700 (PDT) From: engineering@keppy.com X-Google-Original-From: dan.kephart@lairdtech.com To: kvalo@qca.qualcomm.com Cc: ath6kl@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH] ath6kl: enable firmware crash dumps on the AR6004 Date: Tue, 30 Aug 2016 10:11:43 -0400 Message-Id: <1472566303-32613-1-git-send-email-dan.kephart@lairdtech.com> X-Mailer: git-send-email 2.4.10 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dan Kephart The firmware crash dumps on the 6004 are the same as the 6003. Remove the statement guarding it from dumping on the 6004. Renamed the REG_DUMP_COUNT_AR6003 to reflect support on both chips. Signed-off-by: Dan Kephart --- drivers/net/wireless/ath/ath6kl/hif.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c index 18c0708..d194253 100644 --- a/drivers/net/wireless/ath/ath6kl/hif.c +++ b/drivers/net/wireless/ath/ath6kl/hif.c @@ -64,7 +64,7 @@ int ath6kl_hif_rw_comp_handler(void *context, int status) } EXPORT_SYMBOL(ath6kl_hif_rw_comp_handler); -#define REG_DUMP_COUNT_AR6003 60 +#define REGISTER_DUMP_COUNT 60 #define REGISTER_DUMP_LEN_MAX 60 static void ath6kl_hif_dump_fw_crash(struct ath6kl *ar) @@ -73,9 +73,6 @@ static void ath6kl_hif_dump_fw_crash(struct ath6kl *ar) u32 i, address, regdump_addr = 0; int ret; - if (ar->target_type != TARGET_TYPE_AR6003) - return; - /* the reg dump pointer is copied to the host interest area */ address = ath6kl_get_hi_item_addr(ar, HI_ITEM(hi_failure_state)); address = TARG_VTOP(ar->target_type, address); @@ -95,7 +92,7 @@ static void ath6kl_hif_dump_fw_crash(struct ath6kl *ar) /* fetch register dump data */ ret = ath6kl_diag_read(ar, regdump_addr, (u8 *)®dump_val[0], - REG_DUMP_COUNT_AR6003 * (sizeof(u32))); + REGISTER_DUMP_COUNT * (sizeof(u32))); if (ret) { ath6kl_warn("failed to get register dump: %d\n", ret); return; @@ -105,9 +102,9 @@ static void ath6kl_hif_dump_fw_crash(struct ath6kl *ar) ath6kl_info("hw 0x%x fw %s\n", ar->wiphy->hw_version, ar->wiphy->fw_version); - BUILD_BUG_ON(REG_DUMP_COUNT_AR6003 % 4); + BUILD_BUG_ON(REGISTER_DUMP_COUNT % 4); - for (i = 0; i < REG_DUMP_COUNT_AR6003; i += 4) { + for (i = 0; i < REGISTER_DUMP_COUNT; i += 4) { ath6kl_info("%d: 0x%8.8x 0x%8.8x 0x%8.8x 0x%8.8x\n", i, le32_to_cpu(regdump_val[i]),