From patchwork Wed Sep 21 08:39:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prameela Rani Garnepudi X-Patchwork-Id: 9343053 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 54DF3607D4 for ; Wed, 21 Sep 2016 08:42:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4542C2A33E for ; Wed, 21 Sep 2016 08:42:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A07A2A342; Wed, 21 Sep 2016 08:42:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BD552A33E for ; Wed, 21 Sep 2016 08:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbcIUIm0 (ORCPT ); Wed, 21 Sep 2016 04:42:26 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34748 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbcIUImY (ORCPT ); Wed, 21 Sep 2016 04:42:24 -0400 Received: by mail-pf0-f195.google.com with SMTP id 21so2107534pfy.1 for ; Wed, 21 Sep 2016 01:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=87oDFV5jlj3CV3eg0zx4EsdypDMd7tJyNQdMPgRJBJg=; b=T3Q5LuHcA+7HBo4pjbRSfiUShrfgiZZekqw0FIX1Hq3CyhJRiGc0D4KiNjprXxcVyb WC0lS4X9bzz3cW+18r3Pvo3Y9jSQHSlBNjmKVePJ85Yc/clh6PEZfkjoITBd8EXdGpFW lthem3NqPN/yq6s45YdxTHb0yqRl0by5tEPKdPdKz9/cl3mthJdxKPXoOehMwU5vWLcV b4qFmMuNi81s43Hf9Yee3p+0a+usWWJg1mSwF9zw8dNCES7EasC/Wzq++5/cIEIQ4vMx JOtAVGuM5budUpifW/PpkcHikxdzWSqYpKTjxq+F9M5NehDkmDt1P95oVeUsbjStP6in jdRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=87oDFV5jlj3CV3eg0zx4EsdypDMd7tJyNQdMPgRJBJg=; b=WFHXuNLL/8F4uoLmhkWb0lvIy50W23jzhBRp8Qu4PXvugA5pvaFhk7Np6lRq4AX3da BRvdcfZ+1Fxfc8lMjTP/KpW4e6FKExDW6UNWecX479srFTeAmcNZPRcFHJoSvTB0NiTa jZbg9iRo7+7Xm7lT1s5asHuNo8EgEJy03fFIsdUBUEfjNlhVu4axJvZB0NpSfWzrDE6u jjrfrv1Z/qN/pnqsM7AKHueVA74Z0P8o5Uhm1qkOnsS4eD0r+GS5YQ7CRdzABGGX4Obc GfYWB84928C+4SzLxQVb+5/eQKzs/3FMNF6T/xgEhANAdbGXQ/oPMqd2+idZF4Q0fvl6 zmMQ== X-Gm-Message-State: AE9vXwP+C7c2Wo3lG1vhW5HWiGppKSLmi6RomfjMJH2cZH/6i+YTanzffoT1JpTe66P0EA== X-Received: by 10.98.101.1 with SMTP id z1mr63199075pfb.53.1474447343540; Wed, 21 Sep 2016 01:42:23 -0700 (PDT) Received: from lapt225.localdomain ([203.196.161.90]) by smtp.gmail.com with ESMTPSA id ps2sm44654929pab.10.2016.09.21.01.42.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 01:42:23 -0700 (PDT) From: Prameela Rani Garnepudi To: linux-wireless@vger.kernel.org Cc: kvalo@codeaurora.org, johannes.berg@intel.com, hofrat@osadl.org, xypron.glpk@gmx.de, prameela.garnepudi@redpinesignals.com, Prameela Rani Garnepudi Subject: [PATCH] rsi: fix memory leak in module unload Date: Wed, 21 Sep 2016 14:09:22 +0530 Message-Id: <1474447162-19956-1-git-send-email-prameela.j04cs@gmail.com> X-Mailer: git-send-email 2.4.11 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP debugfs entry removal statement moved inside CONFIG_RSI_DEBUGSFS flag added freeing of below structures * channel list for each supported band * rsi debugfs info Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c index dbb2389..f4bbf15 100644 --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c @@ -194,6 +194,7 @@ static void rsi_register_rates_channels(struct rsi_hw *adapter, int band) void rsi_mac80211_detach(struct rsi_hw *adapter) { struct ieee80211_hw *hw = adapter->hw; + enum nl80211_band band; if (hw) { ieee80211_stop_queues(hw); @@ -201,7 +202,17 @@ void rsi_mac80211_detach(struct rsi_hw *adapter) ieee80211_free_hw(hw); } + for (band = 0; band < 2; band++) { + struct ieee80211_supported_band *sband = + &adapter->sbands[band]; + + kfree(sband->channels); + } + +#ifdef CONFIG_RSI_DEBUGFS rsi_remove_dbgfs(adapter); + kfree(adapter->dfsentry); +#endif } EXPORT_SYMBOL_GPL(rsi_mac80211_detach);