From patchwork Mon Oct 31 13:40:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: michael-dev X-Patchwork-Id: 9405475 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3811460234 for ; Mon, 31 Oct 2016 13:41:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E83329269 for ; Mon, 31 Oct 2016 13:41:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F1B6292B8; Mon, 31 Oct 2016 13:41:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 680AE29269 for ; Mon, 31 Oct 2016 13:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943113AbcJaNlP (ORCPT ); Mon, 31 Oct 2016 09:41:15 -0400 Received: from mail.fem.tu-ilmenau.de ([141.24.220.54]:33970 "EHLO mail.fem.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943052AbcJaNlO (ORCPT ); Mon, 31 Oct 2016 09:41:14 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fem.tu-ilmenau.de (Postfix) with ESMTP id 3BE466771; Mon, 31 Oct 2016 14:41:11 +0100 (CET) X-Virus-Scanned: amavisd-new at fem.tu-ilmenau.de Received: from mail.fem.tu-ilmenau.de ([127.0.0.1]) by localhost (mail.fem.tu-ilmenau.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qmwWxSh1+JxF; Mon, 31 Oct 2016 14:41:10 +0100 (CET) Received: from mail-backup.fem.tu-ilmenau.de (mail-backup.net.fem.tu-ilmenau.de [10.42.40.22]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.fem.tu-ilmenau.de (Postfix) with ESMTPS; Mon, 31 Oct 2016 14:41:08 +0100 (CET) Received: from a234.fem.tu-ilmenau.de (ray-controller.net.fem.tu-ilmenau.de [10.42.51.234]) by mail-backup.fem.tu-ilmenau.de (Postfix) with ESMTP id 4DB425512E; Mon, 31 Oct 2016 14:41:07 +0100 (CET) Received: by a234.fem.tu-ilmenau.de (Postfix, from userid 1000) id 26EAC306ACA7; Mon, 31 Oct 2016 14:41:06 +0100 (CET) From: Michael Braun To: johannes@sipsolutions.net Cc: Michael Braun , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de Subject: [PATCH v7 1/2] nl80211: multicast_to_unicast can be changed while IFF_UP Date: Mon, 31 Oct 2016 14:40:59 +0100 Message-Id: <1477921260-24556-1-git-send-email-michael-dev@fami-braun.de> X-Mailer: git-send-email 2.1.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no need to prevent toggling multicast_to_unicast while interface is already up. This change simplifies reconfiguration from hostapd. Signed-off-by: Michael Braun --- net/wireless/nl80211.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 5349c63..7554400 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -11006,9 +11006,6 @@ static int nl80211_set_multicast_to_unicast(struct sk_buff *skb, const struct nlattr *nla; bool enabled; - if (netif_running(dev)) - return -EBUSY; - if (!rdev->ops->set_multicast_to_unicast) return -EOPNOTSUPP;