From patchwork Tue Feb 21 09:04:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Rokicki X-Patchwork-Id: 9584063 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BA630600C1 for ; Tue, 21 Feb 2017 09:04:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A75F2875D for ; Tue, 21 Feb 2017 09:04:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8DAE1288E2; Tue, 21 Feb 2017 09:04:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 203652875D for ; Tue, 21 Feb 2017 09:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751069AbdBUJEk (ORCPT ); Tue, 21 Feb 2017 04:04:40 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:34276 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdBUJEh (ORCPT ); Tue, 21 Feb 2017 04:04:37 -0500 Received: by mail-lf0-f50.google.com with SMTP id g134so17495007lfe.1 for ; Tue, 21 Feb 2017 01:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=xmQdIBY/tzAIw6bJcAusWyTt1JOm/2EA6yvX21XC/hQ=; b=1NZhuJtJ7XvHhE4UsQLxPwsH4UOluZZgjqOpGMV+GMQ7XFoBrbkFw4gpBgbiyf//15 Wp48x+xcCqlA5XPQfkqINxcwH3vlOc1UuBxhQbYO28YdAQmXJq8vCgE8IIxX7laIUIBj mNuzqE2tnp2u45loHvoSYeXOMERgXfEhMWhRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xmQdIBY/tzAIw6bJcAusWyTt1JOm/2EA6yvX21XC/hQ=; b=b1puiBVZxA60qbnEeEM0u0/POri/Bn4t2OqH3qnVlDUsmMATA7QrPL9KC5Kfv5tpNn iesa9BB+NV8Jd3qQcOG2fLh8BWYVrlktO633sC42BxwAC9DxCxIvOtKETINSb0Ggvha3 LRD0nP71Uar74I6f90k1szFJ6+vq6UdG5hzPKZ4LIVUJ9rLTEOS9QqpX8LxWO3fF+ycU QGLxuGRvqra86460bCAgCBB4LdaGmTCVt8L+fDJzlnfAcoQyfn0L/9zjv7iMl77Mga1Y bo97sjm5oMF2M4AUnwFZ3SoNm7nHgMS3RHZXU/g1RePm6npv+cw81JrSSjYGMwbdJNfK Bgtw== X-Gm-Message-State: AMke39nAZuWB6kSa7sA6wwJNrw01b2Z0PDXUZDyVwGOE21gREtUwD2FhOSSQGyIkRKl08/bXNWMgyAnB2Ksl5Gk206YVwxLzoZxI2IelSFHZtjfsC+tk+qnKuIhgi0mDiVtjsrgG+938zw== X-Received: by 10.46.88.7 with SMTP id m7mr6889499ljb.58.1487667875673; Tue, 21 Feb 2017 01:04:35 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by smtp.gmail.com with ESMTPSA id u126sm5998770lja.25.2017.02.21.01.04.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Feb 2017 01:04:35 -0800 (PST) From: Marcin Rokicki To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH] ath10k: Remove return statement from a void function Date: Tue, 21 Feb 2017 10:04:33 +0100 Message-Id: <1487667873-3493-1-git-send-email-marcin.rokicki@tieto.com> X-Mailer: git-send-email 2.7.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The empty 'return;' statement in a void function should be used to return from somewhere else then the end. Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 59729aa..d65850e 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -2268,7 +2268,7 @@ static void ath10k_core_register_work(struct work_struct *work) status = ath10k_core_probe_fw(ar); if (status) { ath10k_err(ar, "could not probe fw (%d)\n", status); - goto err; + return; } status = ath10k_mac_register(ar); @@ -2307,11 +2307,10 @@ static void ath10k_core_register_work(struct work_struct *work) ath10k_mac_unregister(ar); err_release_fw: ath10k_core_free_firmware_files(ar); -err: - /* TODO: It's probably a good idea to release device from the driver - * but calling device_release_driver() here will cause a deadlock. - */ - return; + +/* TODO: It's probably a good idea to release device from the driver + * but calling device_release_driver() here will cause a deadlock. + */ } int ath10k_core_register(struct ath10k *ar, u32 chip_id)