From patchwork Sun Apr 23 11:53:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pan Bian X-Patchwork-Id: 9694805 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58C3D60245 for ; Sun, 23 Apr 2017 11:55:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48E3726BE9 for ; Sun, 23 Apr 2017 11:55:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3661726E4E; Sun, 23 Apr 2017 11:55:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA92126BE9 for ; Sun, 23 Apr 2017 11:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1045025AbdDWLz0 (ORCPT ); Sun, 23 Apr 2017 07:55:26 -0400 Received: from m50-132.163.com ([123.125.50.132]:49669 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1044778AbdDWLzY (ORCPT ); Sun, 23 Apr 2017 07:55:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=CafU6aG2FF0fTISHkn CSXiDezY16XOGrdfgDNZREJFs=; b=UhkcYeAzGPuLWXoAp3j7xHTNakTeOwRlz6 xqJTGqUVbabTmH2o/ipGSxmL3OFmfLjOYkjzMnuu+P1Hvu2em+jq9r0DYJlNhvom wEeS88I9TQgfubUJJ1krO9GOL6QpGun+1hIYqPLLNonQLmEbXnc+vr9H1+gMa9kE bQmzhBRbg= Received: from localhost.localdomain (unknown [123.118.194.153]) by smtp2 (Coremail) with SMTP id DNGowABnEQXWlfxYjW8kAA--.830S3; Sun, 23 Apr 2017 19:54:04 +0800 (CST) From: Pan Bian To: Aditya Shankar , Ganesh Krishna , Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] staging: wilc1000: fix unchecked return value Date: Sun, 23 Apr 2017 19:53:58 +0800 Message-Id: <1492948438-17389-1-git-send-email-bianpan201602@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: DNGowABnEQXWlfxYjW8kAA--.830S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF43KFyfJryfJF1rtw4Dtwb_yoWDXrg_ur s3ZryxGryvkr15tw1YkFy7ArySqFs3Xr18Zws7t3sxGwnxArZ5CrZ5uFn3Xry7GFWxWrZF ya1F9F1F9ryYqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnYZX5UUUUU== X-Originating-IP: [123.118.194.153] X-CM-SenderInfo: held01tdqsiiqwqsqiywtou0bp/1tbiSAvC4FXliewCagABsd Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Pan Bian Function dev_alloc_skb() will return a NULL pointer if there is no enough memory. However, in function WILC_WFI_mon_xmit(), its return value is used without validation. This may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan Bian --- drivers/staging/wilc1000/linux_mon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index f328d75..c9782d4 100644 --- a/drivers/staging/wilc1000/linux_mon.c +++ b/drivers/staging/wilc1000/linux_mon.c @@ -197,6 +197,8 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb, if (skb->data[0] == 0xc0 && (!(memcmp(broadcast, &skb->data[4], 6)))) { skb2 = dev_alloc_skb(skb->len + sizeof(struct wilc_wfi_radiotap_cb_hdr)); + if (!skb2) + return -ENOMEM; memcpy(skb_put(skb2, skb->len), skb->data, skb->len);