From patchwork Tue May 9 13:30:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amitkumar Karwar X-Patchwork-Id: 9717915 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DFF4560236 for ; Tue, 9 May 2017 13:32:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDA132074F for ; Tue, 9 May 2017 13:32:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C268328401; Tue, 9 May 2017 13:32:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD9782074F for ; Tue, 9 May 2017 13:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbdEINcC (ORCPT ); Tue, 9 May 2017 09:32:02 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33315 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbdEINcA (ORCPT ); Tue, 9 May 2017 09:32:00 -0400 Received: by mail-pf0-f193.google.com with SMTP id a23so62467pfe.0 for ; Tue, 09 May 2017 06:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=15FQbfw3dBG8xi+Fx3cJH1EABGjm2x9ThX55GotWYLw=; b=n5V/LzGzi/6UkuhJ9w7y29f6865U8lQmVoSjnL5XRnNSA1p7BX0p4fjpxSfDM7pUpw SdqPql8T8P50tYFrm/RFv2NLAhA91kcG85CytC/TD80UjA84hhSem4NuWrm7Jsli7yHV jTSy0mz3LEpfmawxR4x3TC2fs1EVZlOfIAoMhZMqQUs4uIUgAp4YQ5hCV7vy5Ux4HJ0n tGdOprvb05NG1RJsWVVYGJ+rXgyh6O8ZiXD7j4uVilUfRjm8Lp9DvRe2XnHJAvGm8HjA CRc3fX64cMYP1E7yQofL0V+YoVBJshDXt4t2vJVG3PpNG4dZ7Jr/NnfWd+31rrjsxshI 99uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=15FQbfw3dBG8xi+Fx3cJH1EABGjm2x9ThX55GotWYLw=; b=QgupMxASIRLcwa+twajKMPCkZZt9QzXSMfhDqFgtT5eEbo5lduql117ER8ylOXjf7K OLaubNeXLR1lRFXXu4FnSlEtfF6V6L1yA5stzMMhllZsuefIOpMBlV1Z/ZPxbGntdUXw rJH4KFIl0opb4pAe+azI7NtkXUd3rbvHuodW0RhxECNSH+L5ILX6CIc+UynoNw35CQSG gU4XV5Bw+shzgRpWebyKWtCVp7tzPfsW0g1RPTu72SuhmcLKb5OCKP6oUWmda0G2owGz uBXM+ssr3iSOIGxGutsRQb4QuOJcPduoD7cjBe31+NyvleEqv0z3hJy3Q+ptlJXq2r63 HwNg== X-Gm-Message-State: AODbwcDj33DkpXw94yDdk0VMP2e+rZHH6V8/XrQXScs1GVJvrWrTGpip gfZGJI6F+Fu3rwH8AJM= X-Received: by 10.99.8.193 with SMTP id 184mr19534pgi.189.1494336715069; Tue, 09 May 2017 06:31:55 -0700 (PDT) Received: from cpu185.redpinesignals.com ([203.196.161.90]) by smtp.gmail.com with ESMTPSA id y6sm37728pgc.40.2017.05.09.06.31.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 May 2017 06:31:54 -0700 (PDT) From: Amitkumar Karwar X-Google-Original-From: Amitkumar Karwar To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Amitkumar Karwar , Prameela Rani Garnepudi , Amitkumar Karwar Subject: [v2 05/11] rsi: Remove unnecessary buffer allocation Date: Tue, 9 May 2017 19:00:08 +0530 Message-Id: <1494336614-2107-6-git-send-email-amit.karwar@redpinesignals.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1494336614-2107-1-git-send-email-amit.karwar@redpinesignals.com> References: <1494336614-2107-1-git-send-email-amit.karwar@redpinesignals.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Prameela Rani Garnepudi In functions usb read register and usb write register, dynamic allocation of 4 bytes is used. This is removed as it is unncessary for local variable and for such small data. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_usb.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c index 73b01a8..8eb7407 100644 --- a/drivers/net/wireless/rsi/rsi_91x_usb.c +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c @@ -157,12 +157,8 @@ static int rsi_usb_reg_read(struct usb_device *usbdev, u16 *value, u16 len) { - u8 *buf; - int status = -ENOMEM; - - buf = kmalloc(0x04, GFP_KERNEL); - if (!buf) - return status; + u8 buf[4]; + int status; status = usb_control_msg(usbdev, usb_rcvctrlpipe(usbdev, 0), @@ -179,7 +175,6 @@ static int rsi_usb_reg_read(struct usb_device *usbdev, "%s: Reg read failed with error code :%d\n", __func__, status); } - kfree(buf); return status; } @@ -199,12 +194,8 @@ static int rsi_usb_reg_write(struct usb_device *usbdev, u16 value, u16 len) { - u8 *usb_reg_buf; - int status = -ENOMEM; - - usb_reg_buf = kmalloc(0x04, GFP_KERNEL); - if (!usb_reg_buf) - return status; + u8 usb_reg_buf[4]; + int status; usb_reg_buf[0] = (value & 0x00ff); usb_reg_buf[1] = (value & 0xff00) >> 8; @@ -225,7 +216,6 @@ static int rsi_usb_reg_write(struct usb_device *usbdev, "%s: Reg write failed with error code :%d\n", __func__, status); } - kfree(usb_reg_buf); return status; }