| Message ID | 1496412785-8720-3-git-send-email-amit.karwar@redpinesignals.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Amitkumar Karwar <amitkarwar@gmail.com> writes: > Currently macros are used for FSM states. We will replace > it with enum so that new state can be added easily without > worrying about macro value. > > Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> From and Signed-off-by does not match (gmail.com vs redpinesignals.com). I suggest that you add a separate From line to the commit log containing redpinesignals.com, this way you can still submit patches via gmail.com. Also your name in patchwork is not capitalised (patchwork is idiotic and takes the name from patchwork user data and not from the patch): [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit karwar New [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New [3/6] rsi: Register interrupt handler before firmware load 2017-06-02 amit karwar New [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit karwar New [5/6] rsi: configure new boot parameters to device 2017-06-02 amit karwar New [6/6] rsi: add tx frame for common device configuration 2017-06-02 amit karwar New To fix that could you please register to patchwork and capitalise your name correctly? You have only one chance, patchwork doesn't allow users edit the name afterwards, so don't do any typos :)
On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Amitkumar Karwar <amitkarwar@gmail.com> writes: > >> Currently macros are used for FSM states. We will replace >> it with enum so that new state can be added easily without >> worrying about macro value. >> >> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> > > From and Signed-off-by does not match (gmail.com vs redpinesignals.com). > I suggest that you add a separate From line to the commit log containing > redpinesignals.com, this way you can still submit patches via gmail.com. Sure. I will follow this for my future patches. > > Also your name in patchwork is not capitalised (patchwork is idiotic and > takes the name from patchwork user data and not from the patch): > > [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit karwar New > [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New > [3/6] rsi: Register interrupt handler before firmware load 2017-06-02 amit karwar New > [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit karwar New > [5/6] rsi: configure new boot parameters to device 2017-06-02 amit karwar New > [6/6] rsi: add tx frame for common device configuration 2017-06-02 amit karwar New > > To fix that could you please register to patchwork and capitalise your > name correctly? You have only one chance, patchwork doesn't allow users > edit the name afterwards, so don't do any typos :) Thanks. I have registered with patchwork and corrected my name. Regards, Amitkumar Karwar
amit karwar <amitkarwar@gmail.com> writes: > On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >> Amitkumar Karwar <amitkarwar@gmail.com> writes: >> >>> Currently macros are used for FSM states. We will replace >>> it with enum so that new state can be added easily without >>> worrying about macro value. >>> >>> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> >> >> From and Signed-off-by does not match (gmail.com vs redpinesignals.com). >> I suggest that you add a separate From line to the commit log containing >> redpinesignals.com, this way you can still submit patches via gmail.com. > > Sure. I will follow this for my future patches. Actually please resend this series with matching From and S-o-b. I don't want to edit From headers myself. >> Also your name in patchwork is not capitalised (patchwork is idiotic and >> takes the name from patchwork user data and not from the patch): >> >> [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit >> karwar New >> [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New >> [3/6] rsi: Register interrupt handler before firmware load >> 2017-06-02 amit karwar New >> [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit >> karwar New >> [5/6] rsi: configure new boot parameters to device 2017-06-02 >> amit karwar New >> [6/6] rsi: add tx frame for common device configuration >> 2017-06-02 amit karwar New >> >> To fix that could you please register to patchwork and capitalise your >> name correctly? You have only one chance, patchwork doesn't allow users >> edit the name afterwards, so don't do any typos :) > > Thanks. I have registered with patchwork and corrected my name. What address did you use? Patchwork still shows your name all lower: https://patchwork.kernel.org/project/linux-wireless/list/?submitter=173645 I suspect you didn't register with gmail.com, but with some other address. I recommend that you link all your email addresses, including gmail.com, to the same patchwork account and hopefully that fixes it. You should be able to do that from the profile page in patchwork.
On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > amit karwar <amitkarwar@gmail.com> writes: > >> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>> Amitkumar Karwar <amitkarwar@gmail.com> writes: >>> >>>> Currently macros are used for FSM states. We will replace >>>> it with enum so that new state can be added easily without >>>> worrying about macro value. >>>> >>>> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> >>> >>> From and Signed-off-by does not match (gmail.com vs redpinesignals.com). >>> I suggest that you add a separate From line to the commit log containing >>> redpinesignals.com, this way you can still submit patches via gmail.com. >> >> Sure. I will follow this for my future patches. > > Actually please resend this series with matching From and S-o-b. I don't > want to edit From headers myself. Sure. I will do this. > >>> Also your name in patchwork is not capitalised (patchwork is idiotic and >>> takes the name from patchwork user data and not from the patch): >>> >>> [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit >>> karwar New >>> [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New >>> [3/6] rsi: Register interrupt handler before firmware load >>> 2017-06-02 amit karwar New >>> [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit >>> karwar New >>> [5/6] rsi: configure new boot parameters to device 2017-06-02 >>> amit karwar New >>> [6/6] rsi: add tx frame for common device configuration >>> 2017-06-02 amit karwar New >>> >>> To fix that could you please register to patchwork and capitalise your >>> name correctly? You have only one chance, patchwork doesn't allow users >>> edit the name afterwards, so don't do any typos :) >> >> Thanks. I have registered with patchwork and corrected my name. > > What address did you use? Patchwork still shows your name all lower: > > https://patchwork.kernel.org/project/linux-wireless/list/?submitter=173645 > > I suspect you didn't register with gmail.com, but with some other > address. I recommend that you link all your email addresses, including > gmail.com, to the same patchwork account and hopefully that fixes it. > You should be able to do that from the profile page in patchwork. I had registered with my gmail id. Also, other email id has also been linked to patchwork. But still patchwork took previous user name. I could not find a way to check my name in patchwork database after login. I have now corrected my display name in gmail's setting. Regards, Amitkumar
Amitkumar Karwar <amitkarwar@gmail.com> writes: > On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >> amit karwar <amitkarwar@gmail.com> writes: >> >>> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>> >>>> Also your name in patchwork is not capitalised (patchwork is idiotic and >>>> takes the name from patchwork user data and not from the patch): >>>> >>>> [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit >>>> karwar New >>>> [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New >>>> [3/6] rsi: Register interrupt handler before firmware load >>>> 2017-06-02 amit karwar New >>>> [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit >>>> karwar New >>>> [5/6] rsi: configure new boot parameters to device 2017-06-02 >>>> amit karwar New >>>> [6/6] rsi: add tx frame for common device configuration >>>> 2017-06-02 amit karwar New >>>> >>>> To fix that could you please register to patchwork and capitalise your >>>> name correctly? You have only one chance, patchwork doesn't allow users >>>> edit the name afterwards, so don't do any typos :) >>> >>> Thanks. I have registered with patchwork and corrected my name. >> >> What address did you use? Patchwork still shows your name all lower: >> >> https://patchwork.kernel.org/project/linux-wireless/list/?submitter=173645 >> >> I suspect you didn't register with gmail.com, but with some other >> address. I recommend that you link all your email addresses, including >> gmail.com, to the same patchwork account and hopefully that fixes it. >> You should be able to do that from the profile page in patchwork. > > I had registered with my gmail id. Also, other email id has also been > linked to patchwork. But still patchwork took previous user name. > I could not find a way to check my name in patchwork database after > login. I have now corrected my display name in gmail's setting. Good, thanks. This name format bug in patchwork is really annoying, I'm suffering from frequently. Let's see how your next submission goes and hopefully we can sort it out.
On Thu, Jun 15, 2017 at 8:14 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Amitkumar Karwar <amitkarwar@gmail.com> writes: > >> On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>> amit karwar <amitkarwar@gmail.com> writes: >>> >>>> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>>> >>>>> Also your name in patchwork is not capitalised (patchwork is idiotic and >>>>> takes the name from patchwork user data and not from the patch): >>>>> >>>>> [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit >>>>> karwar New >>>>> [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New >>>>> [3/6] rsi: Register interrupt handler before firmware load >>>>> 2017-06-02 amit karwar New >>>>> [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit >>>>> karwar New >>>>> [5/6] rsi: configure new boot parameters to device 2017-06-02 >>>>> amit karwar New >>>>> [6/6] rsi: add tx frame for common device configuration >>>>> 2017-06-02 amit karwar New >>>>> >>>>> To fix that could you please register to patchwork and capitalise your >>>>> name correctly? You have only one chance, patchwork doesn't allow users >>>>> edit the name afterwards, so don't do any typos :) >>>> >>>> Thanks. I have registered with patchwork and corrected my name. >>> >>> What address did you use? Patchwork still shows your name all lower: >>> >>> https://patchwork.kernel.org/project/linux-wireless/list/?submitter=173645 >>> >>> I suspect you didn't register with gmail.com, but with some other >>> address. I recommend that you link all your email addresses, including >>> gmail.com, to the same patchwork account and hopefully that fixes it. >>> You should be able to do that from the profile page in patchwork. >> >> I had registered with my gmail id. Also, other email id has also been >> linked to patchwork. But still patchwork took previous user name. >> I could not find a way to check my name in patchwork database after >> login. I have now corrected my display name in gmail's setting. > > Good, thanks. This name format bug in patchwork is really annoying, I'm > suffering from frequently. Let's see how your next submission goes and > hopefully we can sort it out. I just submitted a patch series. But patchwork is still showing older name. Regards, Amitkumar
Amitkumar Karwar <amitkarwar@gmail.com> writes: > On Thu, Jun 15, 2017 at 8:14 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >> Amitkumar Karwar <amitkarwar@gmail.com> writes: >> >>> On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>>> amit karwar <amitkarwar@gmail.com> writes: >>>> >>>>> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>>>> >>>>>> Also your name in patchwork is not capitalised (patchwork is idiotic and >>>>>> takes the name from patchwork user data and not from the patch): >>>>>> >>>>>> [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit >>>>>> karwar New >>>>>> [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New >>>>>> [3/6] rsi: Register interrupt handler before firmware load >>>>>> 2017-06-02 amit karwar New >>>>>> [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit >>>>>> karwar New >>>>>> [5/6] rsi: configure new boot parameters to device 2017-06-02 >>>>>> amit karwar New >>>>>> [6/6] rsi: add tx frame for common device configuration >>>>>> 2017-06-02 amit karwar New >>>>>> >>>>>> To fix that could you please register to patchwork and capitalise your >>>>>> name correctly? You have only one chance, patchwork doesn't allow users >>>>>> edit the name afterwards, so don't do any typos :) >>>>> >>>>> Thanks. I have registered with patchwork and corrected my name. >>>> >>>> What address did you use? Patchwork still shows your name all lower: >>>> >>>> https://patchwork.kernel.org/project/linux-wireless/list/?submitter=173645 >>>> >>>> I suspect you didn't register with gmail.com, but with some other >>>> address. I recommend that you link all your email addresses, including >>>> gmail.com, to the same patchwork account and hopefully that fixes it. >>>> You should be able to do that from the profile page in patchwork. >>> >>> I had registered with my gmail id. Also, other email id has also been >>> linked to patchwork. But still patchwork took previous user name. >>> I could not find a way to check my name in patchwork database after >>> login. I have now corrected my display name in gmail's setting. >> >> Good, thanks. This name format bug in patchwork is really annoying, I'm >> suffering from frequently. Let's see how your next submission goes and >> hopefully we can sort it out. > > I just submitted a patch series. But patchwork is still showing older name. I think the best is that you now report this to kernel.org admins: https://korg.wiki.kernel.org/userdoc/support Hopefully they can easily fix it directly in the database.
On Mon, Jun 19, 2017 at 8:49 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Amitkumar Karwar <amitkarwar@gmail.com> writes: > >> On Thu, Jun 15, 2017 at 8:14 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>> Amitkumar Karwar <amitkarwar@gmail.com> writes: >>> >>>> On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>>>> amit karwar <amitkarwar@gmail.com> writes: >>>>> >>>>>> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >>>>>> >>>>>>> Also your name in patchwork is not capitalised (patchwork is idiotic and >>>>>>> takes the name from patchwork user data and not from the patch): >>>>>>> >>>>>>> [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit >>>>>>> karwar New >>>>>>> [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New >>>>>>> [3/6] rsi: Register interrupt handler before firmware load >>>>>>> 2017-06-02 amit karwar New >>>>>>> [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit >>>>>>> karwar New >>>>>>> [5/6] rsi: configure new boot parameters to device 2017-06-02 >>>>>>> amit karwar New >>>>>>> [6/6] rsi: add tx frame for common device configuration >>>>>>> 2017-06-02 amit karwar New >>>>>>> >>>>>>> To fix that could you please register to patchwork and capitalise your >>>>>>> name correctly? You have only one chance, patchwork doesn't allow users >>>>>>> edit the name afterwards, so don't do any typos :) >>>>>> >>>>>> Thanks. I have registered with patchwork and corrected my name. >>>>> >>>>> What address did you use? Patchwork still shows your name all lower: >>>>> >>>>> https://patchwork.kernel.org/project/linux-wireless/list/?submitter=173645 >>>>> >>>>> I suspect you didn't register with gmail.com, but with some other >>>>> address. I recommend that you link all your email addresses, including >>>>> gmail.com, to the same patchwork account and hopefully that fixes it. >>>>> You should be able to do that from the profile page in patchwork. >>>> >>>> I had registered with my gmail id. Also, other email id has also been >>>> linked to patchwork. But still patchwork took previous user name. >>>> I could not find a way to check my name in patchwork database after >>>> login. I have now corrected my display name in gmail's setting. >>> >>> Good, thanks. This name format bug in patchwork is really annoying, I'm >>> suffering from frequently. Let's see how your next submission goes and >>> hopefully we can sort it out. >> >> I just submitted a patch series. But patchwork is still showing older name. > > I think the best is that you now report this to kernel.org admins: > > https://korg.wiki.kernel.org/userdoc/support > > Hopefully they can easily fix it directly in the database. > Thanks for the pointers. I have dropped an email to helpdesk for this issue.
diff --git a/drivers/net/wireless/rsi/rsi_main.h b/drivers/net/wireless/rsi/rsi_main.h index ea4fc22..833c66f5 100644 --- a/drivers/net/wireless/rsi/rsi_main.h +++ b/drivers/net/wireless/rsi/rsi_main.h @@ -31,13 +31,15 @@ #define FSM_ZONE BIT(7) /* For State Machine Msgs */ #define ISR_ZONE BIT(8) /* For Interrupt Msgs */ -#define FSM_CARD_NOT_READY 0 -#define FSM_BOOT_PARAMS_SENT 1 -#define FSM_EEPROM_READ_MAC_ADDR 2 -#define FSM_RESET_MAC_SENT 3 -#define FSM_RADIO_CAPS_SENT 4 -#define FSM_BB_RF_PROG_SENT 5 -#define FSM_MAC_INIT_DONE 6 +enum RSI_FSM_STATES { + FSM_CARD_NOT_READY, + FSM_BOOT_PARAMS_SENT, + FSM_EEPROM_READ_MAC_ADDR, + FSM_RESET_MAC_SENT, + FSM_RADIO_CAPS_SENT, + FSM_BB_RF_PROG_SENT, + FSM_MAC_INIT_DONE +}; extern u32 rsi_zone_enabled; extern __printf(2, 3) void rsi_dbg(u32 zone, const char *fmt, ...);
Currently macros are used for FSM states. We will replace it with enum so that new state can be added easily without worrying about macro value. Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> --- drivers/net/wireless/rsi/rsi_main.h | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)