From patchwork Wed Jun 14 11:06:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9786123 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1133C602C9 for ; Wed, 14 Jun 2017 11:07:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1014C285DA for ; Wed, 14 Jun 2017 11:07:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 04B10285E7; Wed, 14 Jun 2017 11:07:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B007E285DA for ; Wed, 14 Jun 2017 11:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbdFNLHW (ORCPT ); Wed, 14 Jun 2017 07:07:22 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33881 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbdFNLHU (ORCPT ); Wed, 14 Jun 2017 07:07:20 -0400 Received: by mail-pg0-f67.google.com with SMTP id v14so23249775pgn.1; Wed, 14 Jun 2017 04:07:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FO43tyzBq03aAqQbcftyehyBxehLmhkOxGvtEq1dE3I=; b=oVdZ92wTB99W+3dtDxMcTsLYzm3zETOW/CILLtqtqho3kd03jbHI/61wfP8QeZMBTD 3bcfxDa9c5O0B9aVg2rVout5kRVjltJ/7Hf90XaS/H7MLuEIT9CCwuZSHnmUk8jGVfkW wdnueUp75cQT67h756kjHb1OSCdKQKCPOSOu7q3aDIH2wfmliHttnE8/TLN7pbusmqkI FhTNEsshHuP6dmTJSxTcSGvGHPFMrlXAmhfWpJjfVSncDB/+xMLkZZ5C/CD3XYyMiiTf LP/umRPn2C5xmYQofUJrHSgOe7Xm+0Pa2KehJuMHc08zs7PO7MFFH3hRAxtcuTCX4j40 zWlw== X-Gm-Message-State: AKS2vOztDWPwhR4fIRTShEB7jNE8VTURdR1WIB7SPTit8/e2HwngZKz+ xOKVzBx74lldTy0l X-Received: by 10.84.218.206 with SMTP id g14mr47586plm.85.1497438440116; Wed, 14 Jun 2017 04:07:20 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id p23sm1848170pfk.67.2017.06.14.04.07.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Jun 2017 04:07:19 -0700 (PDT) From: Caesar Wang To: kvalo@codeaurora.org Cc: yangzy@marvell.com, jeffy.chen@rock-chips.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, Caesar Wang , Xinming Hu , Ganapathi Bhat , Amitkumar Karwar , linux-wireless@vger.kernel.org, Nishant Sarmukadam , netdev@vger.kernel.org Subject: [PATCH v2] mwifiex: fixes the unexpected be printed log by default Date: Wed, 14 Jun 2017 19:06:56 +0800 Message-Id: <1497438416-24665-1-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch uses WARN level is not printed by default. In some cases, some boards have always met the unused log be printed as follows. ... [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: cannot find cfp by band 2 & channel=13 freq=0 [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp: cannot find cfp by band 2 & channel=13 freq=0 Due to we used the wifi default area was US and didn't support 12~14 channels. As Frequencies: * 2412 MHz [1] (30.0 dBm) * 2417 MHz [2] (30.0 dBm) * 2422 MHz [3] (30.0 dBm) * 2427 MHz [4] (30.0 dBm) * 2432 MHz [5] (30.0 dBm) * 2437 MHz [6] (30.0 dBm) * 2442 MHz [7] (30.0 dBm) * 2447 MHz [8] (30.0 dBm) * 2452 MHz [9] (30.0 dBm) * 2457 MHz [10] (30.0 dBm) * 2462 MHz [11] (30.0 dBm) * 2467 MHz [12] (disabled) * 2472 MHz [13] (disabled) * 2484 MHz [14] (disabled) Also, as the commit 1b499cb72f26b ("mwifiex: disable channel filtering feature in firmware"), it proved to be a feature to get better scan result from overlapping channel. Even there could be AP from overlapping channel (might be 12/13/14 in this case), it will be filtered depend on reg domain rules. e.g: ... if (ch->flags & IEEE80211_CHAN_DISABLED) continue; So it should not been an ERROR, use the WARN level to instead it for now. Signed-off-by: Caesar Wang Acked-by: Xinming Hu --- Changes in v2: - Fixes the commit and title as Kalle and Xinming comments on https://patchwork.kernel.org/patch/9786047/ - Add the Acked by "HU Xinming" drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c index 1ff2205..6e29943 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfp.c +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq) } } if (i == sband->n_channels) { - mwifiex_dbg(priv->adapter, ERROR, + mwifiex_dbg(priv->adapter, WARN, "%s: cannot find cfp by band %d\t" "& channel=%d freq=%d\n", __func__, band, channel, freq);