From patchwork Thu Jul 6 22:00:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 9829083 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2E2B1602F0 for ; Thu, 6 Jul 2017 22:01:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20D03283DA for ; Thu, 6 Jul 2017 22:01:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1428E28504; Thu, 6 Jul 2017 22:01:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56E13283DA for ; Thu, 6 Jul 2017 22:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbdGFWAw (ORCPT ); Thu, 6 Jul 2017 18:00:52 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33787 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029AbdGFWAv (ORCPT ); Thu, 6 Jul 2017 18:00:51 -0400 Received: by mail-pg0-f65.google.com with SMTP id u62so1674355pgb.0; Thu, 06 Jul 2017 15:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0ink014hKI0BJM2VHnF5ZTJypwW3OntjB2aFr6oa5DQ=; b=pe5EtkN7p2CL9vOQUWwEOeW2PZvwHXTXe+d4uDi0p/lDBMW9TetDSRsWg0GMkFs/pe rQvBm+83XLmo8SEO8cx50FQ8u7otCxtX5AdoLNWQIouPqf7vOErr5Srxr6OKEVMQT8U4 Zhw5Y4hHFlGuxHxph1sOgXPHuWVXMjT5VB1E4kNyTlqFIuu6aiq9JHXNg2wSkvvjDZaz EtCV+W0wqgfsbvPIQCuYa/I0sqM5xtdtMhzBmRpTzyvUyL4RtUv54USvvXsT0ammfX4q FjqBCnsFAWESl5hemmxSuSPeMXs0pn6+h3rQFMtKrQN7RLhFiQ4A7LtDW6XDXvBhLVfM fRfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0ink014hKI0BJM2VHnF5ZTJypwW3OntjB2aFr6oa5DQ=; b=NUl4A6rcUmsfFH18NXrZHvYf9hQLZC1GQ9T8Ho7DrEVR3VkQ4pncqXi1q3cyG9uK4E dSFkoSYKiCrtz2sMvwYLzHdo74zN58kImLBAQaDo9gBVvtCnAL++wdd1Gaa+ylxglDJn nIi1yagDPJ6ToiVvcbBlcOUjMv3dSN+OktoPIivAZsZ2WTtsKTk/Gr2euCl/A1R4XqeU hsjS9gL+g0NO7uo77Jx5VrJvRe73D23j7qvcL5Rq06TZLQXsu/smNs2pyeoVWw6/qZlN abT6LCURbAYa4O+87mWUGLFNLlk66CSHYaiWTRv/BeS4o/DxuTIbzJka6lBTw9GrQvwI Zs3w== X-Gm-Message-State: AIVw1113QfIupCVTGeIgPFURzbbIe72y8R7cfFJcPMUb7TaReger+xPC veM3+DCJ9DvxpOmDklo= X-Received: by 10.98.236.137 with SMTP id e9mr27783633pfm.39.1499378450206; Thu, 06 Jul 2017 15:00:50 -0700 (PDT) Received: from tw-172-25-30-113.office.twttr.net ([8.25.197.25]) by smtp.gmail.com with ESMTPSA id y2sm1634589pgy.60.2017.07.06.15.00.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 15:00:49 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: pavel@ucw.cz, linux-wireless@vger.kernel.org, Cong Wang , Kalle Valo Subject: [Patch net] wl1251: add a missing spin_lock_init() Date: Thu, 6 Jul 2017 15:00:37 -0700 Message-Id: <1499378437-4971-1-git-send-email-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.5.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes the following kernel warning: [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 [ 5668.771850] lock: 0xce63ef20, .magic: 00000000, .owner: /-1, .owner_cpu: 0 [ 5668.772277] CPU: 0 PID: 9745 Comm: kworker/u2:3 Tainted: G W 4.12.0-03002-gec979a4-dirty #40 [ 5668.772796] Hardware name: Nokia RX-51 board [ 5668.773071] Workqueue: phy1 wl1251_irq_work [ 5668.773345] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 5668.773803] [] (show_stack) from [] (do_raw_spin_lock+0x6c/0xa0) [ 5668.774230] [] (do_raw_spin_lock) from [] (_raw_spin_lock_irqsave+0x10/0x18) [ 5668.774658] [] (_raw_spin_lock_irqsave) from [] (wl1251_op_tx+0x38/0x5c) [ 5668.775115] [] (wl1251_op_tx) from [] (ieee80211_tx_frags+0x188/0x1c0) [ 5668.775543] [] (ieee80211_tx_frags) from [] (__ieee80211_tx+0x6c/0x130) [ 5668.775970] [] (__ieee80211_tx) from [] (ieee80211_tx+0xdc/0x104) [ 5668.776367] [] (ieee80211_tx) from [] (__ieee80211_subif_start_xmit+0x454/0x8c8) [ 5668.776824] [] (__ieee80211_subif_start_xmit) from [] (ieee80211_subif_start_xmit+0x30/0x2fc) [ 5668.777343] [] (ieee80211_subif_start_xmit) from [] (dev_hard_start_xmit+0x80/0x118) ... by adding the missing spin_lock_init(). Reported-by: Pavel Machek Cc: Kalle Valo Signed-off-by: Cong Wang Acked-by: Pavel Machek --- drivers/net/wireless/ti/wl1251/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c index bbf7604..1c539c8 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -1571,6 +1571,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void) wl->state = WL1251_STATE_OFF; mutex_init(&wl->mutex); + spin_lock_init(&wl->wl_lock); wl->tx_mgmt_frm_rate = DEFAULT_HW_GEN_TX_RATE; wl->tx_mgmt_frm_mod = DEFAULT_HW_GEN_MODULATION_TYPE;