From patchwork Mon Jul 31 13:07:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xinming Hu X-Patchwork-Id: 9871819 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5F98660375 for ; Mon, 31 Jul 2017 13:07:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 433822844B for ; Mon, 31 Jul 2017 13:07:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34ED4285C4; Mon, 31 Jul 2017 13:07:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4DA42844B for ; Mon, 31 Jul 2017 13:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbdGaNHf (ORCPT ); Mon, 31 Jul 2017 09:07:35 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34179 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbdGaNHe (ORCPT ); Mon, 31 Jul 2017 09:07:34 -0400 Received: by mail-pf0-f195.google.com with SMTP id t86so4168372pfe.1 for ; Mon, 31 Jul 2017 06:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=50kMpbI1WNmv5TOKusUifFJyVjU3A46VVQDL5gC/I+A=; b=n7SrXnYPSa+P49QJW5m0326KEyPCZvpWfFH6/kmzXrwd1UOva52bXrKofjb9noGaXC /ku9R58Y0ytpVoya5eDAjFt89unZh347sde/IEHOSOxM5cQjLUPCSaoTQmL7KYx9gmE9 5fVQCpTrvfADXIUd4RxNXckWv0SYWPgfg9B4BwSt/i60JB3Og3ajZ1JfNWRi+F1kn3dk hsmqcG32W7vUgpex+4yEkYKbDZvx9GPiuaWc8z125fJuxs6qsQ12nFeEhAks8kFjueES SoeMhme9EmTOJJVIeGc1qjE6bsPa4QSzDwb6FVjLt+lY9pbj9bQwLYhK42ff3rS9HWIB plcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=50kMpbI1WNmv5TOKusUifFJyVjU3A46VVQDL5gC/I+A=; b=Hd/hBgwl8wQ4jjrlrtkvA5kmsfNaoo2KE/F5xvkPglYxHUGa4GvIzdshWRSmmJj8I5 SyZjGTLYvyrfgFTfEFsakEiGPyFfNFI4R/Y74RP9CUwlspTmkYea+dB2w6SDcmT13HYr TVk9Jnz/4ZNy+pQb9+bVluX2CmPKYt0i8eyyAraq2Hacnmuxd3sDndGIkkX3ZNtVBTiu UTpAblEiMxYAWNh1kv1LkckC4kChGRQWc4w2ZReipl3pnE8ui6yTttJmuBuGHOPJD3BF rfa4+FiKOEiSpo+fltysOCn9EA763b1alST+5TjDBW0IK8tSNtwB9ogzCspTPnse3ail uIJA== X-Gm-Message-State: AIVw110RJTrx7+wlBUJII0ELuIB9gQvGGNHFskWMZtXrGF2M3LyLEXIx iHtGO+zFnCabz0QJ X-Received: by 10.84.231.133 with SMTP id g5mr17609332plk.131.1501506453502; Mon, 31 Jul 2017 06:07:33 -0700 (PDT) Received: from ubuntu.members.linode.com ([2400:8902::f03c:91ff:fee7:7cf1]) by smtp.gmail.com with ESMTPSA id p27sm32546942pfl.23.2017.07.31.06.07.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 31 Jul 2017 06:07:32 -0700 (PDT) From: Xinming Hu To: Linux Wireless Cc: Kalle Valo , Brian Norris , Dmitry Torokhov , rajatja@google.com, Zhiyuan Yang , Tim Song , Cathy Luo , Ganapathi Bhat , Xinming Hu Subject: [PATCH 1/2] mwifiex: make addba request command clean Date: Mon, 31 Jul 2017 13:07:26 +0000 Message-Id: <1501506447-31851-1-git-send-email-huxinming820@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Xinming Hu uninitilized variable, such as .add_req_result might be magic stack value. Initialize the structure to make it clean. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo --- drivers/net/wireless/marvell/mwifiex/11n.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/11n.c b/drivers/net/wireless/marvell/mwifiex/11n.c index 16c77c2..7252069 100644 --- a/drivers/net/wireless/marvell/mwifiex/11n.c +++ b/drivers/net/wireless/marvell/mwifiex/11n.c @@ -572,6 +572,8 @@ int mwifiex_send_addba(struct mwifiex_private *priv, int tid, u8 *peer_mac) mwifiex_dbg(priv->adapter, CMD, "cmd: %s: tid %d\n", __func__, tid); + memset(&add_ba_req, 0, sizeof(add_ba_req)); + if ((GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) && ISSUPP_TDLS_ENABLED(priv->adapter->fw_cap_info) && priv->adapter->is_hw_11ac_capable &&