From patchwork Sat Aug 19 14:36:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 9910531 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B74E602C8 for ; Sat, 19 Aug 2017 14:46:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 63A5A28D5A for ; Sat, 19 Aug 2017 14:46:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 589B628D6F; Sat, 19 Aug 2017 14:46:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06D8228D65 for ; Sat, 19 Aug 2017 14:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbdHSOgc (ORCPT ); Sat, 19 Aug 2017 10:36:32 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34875 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbdHSOgb (ORCPT ); Sat, 19 Aug 2017 10:36:31 -0400 Received: by mail-lf0-f68.google.com with SMTP id h89so1118384lfi.2 for ; Sat, 19 Aug 2017 07:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=D5TnYK9EiTm2qgatLeWML8biRfl+6ree1uA9gqaymDU=; b=fQ+cNP4Ntl//NrFKogJTm9lpdvZ+whcs1KFMM2hEXHTgvDU8GaPHXvqNxzTYYHbV7e 7w3D9HSPdTwzoOAWveo8pl/5dWjRREwIjvbU7j8u5iX3T6yvKqZqilFqIczKiS16W+MI Sw8A83ThyAnJVxR2CL135XYSiASHpoW/Kn51rWAQN5AohmIAhMZyYLMHw8zTN64XTtJp MLW5RdVMzfXwUMhinSU/LVT9h3MFdNN6NafOFJp2vYYNsfG2N30YR9UXirkqiPfSQOQu P1jGpIakxL/l3AceoS4as99nArvcdkTcyYR4Ez5QLSsB6dOOaMiIh6gz+5omGHqlMIhv JWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=D5TnYK9EiTm2qgatLeWML8biRfl+6ree1uA9gqaymDU=; b=Csio94TLQw+J8xFqzNpJF5kiJmjgvC+TFAITIi7CqWpZkatCJICQwZem/UtZBli5I/ rwBgF67/id210hRASVOZWqtwlWvVF5CTWNz3HStbw0qwtXOx/QMNZB3HzRaj/nJPkTGX MR+475TncW7VYjHAsFYIFnEH8hmGbRwSaNYx18wDuFgaMf9zMrBH+2zGvJYT6KOndrbr TdjBG5/oV3L/jaZE1yb7/RC1WW+f7T89Qu7y40NXbER9Rb8uzzSPzy/7nHNRHeQ3qZeL ZVYQkUM3cEBT1fYTf7KGqdHgDEha8DdrsRSBI40IU8fR/xIm36Jg0YZyY01augw/+rz1 a9vQ== X-Gm-Message-State: AHYfb5h1NYNBU2p8ishtbJEE82lVlzPFNSSbvSP5UJIZ4TH5YbIy6hVm uu8CC9PF2BBsPw== X-Received: by 10.46.83.2 with SMTP id h2mr4348588ljb.22.1503153389794; Sat, 19 Aug 2017 07:36:29 -0700 (PDT) Received: from erik-mate-1604.lan (90-227-62-61-no75.tbcn.telia.com. [90.227.62.61]) by smtp.gmail.com with ESMTPSA id f194sm1748746lfe.70.2017.08.19.07.36.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 19 Aug 2017 07:36:28 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cc: Erik Stromdahl Subject: [PATCH] ath10k: sdio: remove unused struct member Date: Sat, 19 Aug 2017 16:36:22 +0200 Message-Id: <1503153382-11100-1-git-send-email-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP irq_wq in struct ath10k_sdio is a remnant from an earlier version of the sdio patchset. It's use was removed as a result of Kalle's review, but somehow the struct member survived. It is not used and can therefore safely be removed. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ---- drivers/net/wireless/ath/ath10k/sdio.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 48268f0..03a69e5 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func) sdio_claim_host(ar_sdio->func); - wake_up(&ar_sdio->irq_wq); - if (ret && ret != -ECANCELED) ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n", ret); @@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func, goto err_free_bmi_buf; } - init_waitqueue_head(&ar_sdio->irq_wq); - for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++) ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]); diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h index 3f61c67..4ff7b54 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.h +++ b/drivers/net/wireless/ath/ath10k/sdio.h @@ -210,8 +210,6 @@ struct ath10k_sdio { /* temporary buffer for BMI requests */ u8 *bmi_buf; - wait_queue_head_t irq_wq; - bool is_disabled; struct workqueue_struct *workqueue;