From patchwork Sun Oct 8 13:06:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 9991827 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 806EF60244 for ; Sun, 8 Oct 2017 13:04:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7271A1FE95 for ; Sun, 8 Oct 2017 13:04:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 66C211FF13; Sun, 8 Oct 2017 13:04:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32E791FE95 for ; Sun, 8 Oct 2017 13:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbdJHNEJ (ORCPT ); Sun, 8 Oct 2017 09:04:09 -0400 Received: from m12-16.163.com ([220.181.12.16]:42793 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbdJHNEH (ORCPT ); Sun, 8 Oct 2017 09:04:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=ztObqBuHmyGrAT3IKR elHsje7/idaH5nyNaTkxoiFXg=; b=gm6e/bJOTA020WyLJYzdNPOgAyWW0iuXcr pffrbuiv8ijgdWtjwzhMZMRJO1QdHj15pt4CiAVZXkpmG//HU9lJDJeueMDHdxyI A6nMJ6JFPw52XvHx/+341VnN6ujZF74it5TEsiSxkRaGho+h6GvOZF3sZ7NS7zJo 7/HhF83fM= Received: from bai-oslab.tsinghua.edu.cn (unknown [166.111.70.46]) by smtp12 (Coremail) with SMTP id EMCowAA3tJwhItpZyKwJDQ--.56576S2; Sun, 08 Oct 2017 21:03:32 +0800 (CST) From: Jia-Ju Bai To: k.eugene.e@gmail.com, kvalo@codeaurora.org Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Date: Sun, 8 Oct 2017 21:06:09 +0800 Message-Id: <1507467969-24016-1-git-send-email-baijiaju1990@163.com> X-Mailer: git-send-email 1.7.9.5 X-CM-TRANSID: EMCowAA3tJwhItpZyKwJDQ--.56576S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF18Kw1UKF1ftFWkKrWUtwb_yoW3GFc_GF 4fXayxJr43Gw17KF1xCF4SvrW0yrnrXFn3Ga13t343Gw43A3ykXry3ua4fXryDWr1xuF13 Ar1DJ3WUtayj9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUj_WrtUUUUU== X-Originating-IP: [166.111.70.46] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbipQRrelUMHCoZTwAAsJ Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No rcu_read_lock is called, but rcu_read_unlock is still called. Thus rcu_read_unlock should be removed. Signed-off-by: Jia-Ju Bai Acked-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 35bd50b..b83f01d 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw, if (!sta) { wcn36xx_err("sta %pM is not found\n", bss_conf->bssid); - rcu_read_unlock(); goto out; } sta_priv = wcn36xx_sta_to_priv(sta);