From patchwork Mon Oct 16 06:00:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yintang@qti.qualcomm.com X-Patchwork-Id: 10007699 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5ADAD60235 for ; Mon, 16 Oct 2017 05:58:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D36C27D4A for ; Mon, 16 Oct 2017 05:58:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 421A927DA4; Mon, 16 Oct 2017 05:58:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0361727D4A for ; Mon, 16 Oct 2017 05:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbdJPF6r (ORCPT ); Mon, 16 Oct 2017 01:58:47 -0400 Received: from sabertooth01.qualcomm.com ([65.197.215.72]:44605 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbdJPF6q (ORCPT ); Mon, 16 Oct 2017 01:58:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1508133526; x=1539669526; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=XGrb9WHE1rnfJTXtKquvopKn2UA7pPswfKGf3AYWCDg=; b=lhtGaRvwDf7S5notgzIVc8d8cIeJNSSuLtj/gyX4g/iqc3qmSIkjnMaR hrT1I8WKzQYpEZI/S76MUYBzFGpEwzV9kYuUdxIT/nfi4Z5z2QP55jlo+ 6ktS3XM1jc98ORdn036HpQiU8O9c4ZRxjIdtBNzJbU0qIX8M8cl831e9q 4=; X-IronPort-AV: E=Sophos;i="5.43,385,1503385200"; d="scan'208";a="115844034" Received: from unknown (HELO Ironmsg04-L.qualcomm.com) ([10.53.140.111]) by sabertooth01.qualcomm.com with ESMTP; 15 Oct 2017 22:58:46 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8685"; a="1444069439" X-MGA-submission: =?us-ascii?q?MDFZ2F/OD/Cu6sKf1eEWu6wGA/bMalYEYwLlvA?= =?us-ascii?q?zaHqcb4RDeIkQLkfm9oZD7NThdBn5fbek7K0cOFdRtzH06APBMJgesq7?= =?us-ascii?q?r39OjEMw4rTAJYvaoME4W8AdIyvLQuaORNniq7wWtswKozy8YLg87gM7?= =?us-ascii?q?Sx?= Received: from nasanexm03e.na.qualcomm.com ([10.85.0.48]) by Ironmsg04-L.qualcomm.com with ESMTP/TLS/AES256-SHA; 15 Oct 2017 22:58:45 -0700 Received: from aptaiexm02b.ap.qualcomm.com (10.249.150.12) by nasanexm03e.na.qualcomm.com (10.85.0.48) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Sun, 15 Oct 2017 22:58:45 -0700 Received: from yintang-HP-EliteBook-1.qca.qualcomm.com (10.80.80.8) by aptaiexm02b.ap.qualcomm.com (10.249.150.12) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Mon, 16 Oct 2017 13:58:39 +0800 From: To: CC: Subject: [PATCH V6 4/5] ath10k: Avoid to set WEP key for TDLS peer Date: Mon, 16 Oct 2017 14:00:32 +0800 Message-ID: <1508133633-23214-5-git-send-email-yintang@qti.qualcomm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1508133633-23214-1-git-send-email-yintang@qti.qualcomm.com> References: <1508133633-23214-1-git-send-email-yintang@qti.qualcomm.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01B.na.qualcomm.com (10.85.0.82) To aptaiexm02b.ap.qualcomm.com (10.249.150.12) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1672043..a984a72 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2966,7 +2966,7 @@ static int ath10k_station_assoc(struct ath10k *ar, } /* Plumb cached keys only for static WEP */ - if (arvif->def_wep_key_idx != -1) { + if ((arvif->def_wep_key_idx != -1) && (!sta->tdls)) { ret = ath10k_install_peer_wep_keys(arvif, sta->addr); if (ret) { ath10k_warn(ar, "failed to install peer wep keys for vdev %i: %d\n",