From patchwork Sat Dec 30 11:08:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10137671 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 667CE60375 for ; Sat, 30 Dec 2017 11:06:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 63CDA28B0D for ; Sat, 30 Dec 2017 11:05:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55AB529488; Sat, 30 Dec 2017 11:05:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0E6A28B0D for ; Sat, 30 Dec 2017 11:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdL3LFV (ORCPT ); Sat, 30 Dec 2017 06:05:21 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:46682 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdL3LFU (ORCPT ); Sat, 30 Dec 2017 06:05:20 -0500 Received: by mail-pg0-f68.google.com with SMTP id r2so6437733pgq.13; Sat, 30 Dec 2017 03:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=1x5bTeXjZjlCY1V0fi1Y2ym+FYDTuOXrTwZjm1bqzXk=; b=hSVzMfHojKlAakKYvH2M8DfUAJZEGplRBqh0jBd+nl2H9wl02pmF10uksijLGjxFgX 2Jv9aBkfQ1dJ8/vfze/afP7UNLgp1sy3n4aXXNaax561AlPgyjpkZ0js4b5/hBYwB4EV tAUqYFSvTZ9rJzvViZsYsqtIfkwjpvSeoVV2cc/+jg5KPp/29wc/MOqaHrRBX5Zf6yEk Rdu1F84Xs+Ghq/oSyYWs9TfJ57Qs0dDk491M7uy0/ZrnUh2meXIZC8hyiHjkc7vjMvOv HpmjNshxYWyyYAeJGjfaSkz7f3zwhTef+veu5EkQI/HyQkD4CEj1hGwI9HFefshmyAiI LBGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1x5bTeXjZjlCY1V0fi1Y2ym+FYDTuOXrTwZjm1bqzXk=; b=Mb2CqesZOvQdKzhkhHHkVE+ZdjQawV2YdPbrdRj/y/K5svOU2ZU8T9gXtHGkpHzjMO K6DBAmDVBc9nzCetu4oMCSdoNCGA+pd1spSoGNTtXDm1BaA2b70yDeB7HyQDG+eZASiG 8JdWr/6seqcRKyCTcHwHHOJvNXZJGUEgCdXEG4PCUrzU/guHZCeCqOuv1D+iq3nQWeih H8DeXnogPthpjIs8dbAtPJj3C58CMqH9vYjPwTwS/PAZQhqiFjoHI3/H3gA2ewFc1XTv vsubANEDJgYKI7qcdlGaCPYE/LVO1NxAIkKuSevt8D1MMKeoFiNruQ/R6rOFQOqxCcr2 3vGA== X-Gm-Message-State: AKGB3mJgKpMKMEbFON8303FsLznYx18+QoeFaSn/i2HG5799Xs0xpdiI RMHrCxl6VPtqtbPGgPZnXEs= X-Google-Smtp-Source: ACJfBouyHZPK2u/5PFJU6mSbOoT1j0v+WkGVGGALInvzfnd0mZl3Rwn4+PJIshB2VlxILb4ezLMz2w== X-Received: by 10.99.66.197 with SMTP id p188mr32364214pga.371.1514631919673; Sat, 30 Dec 2017 03:05:19 -0800 (PST) Received: from bai-oslab.tsinghua.edu.cn ([2402:f000:1:4413:50fc:9040:8222:5e3]) by smtp.gmail.com with ESMTPSA id x6sm85096124pff.55.2017.12.30.03.05.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Dec 2017 03:05:19 -0800 (PST) From: Jia-Ju Bai To: kvalo@codeaurora.org, colin.king@canonical.com, johannes.berg@intel.com, tiwai@suse.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, andrew.zaborowski@intel.com Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post Date: Sat, 30 Dec 2017 19:08:27 +0800 Message-Id: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/broadcom/b43/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c index a5557d7..5bc838e 100644 --- a/drivers/net/wireless/broadcom/b43/phy_n.c +++ b/drivers/net/wireless/broadcom/b43/phy_n.c @@ -1031,7 +1031,7 @@ static void b43_radio_2057_init_post(struct b43_wldev *dev) b43_radio_set(dev, R2057_RFPLL_MISC_CAL_RESETN, 0x78); b43_radio_set(dev, R2057_XTAL_CONFIG2, 0x80); - mdelay(2); + msleep(2); b43_radio_mask(dev, R2057_RFPLL_MISC_CAL_RESETN, ~0x78); b43_radio_mask(dev, R2057_XTAL_CONFIG2, ~0x80);