From patchwork Sun Jan 14 21:34:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 10162839 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A528460216 for ; Sun, 14 Jan 2018 21:34:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 968B82895F for ; Sun, 14 Jan 2018 21:34:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 894FC289B2; Sun, 14 Jan 2018 21:34:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 399EC2895F for ; Sun, 14 Jan 2018 21:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbeANVeJ (ORCPT ); Sun, 14 Jan 2018 16:34:09 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:38758 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbeANVeH (ORCPT ); Sun, 14 Jan 2018 16:34:07 -0500 Received: by mail-pg0-f65.google.com with SMTP id y27so1109506pgc.5; Sun, 14 Jan 2018 13:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=iVV33EB8Esxg2ZvA8uXb+nxThrKD4Jtz5f71SXvR7Tk=; b=YDoHfYIUSD9monwUQxTdxAmNu4bKtFYLoZN0l0WcehU1j1yK/KqPfsOUY793Nat7OV 8xP/EkRdIpSLm9Ak0IBr6eWa3xJubkmMAEkNa8/Cn+pgCLiY8BkTGbt2bI1qo63b5hhQ GQ5KjZFk600koaxy/KQXNNgm00o4w4gadItdjIaEvahjR0dS6CKiQyCi4Iicl9+9nOzX C0HCrmA7AI2A9HsTQiGuaHy+vqLrQyG8tSU+WewvPJ83d34bLUz/rLhwLtGHlpUl6hn1 w0Alsu0BsHwHt1KBFCtZj1Mtm3KZLkzg+IcAhlQNk46fuxQXL5ePYq4qisQqX6Kz6sZ1 Jyeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=iVV33EB8Esxg2ZvA8uXb+nxThrKD4Jtz5f71SXvR7Tk=; b=VxB2y6k9J+cNyAN4CTYQSqj7rxTqA2VSOURaZJdiI/xJQyPGw6xGLBfu4lI84AtVGs miTr1pG98QHW0Ln9Rm28BfZjDqP2VpHHDKNy4USQ+OMpVRMFnyCYetgWTidVCdSwxuQO 1MOW4DhJcgFPA6CFiZ84Dfcr2y1Qi/FXIXsdF6gn+zv46QTHUoZTMxw1+t3gVaaAmO8h qw76IpFValiflEaUmeYI7H5qAHPpAXSY/2Okdsr4VD75NS3vNZKVnpFp4dSxr4VA4XRn zYPZc//QdmCOZv0Jr0NEvXl5MFWTVtj80oKkh4dgYyhxCbtC3ZG8vPlEPg9NednNY5oe lVVQ== X-Gm-Message-State: AKwxytcOOUqjqCqQWCUEGKxVEcUCKXhiGV3oXoquSpU80sw3Eg3kEK28 FmTHubRZuFtEh5MXoiDfzr9BMg== X-Google-Smtp-Source: ACJfBovXfAyjEoLOlb+kEHk5H/sQDyivuaRJFHHPmbOj9DgSFL6UhxGdYAztxeQpvIEiaTw06RoFrw== X-Received: by 10.101.78.207 with SMTP id w15mr2743057pgq.349.1515965647080; Sun, 14 Jan 2018 13:34:07 -0800 (PST) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id s67sm3079566pfg.34.2018.01.14.13.34.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 13:34:06 -0800 (PST) From: Guenter Roeck To: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Matt Redfearn , James Hogan Subject: [PATCH] bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets Date: Sun, 14 Jan 2018 13:34:02 -0800 Message-Id: <1515965642-16259-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Mips builds with BCMA host mode enabled fail in mainline and -next with: In file included from include/linux/bcma/bcma.h:10:0, from drivers/bcma/bcma_private.h:9, from drivers/bcma/main.c:8: include/linux/bcma/bcma_driver_pci.h:218:24: error: field 'pci_controller' has incomplete type Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as generic") as the culprit. Analysis shows that the commmit changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only defined if PCI_DRIVERS_LEGACY is enabled. Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on PCI_DRIVERS_LEGACY. Add the missing dependency. Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...") Cc: Matt Redfearn Cc: James Hogan Signed-off-by: Guenter Roeck Reviewed-by: James Hogan --- I am aware that this problem has been reported several times. I have not been able to find a fix, but I may have missed it. If so, my apologies for the noise. Also note that this is not the only fix required; commit d41e6858ba58c, as simple as it looks like, does a pretty good job messing up "mips:allmodconfig" builds. drivers/bcma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig index 02d78f6cecbb..ba8acca036df 100644 --- a/drivers/bcma/Kconfig +++ b/drivers/bcma/Kconfig @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI config BCMA_DRIVER_PCI_HOSTMODE bool "Driver for PCI core working in hostmode" - depends on MIPS && BCMA_DRIVER_PCI + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY help PCI core hostmode operation (external PCI bus).