From patchwork Fri Jan 26 16:38:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10186561 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D4BC602C8 for ; Fri, 26 Jan 2018 16:34:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3FAB29B1A for ; Fri, 26 Jan 2018 16:34:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E885F2A1AC; Fri, 26 Jan 2018 16:34:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7876029B1A for ; Fri, 26 Jan 2018 16:34:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbeAZQeC (ORCPT ); Fri, 26 Jan 2018 11:34:02 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:43870 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbeAZQeA (ORCPT ); Fri, 26 Jan 2018 11:34:00 -0500 Received: by mail-pf0-f193.google.com with SMTP id y26so577839pfi.10; Fri, 26 Jan 2018 08:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rz1ta+ej/iJ1udz7A5P7rT6+XeuL14GCxf94KhxGDoI=; b=DyMtdH9Gw+koWiQ9CGRbou9r/Jc7PLj2Cb6h9jnTv9X75G2ZlXzsdLjXIWzpdQaGYb SLMUJK+/HlyVm4oHn6QfKAq8LYv6sT/f5TVfTD9Vla1tZ+kEgwI9xk+K7G20C7lQP8id 89rf8+g3jXg0g+6B3QmYtxKOKEeC0YPQnYi7ryymRxM2RhAk1KC7SiQ/UGWdnHvG8qYW vWE4SXSWlW9fgieNhoI3E5QDxVSUeM3s7ii7zyt1vNZAwdKc6HQzQ0wLDk8dJvaCPveq huylUcRrWm8+8rmum2kGGTw66kjEwFbt8vzmnmYBHee7Q5i/9JGqcLovQ6D9pH20FXye hJFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rz1ta+ej/iJ1udz7A5P7rT6+XeuL14GCxf94KhxGDoI=; b=O9g6zTXf6BBNvpmi99Qb7vCTCv2dcd8el9ZRwGTgIWMqT8qa945f1t1gGxGyfqHFIT nogKM8HjBkTpTH+bxSnVm+chQHiZeC69qxwlyKekyRC67UhLOYSWEVk/CnQR5bJpr2f4 z0cHHIy5WY74cS593gBUQ7Fw6Q6cxDpt4xygI9msIJu8Ishdsu5wM+sN4APrWcNLiKWJ YiMyoyIhtMS8ykF9jWxruJ1WPFesjJCnQOLzwQ6Nnw88/M1tl5USTH9mISpGD52InOnL VH7GX7wKfFwIqZSOw+QWuLzqX5gjCbR8D/ed2z6zuiDwx4PSgOsQzBoDSb9jGTp4t1bJ viUg== X-Gm-Message-State: AKwxyteYw0BCyOLoBxXs210iaM+3y9UWsnTIFow9m6S9nJHjw6W7TO07 WyU2ndkyxgINtdPttfpV2JM= X-Google-Smtp-Source: AH8x225K6ArO1zeRGeKNfYdaPubK2eRw7DdlLsYblmUM8wMFF2TsVBo8FyA+qfk935v27HufKBqaOw== X-Received: by 10.101.68.82 with SMTP id e18mr14975956pgq.413.1516984439858; Fri, 26 Jan 2018 08:33:59 -0800 (PST) Received: from bai-oslab.tsinghua.edu.cn ([2402:f000:1:4413:3967:a579:e81d:66fa]) by smtp.gmail.com with ESMTPSA id t21sm19633142pfe.122.2018.01.26.08.33.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jan 2018 08:33:59 -0800 (PST) From: Jia-Ju Bai To: Larry.Finger@lwfinger.net, kvalo@codeaurora.org, zajec5@gmail.com Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH v2] bcma: Replace mdelay with usleep_range in bcma_pmu_resources_init Date: Sat, 27 Jan 2018 00:38:35 +0800 Message-Id: <1516984715-9237-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After checking all possible call chains to bcma_pmu_resources_init() here, my tool finds that this function is never called in atomic context, namely never in an interrupt handler or holding a spinlock. Thus mdelay can be replaced with usleep_range to avoid busy wait. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Acked-by: Larry Finger --- v2: * Use usleep_range(2000, 2500), instead of (1500, 2000) in v1. --- drivers/bcma/driver_chipcommon_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bcma/driver_chipcommon_pmu.c b/drivers/bcma/driver_chipcommon_pmu.c index f1eb4d3..478948c 100644 --- a/drivers/bcma/driver_chipcommon_pmu.c +++ b/drivers/bcma/driver_chipcommon_pmu.c @@ -203,7 +203,7 @@ static void bcma_pmu_resources_init(struct bcma_drv_cc *cc) * Add some delay; allow resources to come up and settle. * Delay is required for SoC (early init). */ - mdelay(2); + usleep_range(2000, 2500); } /* Disable to allow reading SPROM. Don't know the adventages of enabling it. */