From patchwork Fri Mar 2 14:22:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 10254769 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 32EF3602B5 for ; Fri, 2 Mar 2018 14:23:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 232BA289A7 for ; Fri, 2 Mar 2018 14:23:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17C17289B1; Fri, 2 Mar 2018 14:23:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5F89289A7 for ; Fri, 2 Mar 2018 14:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425538AbeCBOX1 (ORCPT ); Fri, 2 Mar 2018 09:23:27 -0500 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:57547 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425508AbeCBOXY (ORCPT ); Fri, 2 Mar 2018 09:23:24 -0500 X-IronPort-AV: E=Sophos;i="5.47,412,1515481200"; d="scan'208";a="9756776" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 02 Mar 2018 07:23:24 -0700 Received: from ajaysk-VirtualBox.mchp-main.com (10.10.76.4) by chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 14.3.352.0; Fri, 2 Mar 2018 07:23:23 -0700 From: Ajay Singh To: CC: , , , , , , , Ajay Singh Subject: [PATCH 02/13] staging: wilc1000: remove always 'true' check from 'if' statement Date: Fri, 2 Mar 2018 19:52:38 +0530 Message-ID: <1520000569-27738-3-git-send-email-ajay.kathat@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520000569-27738-1-git-send-email-ajay.kathat@microchip.com> References: <1520000569-27738-1-git-send-email-ajay.kathat@microchip.com> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix few smatch warning related to 'warn: always true condition'. handle_cfg_param() warn: always true condition '(cfg_param_attr->auth_timeout < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->rts_threshold < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->beacon_interval < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->site_survey_scan_time < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->active_scan_time < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->passive_scan_time < 65536) => (0-u16max < 65536)' Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index b46a759..f992e5d 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -510,8 +510,7 @@ static void handle_cfg_param(struct wilc_vif *vif, i++; } if (cfg_param_attr->flag & AUTHEN_TIMEOUT) { - if (cfg_param_attr->auth_timeout > 0 && - cfg_param_attr->auth_timeout < 65536) { + if (cfg_param_attr->auth_timeout > 0) { wid_list[i].id = WID_AUTH_TIMEOUT; wid_list[i].val = (s8 *)&cfg_param_attr->auth_timeout; wid_list[i].type = WID_SHORT; @@ -579,8 +578,7 @@ static void handle_cfg_param(struct wilc_vif *vif, i++; } if (cfg_param_attr->flag & RTS_THRESHOLD) { - if (cfg_param_attr->rts_threshold > 255 && - cfg_param_attr->rts_threshold < 65536) { + if (cfg_param_attr->rts_threshold > 255) { wid_list[i].id = WID_RTS_THRESHOLD; wid_list[i].val = (s8 *)&cfg_param_attr->rts_threshold; wid_list[i].type = WID_SHORT; @@ -632,8 +630,7 @@ static void handle_cfg_param(struct wilc_vif *vif, i++; } if (cfg_param_attr->flag & BEACON_INTERVAL) { - if (cfg_param_attr->beacon_interval > 0 && - cfg_param_attr->beacon_interval < 65536) { + if (cfg_param_attr->beacon_interval > 0) { wid_list[i].id = WID_BEACON_INTERVAL; wid_list[i].val = (s8 *)&cfg_param_attr->beacon_interval; wid_list[i].type = WID_SHORT; @@ -673,8 +670,7 @@ static void handle_cfg_param(struct wilc_vif *vif, i++; } if (cfg_param_attr->flag & SITE_SURVEY_SCAN_TIME) { - if (cfg_param_attr->site_survey_scan_time > 0 && - cfg_param_attr->site_survey_scan_time < 65536) { + if (cfg_param_attr->site_survey_scan_time > 0) { wid_list[i].id = WID_SITE_SURVEY_SCAN_TIME; wid_list[i].val = (s8 *)&cfg_param_attr->site_survey_scan_time; wid_list[i].type = WID_SHORT; @@ -687,8 +683,7 @@ static void handle_cfg_param(struct wilc_vif *vif, i++; } if (cfg_param_attr->flag & ACTIVE_SCANTIME) { - if (cfg_param_attr->active_scan_time > 0 && - cfg_param_attr->active_scan_time < 65536) { + if (cfg_param_attr->active_scan_time > 0) { wid_list[i].id = WID_ACTIVE_SCAN_TIME; wid_list[i].val = (s8 *)&cfg_param_attr->active_scan_time; wid_list[i].type = WID_SHORT; @@ -701,8 +696,7 @@ static void handle_cfg_param(struct wilc_vif *vif, i++; } if (cfg_param_attr->flag & PASSIVE_SCANTIME) { - if (cfg_param_attr->passive_scan_time > 0 && - cfg_param_attr->passive_scan_time < 65536) { + if (cfg_param_attr->passive_scan_time > 0) { wid_list[i].id = WID_PASSIVE_SCAN_TIME; wid_list[i].val = (s8 *)&cfg_param_attr->passive_scan_time; wid_list[i].type = WID_SHORT;