From patchwork Thu Mar 8 06:23:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10266711 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1F19D602C8 for ; Thu, 8 Mar 2018 06:24:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1125C292F5 for ; Thu, 8 Mar 2018 06:24:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05C8B292FD; Thu, 8 Mar 2018 06:24:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A42E8292F5 for ; Thu, 8 Mar 2018 06:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965598AbeCHGYP (ORCPT ); Thu, 8 Mar 2018 01:24:15 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:37007 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965210AbeCHGYN (ORCPT ); Thu, 8 Mar 2018 01:24:13 -0500 Received: by mail-io0-f195.google.com with SMTP id d71so5845483iog.4; Wed, 07 Mar 2018 22:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XRt1VT34rnJK/jxU0sWMJnU+X3KDsEmozopPJr+pg5Y=; b=SdBZBSYP97gQymW7vdg4KbRpjhtXV/+EkqeU6ixZ/l0FxIO+KZXQz9JbeT4ZiQ0+yQ aakcTQrH7fJRJdUEJOfQ54TlvR4BBhgFziTMkeEbbrfpSr33zz81u4a0Ph8kMH10vRoN HDosowpRIFQ9I0KdDP2DyIGUoxvPYtSEskVHv5Qb4byjKNItmOjX1Da+soJWbJDcxYrk 0Oj0i2XbezhxbK6kdQgSbuzTFeAPufWAslK5mCSUCocwa2FUxE+XSOKB+4Pt92x2Nraj PegygVEoSE0H3Oi+YUDbihPFijJvZmeTVqp73dE7rJhlvjiyCIje+X/JPqoKMsITl65R pTLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XRt1VT34rnJK/jxU0sWMJnU+X3KDsEmozopPJr+pg5Y=; b=lyS9ztDlHYczmSKzkOdBB5HpQGkFqVH+5znv+C53Qrm731BwxPhswfwHAzUaTQi2Jc Gio7Ja3+eqT9BxjlHhiAoL1nF2ZTbbnpSxmhgHQXCxba/JdQkFltdsJlYWtVdSpRpHvo 2hPZGSj3R0L37iQVaXyOCOTW6Apb8E8C1AFwDVEbie340I7FNftrnHKY72+nST3BBoa+ TcsAOsDT1WzIMEFzbBLeOCluYIJxLBStAq1P60KbjTFGvTOUuU1ibzWmMvQ4M/wRtn+A GVVve1VZaR33EcZ0poVF49lis8qVI7bd7tdobw1wPInyHMll/uCO0hE3ZkvaeKh1neW3 rfgw== X-Gm-Message-State: APf1xPBKpQZtQFVO0OEZmBgUYBcgpgF73uJAr+IsFXi/lkCzfKUsckkT wv/ljzhmCTlrS65KiWl3+snLeg== X-Google-Smtp-Source: AG47ELujlEOeTMKmB+4K1NapOA1o8WT+J+dZuJFZKaOBRAQbRwRpc/SfOFKHpHHbwAYJAru+XezkOA== X-Received: by 10.107.137.142 with SMTP id t14mr28707705ioi.230.1520490253193; Wed, 07 Mar 2018 22:24:13 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id 185sm10109466itw.44.2018.03.07.22.24.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Mar 2018 22:24:12 -0800 (PST) From: Arvind Yadav To: m@bues.ch Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH v3] ssb: use put_device() if device_register fail Date: Thu, 8 Mar 2018 11:53:24 +0530 Message-Id: <1520490204-10411-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- changes in v2: Removed kfree() call for @dev. changes in v3: Add put_device() in place of kfree(). drivers/ssb/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..e732fd3 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -522,7 +522,7 @@ static int ssb_devices_register(struct ssb_bus *bus) /* Set dev to NULL to not unregister * dev on error unwinding. */ sdev->dev = NULL; - kfree(devwrap); + put_device(dev); goto error; } dev_idx++;