From patchwork Thu Mar 29 16:21:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirill Tkhai X-Patchwork-Id: 10315691 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BDC306037E for ; Thu, 29 Mar 2018 16:21:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A98882A2DB for ; Thu, 29 Mar 2018 16:21:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D6FA2A43A; Thu, 29 Mar 2018 16:21:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DA592A2DB for ; Thu, 29 Mar 2018 16:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbeC2QVZ (ORCPT ); Thu, 29 Mar 2018 12:21:25 -0400 Received: from mail-db5eur01on0134.outbound.protection.outlook.com ([104.47.2.134]:38336 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751714AbeC2QVU (ORCPT ); Thu, 29 Mar 2018 12:21:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MNbbYRY/i+l/DleKd3y65f3arlBIaMc9KWOqiGktaVM=; b=I0UQ1KT2j2M7ayGIbP9NrFaYTyNh3LwWXrPQkseYH17/dn1m/aIM1+ZHenxT8rXJDP/y1gXQkAJudvJCQ7j4NvNn8RkjrKLItzEDIZl3+x/MZQDI6Z6OHbLCYKfvvZoe5wXQ/ILdjnSFc8KqqjPLxa0H8s5piL4wodg6qesgu0E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ktkhai@virtuozzo.com; Received: from localhost.localdomain (195.214.232.6) by AM5PR0801MB1331.eurprd08.prod.outlook.com (2603:10a6:203:1f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.10; Thu, 29 Mar 2018 16:21:12 +0000 Subject: [PATCH net-next 4/5] ovs: Remove rtnl_lock() from ovs_exit_net() From: Kirill Tkhai To: dledford@redhat.com, jgg@ziepe.ca, davem@davemloft.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, pshelar@ovn.org, johannes@sipsolutions.net, paul@paul-moore.com, sds@tycho.nsa.gov, eparis@parisplace.org, jmorris@namei.org, serge@hallyn.com, leon@kernel.org, yuval.shaia@oracle.com, parav@mellanox.com, danielj@mellanox.com, ktkhai@virtuozzo.com, majd@mellanox.com, nicolas.dichtel@6wind.com, vyasevic@redhat.com, paulmck@linux.vnet.ibm.com, vyasevich@gmail.com, gregkh@linuxfoundation.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, ast@kernel.org, brouer@redhat.com, linux@rasmusvillemoes.dk, john.fastabend@gmail.com, dsahern@gmail.com, jiri@mellanox.com, idosch@mellanox.com, vvs@virtuozzo.com, avagin@virtuozzo.com, roman.kapl@sysgo.com, lucien.xin@gmail.com, christian.brauner@ubuntu.com, jbenc@redhat.com, pombredanne@nexb.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, dev@openvswitch.org, linux-wireless@vger.kernel.org, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org Date: Thu, 29 Mar 2018 19:21:09 +0300 Message-ID: <152234046913.19153.5014546114733288472.stgit@localhost.localdomain> In-Reply-To: <152234005959.19153.17907173734141707348.stgit@localhost.localdomain> References: <152234005959.19153.17907173734141707348.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0701CA0057.eurprd07.prod.outlook.com (2603:10a6:3:9e::25) To AM5PR0801MB1331.eurprd08.prod.outlook.com (2603:10a6:203:1f::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f629747f-874c-411c-4ffa-08d595911819 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0801MB1331; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB1331; 3:Qk5SwVe9cU3wOsKlxajzZNesq5prtIhPjtOzKZuVB467fItyNm3lF0qyjIjhRCdbXtbI7dUauXpTCoo0tnEkEbYpAklurJ0lkmP2PHY1TRWAAGqsNN/4K7oX5yIv6Ufz7ov31gtrXVSvacANquOMfPjBl5plHqCjKOUZ/YlwXOpVA2s92UJIF4kUP994/60wnqDqXMBtP830E+hAJAYcNIOOsMlBzlAwlq8tUDMjivDTYaiDXqEAA1Jk+asm+ncO; 25:8dgO7Y8/pw4sokBvZ6RklnZaQnChtq9kX2ghFXAP41Cw/V/9SW675+dyZNu4zyZFBCM6A8A+JOKFmdVhJzVPElWNEM9FhEh2ek+g5rZHa3Z80ek32YwDKX+kKLi7bpBGU1RJPVNWyN/3zyfMexCetgA3AwXWyEDpwpad/izAyrh3kynar5u/7XnkmhAGJrFr5y0Yzw5KpIcXruYkjQKZaAoYZGNiAnul1ESmA+xo7wKdEmwW7jrUsLk1po5VMIRFckD+jDmd6QIhu2AU85CXr2f7Ewon3/c64ZpkHBU3uZAhZ1Q+SFTST2RAE2eydSS2bKI6joAltuOc9h0em3qQNw==; 31:rHNQ/7He/KkCLS1U1xiVWGSS4vIeRFCTq5S5+C58veu9YFybdqdG2kdbwtrtW6IhGACr8ushO1IixvrgYEKiq88ZmHcJfAEee2NcBF198NtrhnasvDIguUSGzReMOFaAXutGnqdTyHDAAybH7RJX9HSvbklUyVs7yaKzflmc6AFaNjVJ0xDr3dcSHQfP/p8/4FeeUCmMLGMQGfxlZoquXIt2v7Yx3ucDM0o3rCkR8kc= X-MS-TrafficTypeDiagnostic: AM5PR0801MB1331: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB1331; 20:obFt1cYqJwXgwgXfe1bXm5rrdma6s7NjREW28lOumtsv3HGgxZT9zH2CT9P9ORiQVyLe8DKmBBXIjkROHI960XL/rIvAmoEu3aiCBGRL1CXxkcQvf/9liA9qIYE0hdLiRUU0jCyjextqZxunZB8wUV0DYCC+2vmp1sP5VZi4LfVHzAJKP+WSw0qdYe/41RFMJ6pRqz6Rl0YxPn94GO9A0TfMI0XV+RGb4oYIdj2nHtLV8WrFZDlfX+UqGo5H0z6qb4OdMRVowPJOxcb8bgzFbFP6W2zjrFBe7f9oXWhvc0Ki/G6lmGu+CUv+vjMjYSfRRBXpKE7BnRbkQ8Z6mbZiE2vdtspRhoud8agJrdm/OaTKfbhCkLUatBbw5qrZ+gbWl8dVSJVfnq3ax+Zlz2I/zz0OLyF7qHAxxAGrOAERemhq8LOwpgxj3bohjPaTcH/unVZcDYpHRnUEO1WM8hW7UG5UhBaw18lVIffXS9Lny/6LuBMKhKJDcW0I9QolWC6T; 4:fEITN1J4fVs/X2Czc6aLitMBSrYwygQZhTimi1xdOmWbjqz+YBfJQfG9NXwqdeD/jvsoIz86xbersRfRPmj2Aik9Kul2+iX9uZeqiipm2uUlkPtVoT/JEy5EjmB9cEL3SO20gqiVkuEYQV80elVgtCnFl0KNRJTJfnQi9dDL/4bXXEyvPNyn3vSEMVJIarFTMfy6E6i0n4XkRdnaSd8RhOMibxgwhCryWGxqG6mF0bxH5m7L2pHNZ44BDkAz9mp2eFYDEEy9TKM1/7xh61ipcw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(10201501046)(3002001)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AM5PR0801MB1331; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0801MB1331; X-Forefront-PRVS: 0626C21B10 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(39380400002)(39850400004)(366004)(376002)(346002)(396003)(189003)(199004)(7696005)(8936002)(478600001)(59450400001)(23676004)(2486003)(52116002)(26005)(61506002)(76176011)(446003)(8676002)(16526019)(11346002)(186003)(47776003)(86362001)(66066001)(486005)(476003)(486005)(7416002)(7406005)(105586002)(5660300001)(7736002)(106356001)(230700001)(55236004)(97736004)(25786009)(305945005)(33896004)(68736007)(6666003)(50466002)(55016002)(3846002)(103116003)(9686003)(81156014)(81166006)(6116002)(956004)(386003)(6506007)(316002)(2906002)(58126008)(39060400002)(53936002)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0801MB1331; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA4MDFNQjEzMzE7MjM6UDFXMW1DMGVlU2k0b3R0OEJYQURDVWpi?= =?utf-8?B?ZWJwMVZ2dGY0d29IQTBFdjQrV3p4M0FrY0JXVHZ3endDNmV1RU9XMUZWcVpr?= =?utf-8?B?WVdjNXZjSElwOGpMbllRRllwcWUyWmI2YXNYQXRkc2YxMFB5UjFiYlQvdDJR?= =?utf-8?B?UExPTDNYRGt6NzBxNVNEWDRLSmZNN0RNZ0dqcWJTc0s3c1hPck9XY3Q4dG1X?= =?utf-8?B?Wm13d2hVQUxCM09LQTNONE1aME04Z3JubHJrSDJtVkpGVU5EVnBhN0NHUjBE?= =?utf-8?B?UzZiVmVmSlRKRGdQMTYxRjE4bG9pT3FUSGVUNUxFclZBd21zb1I5MGVJak00?= =?utf-8?B?c3Z2YjhIVFBVcE5NNUkrcEVHTTc3ZStyVWxVY2o3ZWpkTWhWVGdnWVRubDJE?= =?utf-8?B?WVpkREpBUndLbW1RaTNTVVBIMzNPWU5LdUFDUGMvb0tqcGYxWmd5MXRXa0pn?= =?utf-8?B?ZUdQTHJZZWRuMm9UT3o0eUxOT0l1azJRU1VRQmthYmdjUHowZXkxRzk2RTlM?= =?utf-8?B?UWtOQ2U1cFdjdW1lNUlJTytGUnlROU1LdkZCQktXem1WWWtFbDNhT3FxdkJR?= =?utf-8?B?TjhQUHBUWVY4NGFKbUpyT1dzY21xYWtkeitrd3pBYVF6cVhuRmlWYzVuQXM0?= =?utf-8?B?S0tBZ2lHNHBwejh0RjlobzkzZ0xlekRTRGwrNnFNbHNzWnc4L2RJczF0cUlT?= =?utf-8?B?cDVyUGY4WUJaVGhZNDdUMm5qNzlwN05JZjc1WEYxYThBVGlYL3FldW9Xcjcy?= =?utf-8?B?eGx4Y0ZsaUxtSDNnbnlydlA5ak1XK3NuUVBZbTQyb2ZmYnJEWFdvcFE1dFdP?= =?utf-8?B?T0lTU0g4VmYrRFAyaEl6MDZUU3NqMzBGWFZCeEZvS3BpQmtVOTRjc3NDRmFa?= =?utf-8?B?ekxENkpUemlBSHRTdXlmSzE3NzM4RHRKOWc0OGN3M3plM2lmM3hKWlpqNjdv?= =?utf-8?B?eEkzVVZ3YmJBYVIxQU83S09tb2VpWU5WSmN0SVg3RlBGb3NYK09VQm9rRElw?= =?utf-8?B?RXJaNHkyaVpCdUkxRHZMdkdCem9SUXRmZEkxczhsNTBDK1lZRVB0K0xuRy9X?= =?utf-8?B?clJzaHNWLzNSU2hQWUhYcVgreW5QZkptS1lsaDk3MjZUYi95VTRwRVQzeWgz?= =?utf-8?B?L0luVjl5L0tPVEROYngwQS9IMEQxb1h5VUp3N0o5eHVzUWl0SXdUa09KbkpN?= =?utf-8?B?VEtqRFRCY2VnelZ0VTRCMTNnUWMrUUlWVEtpUzgyRDA1RmF6NXl3MktxUjFX?= =?utf-8?B?MDVPWDNFQ3N1TXZyMFRQeXRIbkNHSGhGaHVmVnJWUEIzVlA2dUVBOUdDK1RE?= =?utf-8?B?d212cjB2Si9YTXh2VkVPTUxydENHSk9USEJPdVR0UmRnVDNJOXVMd3kxUUx1?= =?utf-8?B?U2xRUDNxaFI5Z0pVRTczYjVCaUZwUEszZHd1RzV2cHF6ayt2d2F1TUpWeGRK?= =?utf-8?B?cEhGUnlnMTl0NFdCMDJIYjZoeGJhV0NiUS84aTVXT3phSmRYUm1pK2Z3WG91?= =?utf-8?B?dFlLeWxFU1NidnNGUDlheU1iU3pqbGVNTGFIakZXK0JYT1c4VjVpSDVWWUhF?= =?utf-8?B?M1dUb01ZWXpJdGx1VmoyUUo1LytydjNTSUtOMnFDMTE0RGFRWnQrVUYvOTZy?= =?utf-8?B?YkQ2aW5LN1NzQ0UxenV5a1l0TmJKZTNNYkp4eHhWUHZIWUhEZ3NadHFKZVVq?= =?utf-8?B?b0pYTGRoS2NRZE1PVFIyZER2eFEvRTVkTFYrSVlLZmdnNitNWWd3SGRtU0VP?= =?utf-8?B?alUwYUlOTUpGMktONkJWemdLeS9TYmJpSnJFMy9lbFRwdDBIUUV1SEY2azJk?= =?utf-8?B?VmVtQ3BhdEsyd013a0VRQy9Wc29sS0p5cWdTdFh5VGFJWlpIdDg3S0dDOWZw?= =?utf-8?Q?etkufv5yCwhZI=3D?= X-Microsoft-Antispam-Message-Info: RSAwwZxT6WCRfRkzQRVQwr0tJkslGvUoixNRBvBW4u5yJBt3c/irhDrTmSmLSRkPZih4wgu7Z9shqXKdpLgY2AXnGjfJSLDs6MV5nbxJcpJr5hW+rKCS7oFbcO2QBKnOqk3cbwL80NtUs4j7+fiBJKvBqH9xh7tPskM9UBkVgnrQVK3E2ijmamPBqOnEMoqZ X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB1331; 6:79r+l8ANIVYQ95eNaVP1nLvq/Jybr+G9AjHJ+fkOpPAU67MknoYc6RRocuhokIQmLCI5qL0rbkwAedqcIGeau3MDxG1mcNDJKG+jD2radgZerVrrLu7tC+JvmWqIFlppnQ7k96TZzndoqN3hinLUfej0ynkpGCWjuRXHbvNP9xDQyRlTXQZBwUekkmZnX9RrMINd5o1k95AeJAg5X4P9xaqLtSX32PqCJymyRkwE2x7/xOKGWi31Naok/mnUiWc9XaOV7OVcuYlwU14p6b+xGqDE88XvennAwubi+sEN3kyoVQNkY/RzgJtk8lIW2rYv2oPLCepOrkknp136e/t4lckhbAU4Zy6ERCsUPJHCi32pAC2DPRFtNTl3eX+yE4Tlvy7N9l5KyZdVbtEaAgD2CYapjZBJ9jjHKhmtEdIErGykUnwdx4hiMmB1nHgp/S0OYJrrCKp+DhbuorEdPIQFZg==; 5:wmu2RVANfxg6QXjiMpdF8dy7fsIwvami/U1f9u2fMCextp16B+Rcrj0B4QdRSRDCijHpSmgYAEROLlckKN6zQWtkLVGn/8KzuCiy2vndVNvEqQ6pw6I2ms3GIdtV/nClSROvv2quheQeMxkl/BEwZ77U5gvJQs6tpOegVLtkPSg=; 24:LabDgNeC8Wtv+I8v1BkLd97ZFSvpKjUqqJXj9hyvK3l1fu3BuBEcxj0sMdWmFQoIw69OyMK/xZfAjTSfMco/f0E5GeKAyvEc29YY9wH/Upo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB1331; 7:r5ypNcMot+8W6+GGd8z1KGkMYQkvJfoVWDu2dAMnyFO1sqnzu0tdFVjHfTCFtrm4LHnuiy+cBOf5Bnhalw9U57K5WCrIoS19d8DDposDqkIKLgwX9ltiF5he3k1PIhOLi/dzeJKbei2BSmFNGQ0ADvfiW+1mW0EvC5O6hpmyBS1hKFitPSSUq+YXnyT7f3eiejAKoGFqLVXcdA/dex1vi9KX5CMUPAZMHAe/pdzNEOg4xSz/+esSwvZzPVvLCm4M; 20:cmegPRy9q9eV8tYp1FzLZCSfzLl9rN9JOlI7NYiOKjTZ6TAEb1oyeXjP6/4MgPbdZ91jFxuHmTJCWuWzIBl1/xxDIbwWj97cczmAxq7VVbYseDZhaaRuUczeufiVf9ouvjWYJGohrhWlB6uV1piiVvRoMzI8qtZVNWsaaZ7qjW0= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 16:21:12.2059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f629747f-874c-411c-4ffa-08d595911819 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1331 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Here we iterate for_each_net() and removes vport from alive net to the exiting net. ovs_net::dps are protected by ovs_mutex(), and the others, who change it (ovs_dp_cmd_new(), __dp_destroy()) also take it. The same with datapath::ports list. So, we remove rtnl_lock() here. Signed-off-by: Kirill Tkhai --- net/openvswitch/datapath.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 9746ee30a99b..015e24e08909 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -2363,12 +2363,10 @@ static void __net_exit ovs_exit_net(struct net *dnet) list_for_each_entry_safe(dp, dp_next, &ovs_net->dps, list_node) __dp_destroy(dp); - rtnl_lock(); down_read(&net_rwsem); for_each_net(net) list_vports_from_net(net, dnet, &head); up_read(&net_rwsem); - rtnl_unlock(); /* Detach all vports from given namespace. */ list_for_each_entry_safe(vport, vport_next, &head, detach_list) {