From patchwork Thu Jun 14 10:11:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omer Efrat X-Patchwork-Id: 10463751 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7598603EE for ; Thu, 14 Jun 2018 10:11:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C84F8289BE for ; Thu, 14 Jun 2018 10:11:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BCF45289CF; Thu, 14 Jun 2018 10:11:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17ABE289BE for ; Thu, 14 Jun 2018 10:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754980AbeFNKLM (ORCPT ); Thu, 14 Jun 2018 06:11:12 -0400 Received: from mail-eopbgr40091.outbound.protection.outlook.com ([40.107.4.91]:41056 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754837AbeFNKLK (ORCPT ); Thu, 14 Jun 2018 06:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tandemg.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FUq0EYnRJO015Cs594wHT4keEaP1QXZV/mtc2y58p04=; b=j4+ZJLYQrHOBH9+2sdxFIRBjfnjt5F+O1Z6ODhl8IoHmN8VbA82B70VJgKjR1oZEN84kRoA+74TS1jrd6WB3VYP2OdfVOe1RBj96Uae0GvX818ulKIVt0Sq+JVH0PsJqnuIgR81eyGI3crBAgBH1tbjXBw/8AMz6Vm8VzE+G8aw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=omer.efrat@tandemg.com; Received: from omer-laptop.tandemg.local (37.142.120.98) by AM6PR02MB3624.eurprd02.prod.outlook.com (2603:10a6:209:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Thu, 14 Jun 2018 10:11:07 +0000 From: Omer Efrat To: linux-wireless@vger.kernel.org Cc: Omer Efrat Subject: [PATCH v2 1/5] cfg80211: use BIT_ULL for NL80211_STA_INFO_* attribute types Date: Thu, 14 Jun 2018 13:11:03 +0300 Message-Id: <1528971063-32764-1-git-send-email-omer.efrat@tandemg.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.120.98] X-ClientProxiedBy: LO2P265CA0200.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::20) To AM6PR02MB3624.eurprd02.prod.outlook.com (2603:10a6:209:2b::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6dc27a19-5da3-4fa0-3459-08d5d1df2551 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:AM6PR02MB3624; X-Microsoft-Exchange-Diagnostics: 1; AM6PR02MB3624; 3:kiRNuT2HKVLznE94fvlS6NhBuq5kuNye4x7rNp8Xo8Ihg29ueVgW07FAka7ycqIbso/Y+YcuSVXZtFNhG/H1maGJyl8hMPn3B1/Am4SUTetAjPT3zkNgytd8S095H5WtGU8xwRGqLDU25iP10YFljYShSW10aQAPLYg1OCUXyIsPl6vfrdMkaqirta5fBb0VfNf41qPir74K5Yxty7WxSOGQfwCWAznD9VsZIdUcobMS4Hxj46raM42aiMltUD3d; 25:JWNNTYcz+iSt9W2xrRyHrj/Hi9x8meeLWhAGAiJa6VKyQKU+f/Z+si6rxMmNvEb/BXGfJEpsIioP5bgJtfnfPTAbrE2ZtTx8lmtmTMF6CSgI5T3SDm/8+Dn9qTVU2oof88BomCXmApOKBN6UWKEmkOU2u+itcXrGUgbv8w3kkIP3rt4xsA/r28ML7EdN6fjo3GMGjhmHZpbAUbSWpJfyvaIal+Hm5GPhEbje7E56fmKDcKAJMQCS8Dh2di8au+6Kc2q+FSrrCNxtKZYDQAVg2WOUgEemCK5EZ2ESQaKseHecYovxBp92G3KdgB4unbClyVq+FhS6GqIII507Vj7XPg==; 31:fh8OYxF9Ex1SNhACYsWFxbJKSvEA5rtadHTIuV8uxt4KoqBSTQEM7ZnFrkE+38U0CV9pVkT01cy4tG+0F/jwsmAI5FR9i4IkT+O2B+VZLghupww+Vv5IxdT5YplZrZaVEhp4UeUkBjKklMNE/YtWsfwqz8bvy0JkjfcBDMWmQBHuk9sia7APqn9nhQUzex4sQG9n8U6ZS/KjpcwOg1bWLF1tif8tKXt2halAuXnfugk= X-MS-TrafficTypeDiagnostic: AM6PR02MB3624: X-Microsoft-Exchange-Diagnostics: 1; AM6PR02MB3624; 20:I3AZtztAb50/Ta08bf2Se+RNZKlLRMus1twTQJW27gnlQpekdSy+auVY5Sdcvbfx/BQGcTV6koAu7ay2H2kzJWGkSNTyiQdGxA4Iamimu2bGZDqyOVEa+SOFRL3BfKFMWODAoQuygJ2/TU/+OsOX1MwbPnEAwMl4qL04meKQjciHknjV/7PWJERPK4pBR6kEwA/UFRPGNC9f0zbXD9WuoH82iPv9pvumFsSc7Hf2psu5XrWKLY6Unn66RgL7eOAqZW5WAKD/zvFCbzzOnGBk0P/+u0F665drIYSj7+Hg76u0TwR4l+si4A55LTyJCy5UFhbp+DJEAecMhY71tjjc8Q==; 4:STkqiv0apEN9L6POaB7QlNBf9XOV0WPvAxcKwAOjAOBnVg/9Jga+wKkVpbctVHb+VVL+DSg9+cNIUv5quoBBogT1qRVt0AaoiJVbwWNjooZ1zAvQ/D9DaaXJSLD44ecyJEvC/w5N9T6kRZ8jyGLKkCTocmgkhuFf7JM+WNhdW69uTHLQc9piudZB8nVauxUUYNajWTAHsbCBfC6jZOYedzO35LtMH0tl8/QfHo7hjnoHvjI/G8Cz5TSmma7qGqdoTIaPEcTvja/Y1gP3QovJug== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM6PR02MB3624; BCL:0; PCL:0; RULEID:; SRVR:AM6PR02MB3624; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39380400002)(366004)(396003)(39840400004)(346002)(376002)(189003)(199004)(6512007)(81166006)(81156014)(50226002)(8676002)(107886003)(2351001)(25786009)(2361001)(8936002)(7736002)(53936002)(478600001)(68736007)(6486002)(4326008)(97736004)(48376002)(476003)(956004)(486006)(2616005)(50466002)(44832011)(305945005)(6916009)(26005)(6666003)(6506007)(386003)(59450400001)(66066001)(16526019)(186003)(47776003)(16586007)(52116002)(51416003)(316002)(105586002)(106356001)(2906002)(15760500003)(36756003)(6116002)(3846002)(86362001)(5660300001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM6PR02MB3624; H:omer-laptop.tandemg.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: tandemg.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR02MB3624; 23:bIs1yxtU1z1t0oBNQMO5BF92mnu0rJWYIymEcgxI3?= =?us-ascii?Q?IkWqII9Id1ExYQ2WA70RWvrxr6+8u8xeZ9Xii5YYi7TG7mG5GY6UymWQ1j+R?= =?us-ascii?Q?jjDoKqRO7XSEnYzSmiuEuHfQH18vECf+eiBvVjSUw1AOruTEQBj6wTeW0Eey?= =?us-ascii?Q?yalCLf9ci8sQW/z3wY6m/CYY7OvSYx79kO/qmGAw+JLqMVyX5seMH3MKclgz?= =?us-ascii?Q?nG+qXkO9p0j6i1QKegMrAk8CaKYyZ8+CNZ/pNY6Bl9AIl7Cp68XOp2AAYxsG?= =?us-ascii?Q?Rn7h/my0MH2Tyi1DKDraILKA16jOsic1tkdX5ceTMGicHPVKI8YqL1P2Ww5k?= =?us-ascii?Q?McTwQDBYxVGb8CHR8r8Iza4Y6f/2K9CdQ41iQeBvdyEItugdtdlu6aW+cPhB?= =?us-ascii?Q?gNQ+SsuXkVGxZg0a/J6nNtU/goOxqBxwfE4r9XnqIf6Os/UkASkCe4JFJSfU?= =?us-ascii?Q?lwN+x+pHgNXTLqaZJxDfYyyQ30XDD+CHxr3W0BHgHIhZxfwTi6XECarWXyW6?= =?us-ascii?Q?7mZjC0xqNl8Ofgqj6X9HJ8Jll1ng+bUI+K6NVf6zuFMDQd5EMDLgK0W0p/LX?= =?us-ascii?Q?eyjyjl8nGgWFGY4iShrMsJbniNWkFu2VRBCLCM58mkO95SBAXSaoO1BKNLAE?= =?us-ascii?Q?lgnezCbTVBpoB5jjJMwbYxvgRvhCiob3JITVCZ7vKNaZz9KRDl/4w4xh2PpS?= =?us-ascii?Q?VFWJIg5JYM9ml66U4vINPpnpOw/sEQX878dEr7CXxwdiATlxBRHVC4OPm/px?= =?us-ascii?Q?gZ6VO5DWd5YqEqkN5Pwv3XAUZ/3javEM2u2m1ocMiljyQtsZYH9scDmcvmUD?= =?us-ascii?Q?WIVSJjD6J5p/1LeBjQvyHDyXanOVwviexJYU/y0KS1T2ao8tOvjvl/RPgoxl?= =?us-ascii?Q?I7Ih6sTkHqRyP8/3qDSUb31OWl915h3T9pC6yMAbSN2qTVHfVtjccSyym/Pj?= =?us-ascii?Q?swTXtS+QNAv5LT+nnD8hFAOWzUg6Mk8+M8fMB2jyZQXAsMpV4Q4zBtdvl/cd?= =?us-ascii?Q?EGPKIOggXa7kDa/1tr/n4urSUnvy8bqrWaN2w9RRjQu3S8WJWySkbqe6yIHm?= =?us-ascii?Q?zzu2kjMob3u3sjUxtcTwMcAK3Jc209+cJa7XzyQv+IuXI3ZbFBkaPzxXHrul?= =?us-ascii?Q?ptoVKbIFMgv6+hPTLHSP0tWjBdZc3nBtgJzcxfQGkkoxizhS4D0fEXvWNemu?= =?us-ascii?Q?zHAZDSIBzrXlKILIVHnODSkj7x8xDrBRA+f0W2IBUUjW5T6tLhRw0MwiUeU9?= =?us-ascii?Q?Uqn7X/kXN4C7noRlKg=3D?= X-Microsoft-Antispam-Message-Info: LPF4sFbFEmN/wfnQHMVI0qxEQhzFEoJomiGLQnVNrmDrFyP7c0sKKZPnOwyy9y16fR8FI4anjSpVBuu9f05x/WxQAJTaIRxD/dh01KA04c0ypTSkX1gPwRs6CdMRP8f4WquBwTwhPGbB/EjvLIru+avow6NvnvUFmAbvGP6qT+E0nbgoXPmoFKTYHtTGi0C/ X-Microsoft-Exchange-Diagnostics: 1; AM6PR02MB3624; 6:NDX5ZqsbP79RjqhufDa8fsOkztCjzI1P+UgkcogKwvRGpOpbUEtYCp35QezY7eIumrBpbDTPhFBAgT37TX5vqq8G8M8xY0s3v1X2jwZfmnHY8173n76dsqQO/63STyaIWXOz1PqiuDAgXSXUTLQs1PsiYNOKJhd8F3w06T4vwhqoDpy8XNdDVQQxISGG5KWrbXHAHCuIExVt2UUWeINquGWyUjvIzkA88xkEO0lsHZ90jEBFlCwN5KBHCsjJhiuBeOT1QWYBZ59PcriDm/zRzpt+E9i2orNo34CpJ+gBbhMiaFYTu+LlFc3mN8PV9hKiFnwSthV98e7DSKYOeDmtvNc2uXv8+uajrMf9D4kb20JE5OWSx5KreQAVA+sKHNJYRLlwbBUrxGQDGjLFvsBmCBATTSENXqiJ9cSgYye+46JOvZgloLOfB8iFKDjJosPhNdpVX9PBb8ZJVJsZG2Mm+A==; 5:2GrDacG3NI3JK7+l7S+kO6wjWZw9EWXIz0zCF/bdi3I+MsO72dZJ187Tbr2WkIdYIPYTHPdI6t8S/CXCbw/EgYvxqmRq7Kp1EjdZcYxdX5nZpw0uUQMxGajkNpasbv96SZE385luCR8MT0h/8Ua9syYxXH4MjDjtx3bhXVoPHo8=; 24:Tp0DGdBwftkgAJoHhQ/OSlz39Qei5n3Jxv96byX5DMOw9U+v6OGWIH1Z6LpW8BWwIfMaqcWoSRGYG7do7NQNAHMGvNu9L+KAQdqsRhPRleY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM6PR02MB3624; 7:bNI4I78CZleskLNO9Z54CAzyDukfAXbq9iM0dCNKBBlMIkpvGjwQvUB+i5gtpMKi3ESynehgvrGlYrmCbQ3iuhgalCuxcN9II822kwp2BevxzAGritd9C96yLlUGoPXdBX+PsfgUrda/ICkYwYFlIz7xZB+mU6Ws5v6RMJ8CK3bEvmqhkIVgSz7xGMPEtha56KPqr9f8c/QvzGCw+V/rqhcjIWSoNM+mVVRFw5uNUGexvhp/ss3ab/z1hluifkNo X-OriginatorOrg: tandemg.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 10:11:07.3631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc27a19-5da3-4fa0-3459-08d5d1df2551 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d690b55a-f04a-454b-9f62-fb1e25467a25 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR02MB3624 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since 'filled' member in station_info changed to u64, BIT_ULL macro should be used with NL80211_STA_INFO_* attribute types instead of BIT. The BIT macro uses unsigned long type which some architectures handle as 32bit and this results in compilation warnings such as: net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS); ^ Signed-off-by: Omer Efrat --- net/wireless/nl80211.c | 22 +++++++++++----------- net/wireless/wext-compat.c | 10 +++++----- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 07514ca..abe838f 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -4561,14 +4561,14 @@ static int nl80211_send_station(struct sk_buff *msg, u32 cmd, u32 portid, PUT_SINFO(CONNECTED_TIME, connected_time, u32); PUT_SINFO(INACTIVE_TIME, inactive_time, u32); - if (sinfo->filled & (BIT(NL80211_STA_INFO_RX_BYTES) | - BIT(NL80211_STA_INFO_RX_BYTES64)) && + if (sinfo->filled & (BIT_ULL(NL80211_STA_INFO_RX_BYTES) | + BIT_ULL(NL80211_STA_INFO_RX_BYTES64)) && nla_put_u32(msg, NL80211_STA_INFO_RX_BYTES, (u32)sinfo->rx_bytes)) goto nla_put_failure; - if (sinfo->filled & (BIT(NL80211_STA_INFO_TX_BYTES) | - BIT(NL80211_STA_INFO_TX_BYTES64)) && + if (sinfo->filled & (BIT_ULL(NL80211_STA_INFO_TX_BYTES) | + BIT_ULL(NL80211_STA_INFO_TX_BYTES64)) && nla_put_u32(msg, NL80211_STA_INFO_TX_BYTES, (u32)sinfo->tx_bytes)) goto nla_put_failure; @@ -4588,24 +4588,24 @@ static int nl80211_send_station(struct sk_buff *msg, u32 cmd, u32 portid, default: break; } - if (sinfo->filled & BIT(NL80211_STA_INFO_CHAIN_SIGNAL)) { + if (sinfo->filled & BIT_ULL(NL80211_STA_INFO_CHAIN_SIGNAL)) { if (!nl80211_put_signal(msg, sinfo->chains, sinfo->chain_signal, NL80211_STA_INFO_CHAIN_SIGNAL)) goto nla_put_failure; } - if (sinfo->filled & BIT(NL80211_STA_INFO_CHAIN_SIGNAL_AVG)) { + if (sinfo->filled & BIT_ULL(NL80211_STA_INFO_CHAIN_SIGNAL_AVG)) { if (!nl80211_put_signal(msg, sinfo->chains, sinfo->chain_signal_avg, NL80211_STA_INFO_CHAIN_SIGNAL_AVG)) goto nla_put_failure; } - if (sinfo->filled & BIT(NL80211_STA_INFO_TX_BITRATE)) { + if (sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) { if (!nl80211_put_sta_rate(msg, &sinfo->txrate, NL80211_STA_INFO_TX_BITRATE)) goto nla_put_failure; } - if (sinfo->filled & BIT(NL80211_STA_INFO_RX_BITRATE)) { + if (sinfo->filled & BIT_ULL(NL80211_STA_INFO_RX_BITRATE)) { if (!nl80211_put_sta_rate(msg, &sinfo->rxrate, NL80211_STA_INFO_RX_BITRATE)) goto nla_put_failure; @@ -4621,7 +4621,7 @@ static int nl80211_send_station(struct sk_buff *msg, u32 cmd, u32 portid, PUT_SINFO(PEER_PM, peer_pm, u32); PUT_SINFO(NONPEER_PM, nonpeer_pm, u32); - if (sinfo->filled & BIT(NL80211_STA_INFO_BSS_PARAM)) { + if (sinfo->filled & BIT_ULL(NL80211_STA_INFO_BSS_PARAM)) { bss_param = nla_nest_start(msg, NL80211_STA_INFO_BSS_PARAM); if (!bss_param) goto nla_put_failure; @@ -4640,7 +4640,7 @@ static int nl80211_send_station(struct sk_buff *msg, u32 cmd, u32 portid, nla_nest_end(msg, bss_param); } - if ((sinfo->filled & BIT(NL80211_STA_INFO_STA_FLAGS)) && + if ((sinfo->filled & BIT_ULL(NL80211_STA_INFO_STA_FLAGS)) && nla_put(msg, NL80211_STA_INFO_STA_FLAGS, sizeof(struct nl80211_sta_flag_update), &sinfo->sta_flags)) @@ -10160,7 +10160,7 @@ static int cfg80211_cqm_rssi_update(struct cfg80211_registered_device *rdev, if (err) return err; - if (sinfo.filled & BIT(NL80211_STA_INFO_BEACON_SIGNAL_AVG)) + if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_BEACON_SIGNAL_AVG)) wdev->cqm_config->last_rssi_event_value = (s8) sinfo.rx_beacon_signal_avg; } diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c index 05186a4..167f702 100644 --- a/net/wireless/wext-compat.c +++ b/net/wireless/wext-compat.c @@ -1278,7 +1278,7 @@ static int cfg80211_wext_giwrate(struct net_device *dev, if (err) return err; - if (!(sinfo.filled & BIT(NL80211_STA_INFO_TX_BITRATE))) + if (!(sinfo.filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE))) return -EOPNOTSUPP; rate->value = 100000 * cfg80211_calculate_bitrate(&sinfo.txrate); @@ -1320,7 +1320,7 @@ static struct iw_statistics *cfg80211_wireless_stats(struct net_device *dev) switch (rdev->wiphy.signal_type) { case CFG80211_SIGNAL_TYPE_MBM: - if (sinfo.filled & BIT(NL80211_STA_INFO_SIGNAL)) { + if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_SIGNAL)) { int sig = sinfo.signal; wstats.qual.updated |= IW_QUAL_LEVEL_UPDATED; wstats.qual.updated |= IW_QUAL_QUAL_UPDATED; @@ -1334,7 +1334,7 @@ static struct iw_statistics *cfg80211_wireless_stats(struct net_device *dev) break; } case CFG80211_SIGNAL_TYPE_UNSPEC: - if (sinfo.filled & BIT(NL80211_STA_INFO_SIGNAL)) { + if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_SIGNAL)) { wstats.qual.updated |= IW_QUAL_LEVEL_UPDATED; wstats.qual.updated |= IW_QUAL_QUAL_UPDATED; wstats.qual.level = sinfo.signal; @@ -1347,9 +1347,9 @@ static struct iw_statistics *cfg80211_wireless_stats(struct net_device *dev) } wstats.qual.updated |= IW_QUAL_NOISE_INVALID; - if (sinfo.filled & BIT(NL80211_STA_INFO_RX_DROP_MISC)) + if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_RX_DROP_MISC)) wstats.discard.misc = sinfo.rx_dropped_misc; - if (sinfo.filled & BIT(NL80211_STA_INFO_TX_FAILED)) + if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_TX_FAILED)) wstats.discard.retries = sinfo.tx_failed; return &wstats;