| Message ID | 1536761412-24932-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcm80211: remove redundant condition check before debugfs_remove_recursive | expand |
zhong jiang <zhongjiang@huawei.com> wrote: > debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just > remove the condition check before debugfs_remove_recursive. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> It seems you already submitted an identical patch four days earlier: https://patchwork.kernel.org/patch/10593061/ Why the duplicate? Please ALWAYS add a changelog and increase the version number: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
On 2018/9/20 20:07, Kalle Valo wrote: > zhong jiang <zhongjiang@huawei.com> wrote: > >> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just >> remove the condition check before debugfs_remove_recursive. >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> > It seems you already submitted an identical patch four days earlier: > > https://patchwork.kernel.org/patch/10593061/ > > Why the duplicate? Please ALWAYS add a changelog and increase the version number: I am sorry for that. Maybe I send the patch earlier, but I remeber I should forget to cc to netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch. Sincerely, zhong jiang > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing >
zhong jiang <zhongjiang@huawei.com> writes: > On 2018/9/20 20:07, Kalle Valo wrote: >> zhong jiang <zhongjiang@huawei.com> wrote: >> >>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just >>> remove the condition check before debugfs_remove_recursive. >>> >>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> It seems you already submitted an identical patch four days earlier: >> >> https://patchwork.kernel.org/patch/10593061/ >> >> Why the duplicate? Please ALWAYS add a changelog and increase the version number: > > I am sorry for that. Maybe I send the patch earlier, but I remeber I > should forget to cc to > netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch. Even then please increase the version number and mention in the change log why you sent a new version. Otherwise you will make maintainers confused and wasting time with asking what has changed.
On 2018/9/20 20:30, Kalle Valo wrote: > zhong jiang <zhongjiang@huawei.com> writes: > >> On 2018/9/20 20:07, Kalle Valo wrote: >>> zhong jiang <zhongjiang@huawei.com> wrote: >>> >>>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just >>>> remove the condition check before debugfs_remove_recursive. >>>> >>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >>> It seems you already submitted an identical patch four days earlier: >>> >>> https://patchwork.kernel.org/patch/10593061/ >>> >>> Why the duplicate? Please ALWAYS add a changelog and increase the version number: >> I am sorry for that. Maybe I send the patch earlier, but I remeber I >> should forget to cc to >> netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch. > Even then please increase the version number and mention in the change > log why you sent a new version. Otherwise you will make maintainers > confused and wasting time with asking what has changed. > Get it and will keep it in mind . Thanks Sincerely, zhong jiang
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c index 2fe1f68..3bd54f1 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c @@ -62,8 +62,7 @@ int brcms_debugfs_attach(struct brcms_pub *drvr) void brcms_debugfs_detach(struct brcms_pub *drvr) { - if (!IS_ERR_OR_NULL(drvr->dbgfs_dir)) - debugfs_remove_recursive(drvr->dbgfs_dir); + debugfs_remove_recursive(drvr->dbgfs_dir); } struct dentry *brcms_debugfs_get_devdir(struct brcms_pub *drvr)
debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just remove the condition check before debugfs_remove_recursive. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)