| Message ID | 1539004909-195005-1-git-send-email-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net-next] mt76x0: pci: fix set external PA I/O current | expand |
> Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device': > drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning: > variable 'data' set but not used [-Wunused-but-set-variable] > > It seems correct value to write is 'data' > > Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
From: YueHaibing <yuehaibing@huawei.com> Date: Mon, 8 Oct 2018 13:21:49 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device': > drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning: > variable 'data' set but not used [-Wunused-but-set-variable] > > It seems correct value to write is 'data' > > Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Wireless changes should be marked as appropriate in the Subject line for targetting the wireless GIT tree, not "net-next".
On 2018/10/9 2:02, David Miller wrote: > From: YueHaibing <yuehaibing@huawei.com> > Date: Mon, 8 Oct 2018 13:21:49 +0000 > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device': >> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning: >> variable 'data' set but not used [-Wunused-but-set-variable] >> >> It seems correct value to write is 'data' >> >> Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap") >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Wireless changes should be marked as appropriate in the Subject line > for targetting the wireless GIT tree, not "net-next". Ok, will fix it in v2. > > . >
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c index 87997cd..0426c68 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c @@ -106,12 +106,12 @@ static int mt76x0e_register_device(struct mt76x02_dev *dev) if (val & MT_EE_NIC_CONF_0_PA_IO_CURRENT) { u32 data; - /* set external external PA I/O + /* set external PA I/O * current to 16mA */ data = mt76_rr(dev, 0x11c); - val |= 0xc03; - mt76_wr(dev, 0x11c, val); + data |= 0xc03; + mt76_wr(dev, 0x11c, data); } }
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device': drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning: variable 'data' set but not used [-Wunused-but-set-variable] It seems correct value to write is 'data' Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)