From patchwork Thu Nov 29 10:48:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pan Bian X-Patchwork-Id: 10704331 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A608A109C for ; Thu, 29 Nov 2018 10:48:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93DBB2E6D1 for ; Thu, 29 Nov 2018 10:48:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85B662E6E8; Thu, 29 Nov 2018 10:48:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BD232E6D1 for ; Thu, 29 Nov 2018 10:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbeK2Vx3 (ORCPT ); Thu, 29 Nov 2018 16:53:29 -0500 Received: from m12-14.163.com ([220.181.12.14]:42147 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbeK2Vx3 (ORCPT ); Thu, 29 Nov 2018 16:53:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=eUhoG1eAN6kMRBfGZM GcU/MOPS+++sKe5nt78mRCxpo=; b=YOGM5oubWBEJvH+XzDzfF2AdyWwphnGpU2 pmZz0nRpnZBeO/HmI7C4bTz8DafJlyn0/dqPTesdN8mrCTPLO1v6Daj+LKfp05Am b2b+yMHQ6y5nsJln+WNeFSFrKdwMNYzoawaCwyBIKDdnqERZMotVPIQErO9PaOnO IcUO2/Z1s= Received: from bp.localdomain (unknown [106.120.213.96]) by smtp10 (Coremail) with SMTP id DsCowABHr87ow_9b8LwKCg--.25788S3; Thu, 29 Nov 2018 18:48:11 +0800 (CST) From: Pan Bian To: Herton Ronaldo Krzesinski , Hin-Tak Leung , Larry Finger , Kalle Valo , "David S. Miller" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH] rtl818x: fix potential use after free Date: Thu, 29 Nov 2018 18:48:10 +0800 Message-Id: <1543488490-101743-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DsCowABHr87ow_9b8LwKCg--.25788S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF1rArWUur4rXFyftF45trb_yoWDZFg_ur W8KFs7ArWvkrs5ua13CayxAr4SyrWrXa1rCa9aqFyfGryYqFZ09rZ7ZasxX398GFy8uFy5 Jw4DJFyrJa4YqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnahF7UUUUU== X-Originating-IP: [106.120.213.96] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBzwsOclaD0dXx5QAAs9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP entry is released via usb_put_urb just after calling usb_submit_urb. However, entry is used if the submission fails, resulting in a use after free bug. The patch fixes this. Signed-off-by: Pan Bian ACKed-by: Larry Finger --- drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c index cec3778..1a2ea8b 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c @@ -444,12 +444,13 @@ static int rtl8187_init_urbs(struct ieee80211_hw *dev) skb_queue_tail(&priv->rx_queue, skb); usb_anchor_urb(entry, &priv->anchored); ret = usb_submit_urb(entry, GFP_KERNEL); - usb_put_urb(entry); if (ret) { skb_unlink(skb, &priv->rx_queue); usb_unanchor_urb(entry); + usb_put_urb(entry); goto err; } + usb_put_urb(entry); } return ret;