| Message ID | 1554539344-12596-1-git-send-email-hofrat@osadl.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | staging: wilc1000: drop explicit conversion to bool | expand |
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index c238969..6c9fd3a 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -11,7 +11,7 @@ static inline bool is_wilc1000(u32 id) { - return ((id & 0xfffff000) == 0x100000 ? true : false); + return ((id & 0xfffff000) == 0x100000); } static inline void acquire_bus(struct wilc *wilc, enum bus_acquire acquire)
As the expression evaluates to a boolean anyway (relational and logical operators) conversion with the ternary operator is not needed here as coccinelle notes (boolconv.cocci) Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> --- scripts/coccinelle/misc/boolconv.cocci warned about: drivers/staging/wilc1000/wilc_wlan.c:14:48-53: WARNING: conversion to bool not needed here Patch was compile tested with: x86_64_defconfig + Staging=y, WILC1000_SDIO=m, WILC1000_SPI=m, WILC1000=m (checkpatch, sparse and cocci clean otherwise) Patch is against 5.1-rc3 (localversion-next is -next-20190403) drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)