diff mbox series

[-next,2/2] ipw2x00: remove set but not used variable 'force_update'

Message ID 1573890083-33761-3-git-send-email-zhengbin13@huawei.com (mailing list archive)
State Accepted
Commit f89f1aefff5a53917579bbf8b85be09d7cc17daf
Delegated to: Kalle Valo
Headers show
Series ipw2x00: remove some set but not used variables | expand

Commit Message

Zheng Bin Nov. 16, 2019, 7:41 a.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/intel/ipw2x00/ipw2100.c: In function shim__set_security:
drivers/net/wireless/intel/ipw2x00/ipw2100.c:5582:9: warning: variable force_update set but not used [-Wunused-but-set-variable]

It is introduced by commit 367a1092b555 ("ipw2x00:
move under intel vendor directory"), but never used, so remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
2.7.4

Comments

Kalle Valo Nov. 16, 2019, 7:51 a.m. UTC | #1
zhengbin <zhengbin13@huawei.com> writes:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/intel/ipw2x00/ipw2100.c: In function shim__set_security:
> drivers/net/wireless/intel/ipw2x00/ipw2100.c:5582:9: warning: variable force_update set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 367a1092b555 ("ipw2x00:
> move under intel vendor directory"), but never used, so remove it.

Same here, I'll remove this sentence as well.
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index 8dfbaff..c4c83ab 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -5565,7 +5565,7 @@  static void shim__set_security(struct net_device *dev,
 			       struct libipw_security *sec)
 {
 	struct ipw2100_priv *priv = libipw_priv(dev);
-	int i, force_update = 0;
+	int i;

 	mutex_lock(&priv->action_mutex);
 	if (!(priv->status & STATUS_INITIALIZED))
@@ -5605,7 +5605,6 @@  static void shim__set_security(struct net_device *dev,
 		priv->ieee->sec.flags |= SEC_ENABLED;
 		priv->ieee->sec.enabled = sec->enabled;
 		priv->status |= STATUS_SECURITY_UPDATED;
-		force_update = 1;
 	}

 	if (sec->flags & SEC_ENCRYPT)