| Message ID | 1600885519-29535-1-git-send-email-kathirve@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: removing the ath11k debugfs dir properly | expand |
Karthikeyan Kathirvel <kathirve@codeaurora.org> wrote: > ath11k_debug_pdev_destroy was not called for proper cleaning of debug > files when destroying the pdev, this results in not removing the ath11k > directory in debugfs folder even after rmmod of ath11k. So when next > time doing insmod of ath11k prevents creating another ath11k directory, > hence causing ipq8074_2 to get created in parent dir of debugfs. > > Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org> Fails to apply, please rebase. Also Tested-on missing. error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973 error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply stg import: Diff does not apply cleanly Patch set to Changes Requested.
Please ignore this patch Thanks Karthikeyan On 2020-09-24 21:46, Kalle Valo wrote: > Karthikeyan Kathirvel <kathirve@codeaurora.org> wrote: > >> ath11k_debug_pdev_destroy was not called for proper cleaning of debug >> files when destroying the pdev, this results in not removing the >> ath11k >> directory in debugfs folder even after rmmod of ath11k. So when next >> time doing insmod of ath11k prevents creating another ath11k >> directory, >> hence causing ipq8074_2 to get created in parent dir of debugfs. >> >> Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org> > > Fails to apply, please rebase. Also Tested-on missing. > > error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973 > error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply > stg import: Diff does not apply cleanly > > Patch set to Changes Requested.
diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c index 0ba234a..c4759bb 100644 --- a/drivers/net/wireless/ath/ath11k/debug.c +++ b/drivers/net/wireless/ath/ath11k/debug.c @@ -973,6 +973,7 @@ void ath11k_debug_soc_destroy(struct ath11k_base *ab) { debugfs_remove_recursive(ab->debugfs_soc); ab->debugfs_soc = NULL; + ath11k_debug_pdev_destroy(ab); } void ath11k_debug_fw_stats_init(struct ath11k *ar)
ath11k_debug_pdev_destroy was not called for proper cleaning of debug files when destroying the pdev, this results in not removing the ath11k directory in debugfs folder even after rmmod of ath11k. So when next time doing insmod of ath11k prevents creating another ath11k directory, hence causing ipq8074_2 to get created in parent dir of debugfs. Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org> --- drivers/net/wireless/ath/ath11k/debug.c | 1 + 1 file changed, 1 insertion(+)