diff mbox series

[net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

Message ID 1617711406-49649-1-git-send-email-huangguobin4@huawei.com
State Accepted
Commit e9642be26a372013e47801e1dd98e8f4dcf78f50
Delegated to: Kalle Valo
Headers show
Series [net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock | expand

Commit Message

Huang Guobin April 6, 2021, 12:16 p.m. UTC
From: Guobin Huang <huangguobin4@huawei.com>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 .../realtek/rtlwifi/rtl8192de/sw.c         | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Kalle Valo April 17, 2021, 5:34 p.m. UTC | #1
Huang Guobin <huangguobin4@huawei.com> wrote:

> From: Guobin Huang <huangguobin4@huawei.com>
> 
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

e9642be26a37 rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
index 1dbdddce0823..a74724c971b9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
@@ -372,18 +372,14 @@  static struct pci_driver rtl92de_driver = {
 
 /* add global spin lock to solve the problem that
  * Dul mac register operation on the same time */
-spinlock_t globalmutex_power;
-spinlock_t globalmutex_for_fwdownload;
-spinlock_t globalmutex_for_power_and_efuse;
+DEFINE_SPINLOCK(globalmutex_power);
+DEFINE_SPINLOCK(globalmutex_for_fwdownload);
+DEFINE_SPINLOCK(globalmutex_for_power_and_efuse);
 
 static int __init rtl92de_module_init(void)
 {
 	int ret = 0;
 
-	spin_lock_init(&globalmutex_power);
-	spin_lock_init(&globalmutex_for_fwdownload);
-	spin_lock_init(&globalmutex_for_power_and_efuse);
-
 	ret = pci_register_driver(&rtl92de_driver);
 	if (ret)
 		WARN_ONCE(true, "rtl8192de: No device found\n");