diff mbox series

[1/8] dt-bindings:net:wireless:ieee80211: introduce regdomain property

Message ID 1ff764d84e1fb83768c2e9d233c27b0ed1ef4294.1617625912.git.lorenzo@kernel.org
State Superseded
Delegated to: Kalle Valo
Headers show
Series introduce single-sku support for mt7663/mt7921 drivers | expand

Commit Message

Lorenzo Bianconi April 5, 2021, 12:40 p.m. UTC
Add regdomain property to ieee80211 binding

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 .../devicetree/bindings/net/wireless/ieee80211.yaml      | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Rob Herring April 9, 2021, 3:13 p.m. UTC | #1
On Mon, Apr 05, 2021 at 02:40:25PM +0200, Lorenzo Bianconi wrote:
> Add regdomain property to ieee80211 binding
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../devicetree/bindings/net/wireless/ieee80211.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> index d58e1571df9b..6557c6348cac 100644
> --- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> @@ -30,6 +30,15 @@ properties:
>        different 5 GHz subbands. Using them incorrectly could not work or
>        decrease performance noticeably
>  
> +  regdomain:
> +    minItems: 1
> +    maxItems: 1
> +    contains:

If only 1 entry, then 'contains' is pointless. Just 'enum' is enough. 
You also need a 'description'.

> +      enum:
> +        - FCC
> +        - ETSI
> +        - JP
> +
>  additionalProperties: true
>  
>  examples:
> -- 
> 2.30.2
>
Lorenzo Bianconi April 9, 2021, 9:27 p.m. UTC | #2
> On Mon, Apr 05, 2021 at 02:40:25PM +0200, Lorenzo Bianconi wrote:
> > Add regdomain property to ieee80211 binding
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../devicetree/bindings/net/wireless/ieee80211.yaml      | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> > index d58e1571df9b..6557c6348cac 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> > @@ -30,6 +30,15 @@ properties:
> >        different 5 GHz subbands. Using them incorrectly could not work or
> >        decrease performance noticeably
> >  
> > +  regdomain:
> > +    minItems: 1
> > +    maxItems: 1
> > +    contains:
> 
> If only 1 entry, then 'contains' is pointless. Just 'enum' is enough. 
> You also need a 'description'.

ack, I will fix it in v2 moving it in mt76.yaml patch

Regards,
Lorenzo

> 
> > +      enum:
> > +        - FCC
> > +        - ETSI
> > +        - JP
> > +
> >  additionalProperties: true
> >  
> >  examples:
> > -- 
> > 2.30.2
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
index d58e1571df9b..6557c6348cac 100644
--- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
@@ -30,6 +30,15 @@  properties:
       different 5 GHz subbands. Using them incorrectly could not work or
       decrease performance noticeably
 
+  regdomain:
+    minItems: 1
+    maxItems: 1
+    contains:
+      enum:
+        - FCC
+        - ETSI
+        - JP
+
 additionalProperties: true
 
 examples: