From patchwork Thu Jul 23 18:17:16 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 36994 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6NIHoU4009204 for ; Thu, 23 Jul 2009 18:17:51 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbZGWSRS (ORCPT ); Thu, 23 Jul 2009 14:17:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752254AbZGWSRS (ORCPT ); Thu, 23 Jul 2009 14:17:18 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:49966 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbZGWSRR (ORCPT ); Thu, 23 Jul 2009 14:17:17 -0400 Received: from mcgrof by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1MU2qy-0008PF-Dx; Thu, 23 Jul 2009 18:17:16 +0000 Date: Thu, 23 Jul 2009 14:17:16 -0400 From: "Luis R. Rodriguez" To: Fabio Rossi Cc: "Luis R. Rodriguez" , linux-wireless@vger.kernel.org Subject: Re: WARNING: at net/mac80211/tx.c:561 Message-ID: <20090723181716.GA26729@bombadil.infradead.org> References: <200907230051.57201.rossi.f@inwind.it> <200907231907.47751.rossi.f@inwind.it> <43e72e890907231021m46139567s3de4ed4cc2812938@mail.gmail.com> <200907231928.44337.rossi.f@inwind.it> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <200907231928.44337.rossi.f@inwind.it> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Jul 23, 2009 at 07:28:44PM +0200, Fabio Rossi wrote: > On Thursday 23 July 2009, Luis R. Rodriguez wrote: > > > On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi wrote: > > > On Thursday 23 July 2009, Luis R. Rodriguez wrote: > > >> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi wrote: > > >> > I'm using the last wireless-testing.git and I have experienced the > > >> > following WARNING: > > >> > > > >> >  WARNING: at net/mac80211/tx.c:561 > > >> > ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]() > > >> > > >> Please try a git pull > > > > > > I was already working with the latest release: > > >  v2.6.31-rc3-28452-g5bfcdb0 > > > so I confirm that I get the warning quite often (every 15 seconds). > > > > What channel is your AP on? > > Is your AP 00:0c:f6:xx:xx:xx ? > > Yes, that is my AP configured on channel 8 (Frequency 2.447 GHz): > > Cell 05 - Address: 00:0C:F6:xx:xx:xx > Channel:8 > Frequency:2.447 GHz (Channel 8) > Quality=48/70 Signal level=-62 dBm > Encryption key:on > ESSID:"" > Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s > Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s > 36 Mb/s; 48 Mb/s; 54 Mb/s > Mode:Master > Extra:tsf=000000007803aa0c > Extra: Last beacon: 4352ms ago > IE: Unknown: 0000 > IE: Unknown: 010482848B96 > IE: Unknown: 030108 > IE: Unknown: 050400010000 > IE: Unknown: 2A0104 > IE: Unknown: 32080C1218243048606C > IE: Unknown: DD07000C4301000000 It is as I suspected, a real WARNING for a bug in mac80211, we should not be sending frames on 5 GHz onyour 2.4 GHz AP. Please try this patch: From: Luis R. Rodriguez Subject: [PATCH] mac80211: do not trigger beacon work if scanning We were issues probe requests to the associated AP on the wrong band. This leads to finding not bitrate. We should not be doing this, so prevent the timer from stuffing beacon loss work on the mac80211 workqueue. Signed-off-by: Luis R. Rodriguez --- net/mac80211/mlme.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 523c0d9..e90992e 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data) (struct ieee80211_sub_if_data *) data; struct ieee80211_local *local = sdata->local; - if (local->quiescing) + if (local->quiescing || local->sw_scanning || local->hw_scanning) return; queue_work(sdata->local->hw.workqueue,