From patchwork Mon Aug 3 13:09:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Lamparter X-Patchwork-Id: 38893 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n73DA0x3019055 for ; Mon, 3 Aug 2009 13:10:00 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754996AbZHCNJ5 (ORCPT ); Mon, 3 Aug 2009 09:09:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754994AbZHCNJ5 (ORCPT ); Mon, 3 Aug 2009 09:09:57 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:43976 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754849AbZHCNJ5 (ORCPT ); Mon, 3 Aug 2009 09:09:57 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate03.web.de (Postfix) with ESMTP id C873410990BD9; Mon, 3 Aug 2009 15:09:56 +0200 (CEST) Received: from [91.22.211.142] (helo=debian64.daheim) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #277) id 1MXxIa-0003VC-00; Mon, 03 Aug 2009 15:09:56 +0200 Received: from debian64.daheim ([192.168.0.4] helo=debian64.localnet ident=chuck) by debian64.daheim with esmtpa (Exim 4.69) (envelope-from ) id 1MXxIZ-0004hv-UV; Mon, 03 Aug 2009 15:09:55 +0200 From: Christian Lamparter To: "Joerg Albert" Subject: Re: ar9170usb crashes during iwconfig for ad-hoc mode Date: Mon, 3 Aug 2009 15:09:54 +0200 User-Agent: KMail/1.11.4 (Linux/2.6.31-rc3-wl; KDE/4.2.4; x86_64; ; ) Cc: Johannes Berg , linux-wireless@vger.kernel.org References: <4A759341.1090006@gmx.de> <1249289274.4561.0.camel@johannes.local> <20090803123642.242160@gmx.net> In-Reply-To: <20090803123642.242160@gmx.net> MIME-Version: 1.0 Message-Id: <200908031509.55277.chunkeey@web.de> X-Sender: chunkeey@web.de X-Provags-ID: V01U2FsdGVkX1/ktDSJF2ffVeocgo0By/E0ywD4DgvSSyNqi3QU Uz6GRZEuYJBN6qZZbTEMnD58V5YrawvEjUYSQBWpZnF3iH9dSF NQnxBm9BQ= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Monday 03 August 2009 14:36:42 Joerg Albert wrote: > > > On Mon, 2009-08-03 at 10:44 +0200, Johannes Berg wrote: > > > > > > > ifconfig wlan1 down > > > > > iwconfig wlan1 mode managed essid huhu > > > > > ifconfig wlan1 up > > > > > ifconfig wlan1 down > > > > > iwconfig wlan1 mode ad-hoc essid huhu_a channel 1 > > > > > No, it's a bug in cfg80211 :) > > > > But it's not making sense to me. I'll have to try to reproduce it. In > > any case, we shouldn't be calling in to mac80211 from cfg80211 while the > > interface is down. > > I guess this is caused by the call to __cfg80211_leave_ibss() > in net/wireless/ibss.c::cfg80211_ibss_wext_siwfreq() trying to > disable the beacon via net/mac80211::ieee80211_ibss_leave(). what about this? (only compiled so far, don't have the device here...) Regards, Chr diff --git a/drivers/net/wireless/ath/ar9170/main.c b/drivers/net/wireless/ath/ar9170/main.c index 099ed3c..9c97ad7 100644 --- a/drivers/net/wireless/ath/ar9170/main.c +++ b/drivers/net/wireless/ath/ar9170/main.c @@ -2177,7 +2177,7 @@ static void ar9170_op_bss_info_changed(struct ieee80211_hw *hw, goto out; } - if (changed & (BSS_CHANGED_BEACON | BSS_CHANGED_BEACON_ENABLED)) { + if (changed & BSS_CHANGED_BEACON_ENABLED) { err = ar9170_update_beacon(ar); if (err) goto out;