From patchwork Fri Oct 2 19:38:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Buesch X-Patchwork-Id: 51419 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n92JcADm020891 for ; Fri, 2 Oct 2009 19:38:10 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751074AbZJBTiD (ORCPT ); Fri, 2 Oct 2009 15:38:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752545AbZJBTiD (ORCPT ); Fri, 2 Oct 2009 15:38:03 -0400 Received: from bu3sch.de ([62.75.166.246]:54751 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbZJBTiC (ORCPT ); Fri, 2 Oct 2009 15:38:02 -0400 Received: by vs166246.vserver.de with esmtpa (Exim 4.69) id 1Mtnx7-0004ju-Cy; Fri, 02 Oct 2009 19:38:05 +0000 From: Michael Buesch To: Andrew Price Subject: Re: WARNING: at drivers/net/wireless/b43/main.c:3923 b43_wireless_core_stop+0x1c8/0x1d0() Date: Fri, 2 Oct 2009 21:38:02 +0200 User-Agent: KMail/1.9.9 Cc: linux-wireless References: <20091002193042.GA3719@plato.andrewprice.me.uk> In-Reply-To: <20091002193042.GA3719@plato.andrewprice.me.uk> X-Move-Along: Nothing to see here. No, really... Nothing. MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200910022138.04296.mb@bu3sch.de> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --- wireless-testing.orig/drivers/net/wireless/b43/main.c +++ wireless-testing/drivers/net/wireless/b43/main.c @@ -3874,6 +3874,7 @@ static struct b43_wldev * b43_wireless_c { struct b43_wl *wl = dev->wl; struct b43_wldev *orig_dev; + u32 mask; redo: if (!dev || b43_status(dev) < B43_STAT_STARTED) @@ -3920,7 +3921,8 @@ redo: goto redo; return dev; } - B43_WARN_ON(b43_read32(dev, B43_MMIO_GEN_IRQ_MASK)); + mask = b43_read32(dev, B43_MMIO_GEN_IRQ_MASK); + B43_WARN_ON(mask != 0xFFFFFFFF && mask); /* Drain the TX queue */ while (skb_queue_len(&wl->tx_queue))