From patchwork Thu Oct 8 04:34:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Rodriguez X-Patchwork-Id: 52417 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n984dJFZ022877 for ; Thu, 8 Oct 2009 04:39:19 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbZJHEfG (ORCPT ); Thu, 8 Oct 2009 00:35:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751672AbZJHEfG (ORCPT ); Thu, 8 Oct 2009 00:35:06 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:38662 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbZJHEfF (ORCPT ); Thu, 8 Oct 2009 00:35:05 -0400 Received: from mcgrof by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1Mvkhu-0001ab-Ub; Thu, 08 Oct 2009 04:34:26 +0000 Date: Thu, 8 Oct 2009 00:34:26 -0400 From: "Luis R. Rodriguez" To: "Luis R. Rodriguez" Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, vasanth@atheros.com, Sujith.Manoharan@atheros.com Subject: Re: [PATCH 1/6] ath9k: move common->debug_mask setting to ath_init_softc() Message-ID: <20091008043426.GA5760@bombadil.infradead.org> References: <1254878351-32433-1-git-send-email-lrodriguez@atheros.com> <1254878351-32433-2-git-send-email-lrodriguez@atheros.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1254878351-32433-2-git-send-email-lrodriguez@atheros.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c index 25ae88e..84f4426 100644 --- a/drivers/net/wireless/ath/ath9k/debug.c +++ b/drivers/net/wireless/ath/ath9k/debug.c @@ -23,9 +23,6 @@ #define REG_READ_D(_ah, _reg) \ ath9k_hw_common(_ah)->ops->read((_ah), (_reg)) -static unsigned int ath9k_debug = ATH_DBG_DEFAULT; -module_param_named(debug, ath9k_debug, uint, 0); - static struct dentry *ath9k_debugfs_root; static int ath9k_debugfs_open(struct inode *inode, struct file *file) @@ -565,8 +562,6 @@ int ath9k_init_debug(struct ath_hw *ah) struct ath_common *common = ath9k_hw_common(ah); struct ath_softc *sc = (struct ath_softc *) common->priv; - common->debug_mask = ath9k_debug; - if (!ath9k_debugfs_root) return -ENOENT; diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 86374ad..aeda541 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -29,6 +29,10 @@ static int modparam_nohwcrypt; module_param_named(nohwcrypt, modparam_nohwcrypt, int, 0444); MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption"); +static unsigned int ath9k_debug = ATH_DBG_DEFAULT; +module_param_named(debug, ath9k_debug, uint, 0); +MODULE_PARM_DESC(debug, "Debugging mask"); + /* We use the hw_value as an index into our private channel structure */ #define CHAN2G(_freq, _idx) { \ @@ -1637,6 +1641,7 @@ static int ath_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid, common->ah = ah; common->hw = sc->hw; common->priv = sc; + common->debug_mask = ath9k_debug; /* * Cache line size is used to size and align various