From patchwork Sat Jan 23 13:40:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Nieder X-Patchwork-Id: 74899 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o0NDeCZR025530 for ; Sat, 23 Jan 2010 13:40:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755026Ab0AWNkK (ORCPT ); Sat, 23 Jan 2010 08:40:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755277Ab0AWNkJ (ORCPT ); Sat, 23 Jan 2010 08:40:09 -0500 Received: from mail-iw0-f197.google.com ([209.85.223.197]:65244 "EHLO mail-iw0-f197.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709Ab0AWNkG (ORCPT ); Sat, 23 Jan 2010 08:40:06 -0500 Received: by iwn35 with SMTP id 35so968585iwn.4 for ; Sat, 23 Jan 2010 05:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=bXU5WHJVMOJuaeEgqhtrMP8AfBDRlyfk1KZ2aQao94k=; b=MKeeXqVU0IUmfBxefLfKJnEsuwv+ijydOHjGmvYuco/mmxvprqup5VdeGRp5Ldvi/i ootFs9hor+nn3c+mCfrB6LlE+ExbA5k2xIKhbXMdhQR4aab014uC84PxH6RSEHs44TQe duPYkIUt0V1XHlhwbp/e0d1l8cHPSqxPCLI0c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=iqEUgkeCZJ02JLpdofsZaT3tA2y564WCK20d4fKsG2iaC5EqPoxUrMICe+KrhgIVge ChBJwqWy4uxYsAcAvBzCGG96Fh2nwC3s8ErVmVlQTYN6XrzGTZ6mTI2aeRitPVXLkPD8 df+afvpmviDrLznyzi1B9tppznZj+6BsUjhZk= Received: by 10.231.158.21 with SMTP id d21mr3261679ibx.61.1264254004556; Sat, 23 Jan 2010 05:40:04 -0800 (PST) Received: from progeny.tock (c-98-212-3-231.hsd1.il.comcast.net [98.212.3.231]) by mx.google.com with ESMTPS id 20sm2778655iwn.13.2010.01.23.05.40.03 (version=SSLv3 cipher=RC4-MD5); Sat, 23 Jan 2010 05:40:03 -0800 (PST) Date: Sat, 23 Jan 2010 07:40:05 -0600 From: Jonathan Nieder To: Kacper Cc: linux-wireless@vger.kernel.org, Bob Copeland Subject: Re: ath5k phy0: unsupported jumbo Message-ID: <20100123134005.GA11322@progeny.tock> References: <20100123105111.GA24790@progeny.tock> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 5577bcc..9fffe6c 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -1814,6 +1814,19 @@ ath5k_tasklet_rx(unsigned long data) } if (unlikely(rs.rs_more)) { + /* + * The jumbo flag is supposed to indicate the packet + * is larger than the buffer size. However, we have a + * buffer size of 2500 so that shouldn't happen for + * standard frames. + * + * The relevant frames really are all > 2500 bytes + * (including roundup for cache line). unmap and + * hexdump reveals that they have no 802.11 headers or + * anything of the sort. + * + * XXX just drop the warning? + */ ATH5K_WARN(sc, "unsupported jumbo\n"); goto next; }