From patchwork Fri May 14 14:53:46 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 99623 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4EEs9UD028080 for ; Fri, 14 May 2010 14:54:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089Ab0ENOyI (ORCPT ); Fri, 14 May 2010 10:54:08 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]:42677 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985Ab0ENOyF (ORCPT ); Fri, 14 May 2010 10:54:05 -0400 Received: by wwi18 with SMTP id 18so601796wwi.19 for ; Fri, 14 May 2010 07:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=6IamXC0Ev+Q1sDdci21gbTm6wuBTX9HtJnu0kXZo3DU=; b=rhUG+sbxOqWHV3MQzgYYa4Ah6IJslNBoOKQySDgH0W3Yyff1swwvoxic9Ro3C2ojdk wlR4qVzhvQSM4YBVccg2VTpH1oRGEpRI95aus8yXyY6WoKJDmlWKVKu5puguAID3382T cKoatpDC/7i/ZRDeiS1uD1T/1dQ6yWb3gDcug= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=wLRXbrEGdKFCwei6UCuXVap71wfwqz2Yk7KjrvAwE32RNeR8FvlvaEJgUt8+n6CWT5 ter7ddXyseg6DlSWQQIE9zw/qmHN4oPvChbMWOrh0pFMU5fJnmOm+OBv7tPsnX+FRP+r 9pNpoTTacmEAjJYopQWtV4bajzB4h9hGGna8c= Received: by 10.227.143.213 with SMTP id w21mr1360118wbu.63.1273848843381; Fri, 14 May 2010 07:54:03 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id n61sm1204274wed.6.2010.05.14.07.53.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 14 May 2010 07:54:02 -0700 (PDT) Date: Fri, 14 May 2010 16:53:46 +0200 From: Dan Carpenter To: Zhu Yi Cc: Reinette Chatre , Intel Linux Wireless , "John W. Linville" , Johannes Berg , Wey-Yi Guy , linux-wireless@vger.kernel.org Subject: [patch -next] iwlwifi: testing the wrong variable in iwl_add_bssid_station() Message-ID: <20100514145346.GG17487@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 14 May 2010 14:54:09 +0000 (UTC) diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c index 85ed235..83a2636 100644 --- a/drivers/net/wireless/iwlwifi/iwl-sta.c +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c @@ -431,7 +431,7 @@ int iwl_add_bssid_station(struct iwl_priv *priv, const u8 *addr, bool init_rs, struct iwl_link_quality_cmd *link_cmd; unsigned long flags; - if (*sta_id_r) + if (sta_id_r) *sta_id_r = IWL_INVALID_STATION; ret = iwl_add_station_common(priv, addr, 0, NULL, &sta_id);